ALSA: hda: cs35l41: Remove redundant call to hda_cs_dsp_control_remove()
PATCH 1/1 ALSA: hda: cs35l41: Remove redundant call to hda_cs_dsp_control_remove()
The driver doesn't create any ALSA controls for firmware controls, so it shouldn't be calling hda_cs_dsp_control_remove().
commit 312c04cee408 ("ALSA: hda: cs35l41: Stop creating ALSA Controls for firmware coefficients") removed the call to hda_cs_dsp_add_controls() but didn't remove the call for destroying those controls.
--- sound/pci/hda/cs35l41_hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/cs35l41_hda.c +1 -1
@@ -134,7 +134,7 @@ static const struct reg_sequence cs35l41_hda_mute[] = { };static const struct cs_dsp_client_ops client_ops = { - .control_remove = hda_cs_dsp_control_remove, +/* cs_dsp requires the client to provide this even if it is empty */ }; static int cs35l41_request_tuning_param_file(struct cs35l41_hda *cs35l41, char *tuning_filename,
Signature · 1 line
2.39.2
Quoted 10 lines · Richard Fitzgerald
The driver doesn't create any ALSA controls for firmware controls, so it shouldn't be calling
hda_cs_dsp_control_remove().commit
312c04cee408("ALSA: hda: cs35l41: Stop creating ALSA Controls for firmware coefficients") removed the call tohda_cs_dsp_add_controls()but didn't remove the call for destroying those controls.Signed-off-by Richard Fitzgerald <[email protected]>Fixes 312c04cee408 ("ALSA: hda: cs35l41: Stop creating ALSA Controls for firmware coefficients")
Applied now. Thanks.
Takashi