libkmod: avoid undefined behaviour in libkmod-builtin.c:get_string
PATCH 1/1 libkmod: avoid undefined behaviour in libkmod-builtin.c:get_string
Static analysis has reported a potential UB:
kmod-31/libkmod/libkmod-builtin.c:125: use_invalid: Using "nullp", which points to an out-of-scope variable "buf".
# 123| size_t linesz = 0;
# 124|
# 125|-> while (!nullp) {
# 126| char buf[BUFSIZ];
# 127| ssize_t sz;It seems to be indeed an UB, as nullp is getting assined an address inside object buf, which has a lifetime of the while loop body, and is not available outside of it (specifically, in the while condition, where nullp is checked for NULL). Fix it by putting buf definition in the outer block.
--- libkmod/libkmod-builtin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
libkmod/libkmod-builtin.c +1 -1
@@ -105,11 +105,11 @@ static off_t get_string(struct kmod_builtin_iter *iter, off_t offset, char **line, size_t *size) { int sv_errno; +char buf[BUFSIZ ];char *nullp =NULL ;size_t linesz =0 ;while (!nullp) { -char buf[BUFSIZ ];ssize_t sz;size_t partsz;
Signature · 1 line
2.28.0
Lucas De Marchi
AppliedQuoted 10 lines · Eugene Syromiatnikov
Static analysis has reported a potential UB:
kmod-31/libkmod/libkmod-builtin.c:125: use_invalid: Using "nullp", which points to an out-of-scope variable "buf". # 123| size_t linesz = 0; # 124| # 125|-> while (!nullp) { # 126| char buf[BUFSIZ]; # 127| ssize_t sz;[...]
Applied, thanks!
[1/1] libkmod: avoid undefined behaviour in libkmod-builtin.c:get_string
commit: 5c22362b6b97af9c6b7587f0c3450001e9893115
Best regards,
Signature · 1 line
Lucas De Marchi <[email protected]>