Skip to contentSkip to conversation

ASoC: cs35l56: Patch CS35L56_IRQ1_MASK_18 to the default value

PATCH In review Richard Fitzgerald 2 participants 2 messages Aug 13, 2024 – Aug 15, 2024

Subsystems (4)
lore
Share & tools
lore

Richard Fitzgerald

author maintainer
#0 lore raw

PATCH 1/1 ASoC: cs35l56: Patch CS35L56_IRQ1_MASK_18 to the default value

From: Simon Trimmer <[email protected]>

[ Upstream commit 72776774b55bb59b7b1b09117e915a5030110304 ]

Please apply to 6.10.
The upstream patch should have had a Fixes: tag but it was missing.

Device tuning files made with early revision tooling may contain configuration that can unmask IRQ signals that are owned by the host.

Adding a safe default to the regmap patch ensures that the hardware matches the driver expectations.

---
 sound/soc/codecs/cs35l56-shared.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/cs35l56-shared.c +1 -0
index f609cade805d..58b213722e4e 100644
@@ -24,6 +24,7 @@ static const struct reg_sequence cs35l56_patch[] = {
 	{ CS35L56_SWIRE_DP3_CH2_INPUT,		0x00000019 },
 	{ CS35L56_SWIRE_DP3_CH3_INPUT,		0x00000029 },
 	{ CS35L56_SWIRE_DP3_CH4_INPUT,		0x00000028 },
+	{ CS35L56_IRQ1_MASK_18,			0x1f7df0ff },
 
 	/* These are not reset by a soft-reset, so patch to defaults. */
 	{ CS35L56_MAIN_RENDER_USER_MUTE,	0x00000000 },
Signature · 1 line
2.39.2
maintainer
#1 lore raw
Quoted 13 lines · Richard Fitzgerald

From: Simon Trimmer <[email protected]>

[ Upstream commit 72776774b55bb59b7b1b09117e915a5030110304 ]

Please apply to 6.10.
The upstream patch should have had a Fixes: tag but it was missing.

Device tuning files made with early revision tooling may contain configuration that can unmask IRQ signals that are owned by the host.

Adding a safe default to the regmap patch ensures that the hardware matches the driver expectations.

Quoted 6 lines
---
 sound/soc/codecs/cs35l56-shared.c | 1 +

Now queued up, thanks.

greg k-h