dt-bindings: arm: rockchip: add support for Radxa ROCK Pi E v3.0
Subsystems (2)
PATCH v4 1/2 dt-bindings: arm: rockchip: add support for Radxa ROCK Pi E v3.0
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip.
[1] https://radxa.com/products/rockpi/pie
---
Changes in v4:
- update compatible string for OpenWrt
- drop A-b tag
Changes in v3:
- collect A-b tag
Changes in v2:
- fix typo in commit message
- add missing --- in commit message
- add new section instead of new item in rockchip.yaml
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
@@ -790,6 +790,11 @@ properties: - const: radxa,rockpi-e - const: rockchip,rk3328 + - description: Radxa ROCK Pi E v3.0 + items: + - const: radxa,rock-pi-e-v3 + - const: rockchip,rk3328 + - description: Radxa ROCK Pi N8 items: - const: radxa,rockpi-n8
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v4 2/2 arm64: dts: rockchip: add support for Radxa ROCK Pi E v3.0
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip that ships in a number of RAM/eMMC/WiFi/BT configurations:
- Rockchip RK3328 SoC
- Quad A53 CPU
- 512MB/1GB/2GB DDR4 RAM
- 4/8/16/32GB eMMC
- Micro SD Card slot
- WiFi 4 and BT 4, or WiFi 5 and BT 5
- 1x 1000M Ethernet supporting PoE with add‑on PoE HAT
- 1x 100M Ethernet
- 1x USB 3.0 Type-A port (Host)
- 1x 4-ring 3.5mm headphone jack
- 40 Pin GPIO header
[1] https://radxa.com/products/rockpi/pie
---
Changes in v4:
- update compatible string for OpenWrt
Changes in v3:
- fix conflict for recent change
Changes in v2:
- fix typo in commit message
- add missing --- in commit message
---
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../boot/dts/rockchip/rk3328-rock-pi-e-v3.dts | 15 +
.../boot/dts/rockchip/rk3328-rock-pi-e.dts | 460 +-----------------
...28-rock-pi-e.dts => rk3328-rock-pi-e.dtsi} | 5 -
4 files changed, 31 insertions(+), 450 deletions(-)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dts
rewrite arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts (97%)
copy arch/arm64/boot/dts/rockchip/{rk3328-rock-pi-e.dts => rk3328-rock-pi-e.dtsi} (98%)arch/arm64/boot/dts/rockchip/Makefile +1 -0
@@ -24,6 +24,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-nanopi-r2s.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-orangepi-r1-plus.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-orangepi-r1-plus-lts.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-rock64.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-rock-pi-e-v3.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-rock-pi-e.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-roc-cc.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-roc-pc.dtb
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dts new file +15 -0
@@ -0,0 +1,15 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) + +/dts-v1/; + +#include "rk3328-rock-pi-e.dtsi" + +/ { + model = "Radxa ROCK Pi E v3.0"; + compatible = "radxa,rock-pi-e-v3", "rockchip,rk3328"; + + aliases { + mmc0 = &emmc; + mmc1 = &sdmmc; + }; +};
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts +15 -445
460 lines not on this page · raw message
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi renamed from arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts +0 -5
@@ -17,14 +17,9 @@ #include "rk3328.dtsi" / { - model = "Radxa ROCK Pi E"; - compatible = "radxa,rockpi-e", "rockchip,rk3328"; - aliases { ethernet0 = &gmac2io; ethernet1 = &gmac2phy; - mmc0 = &sdmmc; - mmc1 = &emmc; }; chosen {
Signature · 1 line
2.43.0
Hi,
Quoted 9 lines · FUKAUMI Naoki
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip.
[1] https://radxa.com/products/rockpi/pie
Signed-off-by FUKAUMI Naoki <[email protected]>---
Changes in v4:
- update compatible string for OpenWrt
this is for https://github.com/openwrt/openwrt/issues/16168
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 17 lines
- drop A-b tag
Changes in v3:
- collect A-b tag
Changes in v2:
- fix typo in commit message
- add missing --- in commit message
- add new section instead of new item inrockchip.yaml--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0@@ -790,6 +790,11 @@ properties: - const: radxa,rockpi-e
Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 800
Quoted 10 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +5
-0- const: rockchip,rk3328 + - description: Radxa ROCK Pi E v3.0 + items: + - const: radxa,rock-pi-e-v3 + - const: rockchip,rk3328 + - description: Radxa ROCK Pi N8 items: - const: radxa,rockpi-n8
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Heiko Stübner
maintainerAm Mittwoch, 14. August 2024, 12:25:54 CEST schrieb FUKAUMI Naoki:
Quoted 6 lines
Hi,
Quoted 3 lines · FUKAUMI Naoki
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip.
Quoted 8 lines
Quoted 6 lines
[1] https://radxa.com/products/rockpi/pie
Signed-off-by FUKAUMI Naoki <[email protected]>---
Changes in v4:
- update compatible string for OpenWrtthis is for https://github.com/openwrt/openwrt/issues/16168
I this because openwrt used some out-of-tree devicetree?
For people reading along, all the other rockpi devices follow a
radxa,rockpi-foo
naming scheme in their compatibles while _this_ new entry uses
radxa,rock-pi-e-v3
Heiko
Hi,
Quoted 9 lines · Heiko Stübner
Am Mittwoch, 14. August 2024, 12:25:54 CEST schrieb FUKAUMI Naoki:
Quoted 8 lines
Hi,
Quoted 5 lines · FUKAUMI Naoki
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by FUKAUMI Naoki <[email protected]>---
Changes in v4:
- update compatible string for OpenWrtthis is for https://github.com/openwrt/openwrt/issues/16168
I this because openwrt used some out-of-tree devicetree?
no, basically they use upstream dts.
(in this case, dts is backported because they use v6.6 kernel.)
generally their Makefile and script variables refer dts filename. (dts filename is referred as right name)
Quoted 3 lines
For people reading along, all the other rockpi devices follow a
radxa,rockpi-foo
there are roockpi4x and rockpis ;)
Quoted 3 lines
naming scheme in their compatibles while _this_ new entry uses
radxa,rock-pi-e-v3
this is new target, so I thought new form can be used.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Heiko Stübner
maintainerAm Mittwoch, 14. August 2024, 11:57:26 CEST schrieb FUKAUMI Naoki:
Quoted 25 lines
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip.
[1] https://radxa.com/products/rockpi/pie
Signed-off-by FUKAUMI Naoki <[email protected]>---
Changes in v4:
- update compatible string for OpenWrt
- drop A-b tag
Changes in v3:
- collect A-b tag
Changes in v2:
- fix typo in commit message
- add missing --- in commit message
- add new section instead of new item inrockchip.yaml--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0
Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 797
Quoted 8 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +5
-0@@ -790,6 +790,11 @@ properties: - const: radxa,rockpi-e - const: rockchip,rk3328 + - description: Radxa ROCK Pi E v3.0 + items: + - const: radxa,rock-pi-e-v3 + - const: rockchip,rk3328 +
Please don't add a separate entry for the simple updated version. Instead group it with the original Rock Pi e above.
For how to do it, look at the Radxa Zero 3w/3e .
Hi,
thanks for the review!
Quoted 38 lines · Heiko Stübner
Am Mittwoch, 14. August 2024, 11:57:26 CEST schrieb FUKAUMI Naoki:
Quoted 25 lines
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip.
[1] https://radxa.com/products/rockpi/pie
Signed-off-by FUKAUMI Naoki <[email protected]>---
Changes in v4:
- update compatible string for OpenWrt
- drop A-b tag
Changes in v3:
- collect A-b tag
Changes in v2:
- fix typo in commit message
- add missing --- in commit message
- add new section instead of new item inrockchip.yaml--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 797
Quoted 8 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +5
-0@@ -790,6 +790,11 @@ properties: - const: radxa,rockpi-e - const: rockchip,rk3328 + - description: Radxa ROCK Pi E v3.0 + items: + - const: radxa,rock-pi-e-v3 + - const: rockchip,rk3328 +Please don't add a separate entry for the simple updated version. Instead group it with the original Rock Pi e above.
Quoted 1 line
For how to do it, look at the Radxa Zero 3w/3e .
https://patchwork.kernel.org/project/linux-rockchip/patch/[email protected]/
is this right way?
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Heiko Stübner
maintainerAm Mittwoch, 14. August 2024, 22:04:51 CEST schrieb FUKAUMI Naoki:
Quoted 43 lines
Hi,
thanks for the review!
Quoted 38 lines · Heiko Stübner
Am Mittwoch, 14. August 2024, 11:57:26 CEST schrieb FUKAUMI Naoki:
Quoted 25 lines
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip.
[1] https://radxa.com/products/rockpi/pie
Signed-off-by FUKAUMI Naoki <[email protected]>---
Changes in v4:
- update compatible string for OpenWrt
- drop A-b tag
Changes in v3:
- collect A-b tag
Changes in v2:
- fix typo in commit message
- add missing --- in commit message
- add new section instead of new item inrockchip.yaml--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 797
Quoted 8 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +5
-0@@ -790,6 +790,11 @@ properties: - const: radxa,rockpi-e - const: rockchip,rk3328 + - description: Radxa ROCK Pi E v3.0 + items: + - const: radxa,rock-pi-e-v3 + - const: rockchip,rk3328 +Please don't add a separate entry for the simple updated version. Instead group it with the original Rock Pi e above.
Quoted 5 lines
Quoted 1 line
For how to do it, look at the Radxa Zero 3w/3e .
https://patchwork.kernel.org/project/linux-rockchip/patch/[email protected]/
is this right way?
Nope. You need an enum. That's the reason I pointed to the Radxa Zero as an example [0]
So your entry should look something like:
- description: Radxa ROCK Pi E
items:
- enum:
- radxa,rockpi-e
- radxa,rockpi-e-v3
- const: rockchip,rk3328
that way the binding matches against both:
compatible = "radxa,rockpi-e", "rockchip,rk3328" as well as compatible = "radxa,rockpi-e-v3", "rockchip,rk3328"
Hope that helps a bit
Heiko
hi,
Quoted 53 lines · Heiko Stübner
Am Mittwoch, 14. August 2024, 22:04:51 CEST schrieb FUKAUMI Naoki:
Quoted 43 lines
Hi,
thanks for the review!
Quoted 38 lines · Heiko Stübner
Am Mittwoch, 14. August 2024, 11:57:26 CEST schrieb FUKAUMI Naoki:
Quoted 25 lines
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip.
[1] https://radxa.com/products/rockpi/pie
Signed-off-by FUKAUMI Naoki <[email protected]>---
Changes in v4:
- update compatible string for OpenWrt
- drop A-b tag
Changes in v3:
- collect A-b tag
Changes in v2:
- fix typo in commit message
- add missing --- in commit message
- add new section instead of new item inrockchip.yaml--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 797
Quoted 8 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +5
-0@@ -790,6 +790,11 @@ properties: - const: radxa,rockpi-e - const: rockchip,rk3328 + - description: Radxa ROCK Pi E v3.0 + items: + - const: radxa,rock-pi-e-v3 + - const: rockchip,rk3328 +Please don't add a separate entry for the simple updated version. Instead group it with the original Rock Pi e above.
Quoted 5 lines
Quoted 1 line
For how to do it, look at the Radxa Zero 3w/3e .
https://patchwork.kernel.org/project/linux-rockchip/patch/[email protected]/
is this right way?
Nope. You need an enum. That's the reason I pointed to the Radxa Zero as an example [0]
Quoted 8 lines
So your entry should look something like:
- description: Radxa ROCK Pi E
items:
- enum:
- radxa,rockpi-e
- radxa,rockpi-e-v3
- const: rockchip,rk3328
I see. I'll do it in v5.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 6 lines
that way the binding matches against both:
compatible = "radxa,rockpi-e", "rockchip,rk3328" as well as compatible = "radxa,rockpi-e-v3", "rockchip,rk3328"
Quoted 8 lines
Hope that helps a bit
Heiko
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Rob Herring (Arm)
maintainerQuoted 16 lines · FUKAUMI Naoki
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip.
[1] https://radxa.com/products/rockpi/pie
Signed-off-by FUKAUMI Naoki <[email protected]>---
Changes in v4:
- update compatible string for OpenWrt
- drop A-b tag
Changes in v3:
- collect A-b tag
Changes in v2:
- fix typo in commit message
- add missing --- in commit message
- add new section instead of new item inrockchip.yaml
Quoted 4 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y rockchip/rk3328-rock-pi-e-v3.dtb rockchip/rk3328-rock-pi-e.dtb' for [email protected]:
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dtb: hdmi@ff3c0000: interrupts: [[0, 35, 4], [0, 71, 4]] is too long
from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml#arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dtb: /phy@ff430000: failed to match any schema with compatible: ['rockchip,rk3328-hdmi-phy'] arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dtb: /clock-controller@ff440000: failed to match any schema with compatible: ['rockchip,rk3328-cru', 'rockchip,cru', 'syscon'] arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dtb: /clock-controller@ff440000: failed to match any schema with compatible: ['rockchip,rk3328-cru', 'rockchip,cru', 'syscon']