Skip to contentSkip to conversation

bcachefs: Remove unused parameter

PATCH New Alan Huang 1 participant 1 message Aug 14, 2024

lore
Share & tools
lore

Alan Huang

author
#0 lore raw

PATCH 1/1 bcachefs: Remove unused parameter

iter here is unused, remove it.

---
 fs/bcachefs/bset.c               | 1 -
 fs/bcachefs/bset.h               | 4 ++--
 fs/bcachefs/btree_trans_commit.c | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)
fs/bcachefs/bset.c +0 -1
index 0ccc1d962428..1b66b2c7e018 100644
@@ -969,7 +969,6 @@ static void bch2_bset_fix_lookup_table(struct btree *b,
 }
 
 void bch2_bset_insert(struct btree *b,
-		      struct btree_node_iter *iter,
 		      struct bkey_packed *where,
 		      struct bkey_i *insert,
 		      unsigned clobber_u64s)
fs/bcachefs/bset.h +2 -2
index 5c6c7a14fa0f..6953d55b72cc 100644
@@ -270,8 +270,8 @@ void bch2_bset_init_first(struct btree *, struct bset *);
 void bch2_bset_init_next(struct btree *, struct btree_node_entry *);
 void bch2_bset_build_aux_tree(struct btree *, struct bset_tree *, bool);
 
-void bch2_bset_insert(struct btree *, struct btree_node_iter *,
-		     struct bkey_packed *, struct bkey_i *, unsigned);
+void bch2_bset_insert(struct btree *, struct bkey_packed *, struct bkey_i *,
+		      unsigned);
 void bch2_bset_delete(struct btree *, struct bkey_packed *, unsigned);
 
 /* Bkey utility code */
fs/bcachefs/btree_trans_commit.c +1 -1
index ac0c92683aad..8b0b9e5ce72e 100644
@@ -214,7 +214,7 @@ bool bch2_btree_bset_insert_key(struct btree_trans *trans,
 
 	k = bch2_btree_node_iter_bset_pos(node_iter, b, bset_tree_last(b));
 overwrite:
-	bch2_bset_insert(b, node_iter, k, insert, clobber_u64s);
+	bch2_bset_insert(b, k, insert, clobber_u64s);
 	new_u64s = k->u64s;
 fix_iter:
 	if (clobber_u64s != new_u64s)
Signature · 1 line
2.45.2