Skip to contentSkip to conversation

staging: rtl8723bs: drop unnessary dep on CFG80211_WEXT

PATCH In review Peter Robinson 2 participants 2 messages Aug 14, 2024 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: drop unnessary dep on CFG80211_WEXT

In commit 174ac41a7aaf ("staging: rtl8723bs: remove obsolete wext support") a dep on CFG80211_WEXT was added to allow wext userspace calls to be managed via the compatibility support. This is an optional dependency which the driver has no dependency on and stops users/distros etc from dropping CFG80211_WEXT if they want to enable this driver. Drop this dependency as if users want this legacy feature they will be explicitly enabling it themselves.

---
 drivers/staging/rtl8723bs/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/Kconfig +0 -1
index f23e29b679fb..8d48c61961a6 100644
@@ -3,7 +3,6 @@ config RTL8723BS
 	tristate "Realtek RTL8723BS SDIO Wireless LAN NIC driver"
 	depends on WLAN && MMC && CFG80211
 	depends on m
-	select CFG80211_WEXT
 	select CRYPTO
 	select CRYPTO_LIB_ARC4
 	help
Signature · 1 line
2.46.0
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 9 lines · Peter Robinson

In commit 174ac41a7aaf ("staging: rtl8723bs: remove obsolete wext support") a dep on CFG80211_WEXT was added to allow wext userspace calls to be managed via the compatibility support. This is an optional dependency which the driver has no dependency on and stops users/distros etc from dropping CFG80211_WEXT if they want to enable this driver. Drop this dependency as if users want this legacy feature they will be explicitly enabling it themselves.

Thanks, patch looks good to me:

Regards,

Hans

Quoted 16 lines
---
 drivers/staging/rtl8723bs/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/Kconfig +0 -1
index f23e29b679fb..8d48c61961a6 100644
@@ -3,7 +3,6 @@ config RTL8723BS
 	tristate "Realtek RTL8723BS SDIO Wireless LAN NIC driver"
 	depends on WLAN && MMC && CFG80211
 	depends on m
-	select CFG80211_WEXT
 	select CRYPTO
 	select CRYPTO_LIB_ARC4
 	help