package/ncurses: fix uClibc-ng compile error
PATCH 1/1 package/ncurses: fix uClibc-ng compile error
Unfortunately upstream does not use any SCM.
See here for the Changelog:
https://invisible-island.net/ncurses/NEWS.html#index-t20231014
"+ updated configure script macro CF_XOPEN_SOURCE, for uClibc-ng"
Fixes:
- http://autobuild.buildroot.net/results/01c/01cbc188c70f53fe492128100b430857f1cd98f2
- http://autobuild.buildroot.net/results/e2b/e2ba6a5554bfa0bf9b4c2eaf9222d041204f00e9
And many more.
--- .../0001-fix-XOPEN_SOURCE-detection.patch | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 package/ncurses/0001-fix-XOPEN_SOURCE-detection.patch
package/ncurses/0001-fix-XOPEN_SOURCE-detection.patch new file +16 -0
@@ -0,0 +1,16 @@ +Fix detection of XOPEN_SOURCE + +Signed-off-by: Waldemar Brodkorb <[email protected]> +Upstream: fixed in latest release, no git/svn/hg +diff -Nur ncurses-snapshots-6_4_20230603.orig/configure ncurses-snapshots-6_4_20230603/configure +--- ncurses-snapshots-6_4_20230603.orig/configure 2023-06-04 00:07:40.000000000 +0200 ++++ ncurses-snapshots-6_4_20230603/configure 2024-08-14 20:38:03.426905460 +0200 +@@ -10411,7 +10411,7 @@ + cf_xopen_source="-D_SGI_SOURCE" + cf_XOPEN_SOURCE= + ;; +-(linux*gnu|linux*gnuabi64|linux*gnuabin32|linux*gnueabi|linux*gnueabihf|linux*gnux32|uclinux*|gnu*|mint*|k*bsd*-gnu|cygwin|msys|mingw*) ++(linux*gnu|linux*gnuabi64|linux*gnuabin32|linux*gnueabi|linux*gnueabihf|linux*gnux32|uclinux*|gnu*|mint*|k*bsd*-gnu|cygwin|msys|mingw*|linux*uclibc) + + cf_gnu_xopen_source=$cf_XOPEN_SOURCE +
Signature · 6 lines
2.30.2 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Waldemar!
Quoted 1 line · On Wed, 14 Aug 2024 20:51:41 +0200 Waldemar Brodkorb <[email protected]> wrote:
Unfortunately upstream does not use any SCM.
Yeah, kind of crazy.
Quoted 10 lines
See here for the Changelog:
https://invisible-island.net/ncurses/NEWS.html#index-t20231014"+ updated configure script macro
CF_XOPEN_SOURCE, for uClibc-ng"Fixes:
- http://autobuild.buildroot.net/results/01c/01cbc188c70f53fe492128100b430857f1cd98f2
- http://autobuild.buildroot.net/results/e2b/e2ba6a5554bfa0bf9b4c2eaf9222d041204f00e9And many more.
So I've applied to master, but to me this is not the "perfect" patch. The perfect patch would have researched when this issue was introduced, so that we know if it needs to be backported to a LTS branch. Could you try to think about this for next fixes?
Another suggestion: I see that ncurses 6.5 has been released, perhaps time to update? (But of course that will be for our 'next' branch).
Thanks!
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot