Skip to contentSkip to conversation

selftests/ftrace: Add required dependency for kprobe tests

PATCH In review Masami Hiramatsu (Google) 2 participants 4 messages Jun 12, 2024 – Aug 14, 2024

Subsystems (2)
lore
Share & tools
lore

Masami Hiramatsu (Google)

author maintainer
#0 lore raw

PATCH 1/1 selftests/ftrace: Add required dependency for kprobe tests

From: Masami Hiramatsu (Google) <[email protected]>

kprobe_args_{char,string}.tc are using available_filter_functions file which is provided by function tracer. Thus if function tracer is disabled, these tests are failed on recent kernels because tracefs_create_dir is not raised events by adding a dynamic event.
Add available_filter_functions to requires line.

Fixes 7c1130ea5cae ("test: ftrace: Fix kprobe test for eventfs")
---
 .../ftrace/test.d/kprobe/kprobe_args_char.tc       |    2 +-
 .../ftrace/test.d/kprobe/kprobe_args_string.tc     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_char.tc +1 -1
index e21c9c27ece4..77f4c07cdcb8 100644
@@ -1,7 +1,7 @@
 #!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 # description: Kprobe event char type argument
-# requires: kprobe_events
+# requires: kprobe_events available_filter_functions
 
 case `uname -m` in
 x86_64)
tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc +1 -1
index 93217d459556..39001073f7ed 100644
@@ -1,7 +1,7 @@
 #!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 # description: Kprobe event string type argument
-# requires: kprobe_events
+# requires: kprobe_events available_filter_functions
 
 case `uname -m` in
 x86_64)
author maintainer
#1 lore raw

Hi Shuah,

Can you pick this? I confirmed this can be applied on v6.11-rc3.

Quoted 43 lines · On Thu, 13 Jun 2024 07:12:10 +0900 "Masami Hiramatsu (Google)"…

From: Masami Hiramatsu (Google) <[email protected]>

kprobe_args_{char,string}.tc are using available_filter_functions file which is provided by function tracer. Thus if function tracer is disabled, these tests are failed on recent kernels because tracefs_create_dir is not raised events by adding a dynamic event.
Add available_filter_functions to requires line.

Fixes 7c1130ea5cae ("test: ftrace: Fix kprobe test for eventfs")
---
 .../ftrace/test.d/kprobe/kprobe_args_char.tc       |    2 +-
 .../ftrace/test.d/kprobe/kprobe_args_string.tc     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_char.tc +1 -1
index e21c9c27ece4..77f4c07cdcb8 100644
@@ -1,7 +1,7 @@
 #!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 # description: Kprobe event char type argument
-# requires: kprobe_events
+# requires: kprobe_events available_filter_functions
 
 case `uname -m` in
 x86_64)
tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc +1 -1
index 93217d459556..39001073f7ed 100644
@@ -1,7 +1,7 @@
 #!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 # description: Kprobe event string type argument
-# requires: kprobe_events
+# requires: kprobe_events available_filter_functions
 
 case `uname -m` in
 x86_64)
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>
maintainer
#2 lore raw
Quoted 19 lines · Masami Hiramatsu (Google)

Hi Shuah,

Can you pick this? I confirmed this can be applied on v6.11-rc3.

Quoted 10 lines · On Thu, 13 Jun 2024 07:12:10 +0900 "Masami Hiramatsu (Google)"…

From: Masami Hiramatsu (Google) <[email protected]>

kprobe_args_{char,string}.tc are using available_filter_functions file which is provided by function tracer. Thus if function tracer is disabled, these tests are failed on recent kernels because tracefs_create_dir is not raised events by adding a dynamic event.
Add available_filter_functions to requires line.

Fixes 7c1130ea5cae ("test: ftrace: Fix kprobe test for eventfs")

Applied to linux-kselftest next for Linux 6.12-rc1

thanks,
-- Shuah

author maintainer
#3 lore raw
Quoted 18 lines · On Wed, 14 Aug 2024 05:43:29 -0600 Shuah Khan <[email protected]> wrote:
Quoted 17 lines · Masami Hiramatsu (Google)

Hi Shuah,

Can you pick this? I confirmed this can be applied on v6.11-rc3.

Quoted 8 lines · On Thu, 13 Jun 2024 07:12:10 +0900 "Masami Hiramatsu (Google)"…

From: Masami Hiramatsu (Google) <[email protected]>

kprobe_args_{char,string}.tc are using available_filter_functions file which is provided by function tracer. Thus if function tracer is disabled, these tests are failed on recent kernels because tracefs_create_dir is not raised events by adding a dynamic event.
Add available_filter_functions to requires line.

Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Fixes 7c1130ea5cae ("test: ftrace: Fix kprobe test for eventfs")

Applied to linux-kselftest next for Linux 6.12-rc1

Thanks!

Quoted 3 lines

thanks,
-- Shuah

Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>