Skip to contentSkip to conversation

gw_ventana: Remove unneeded comments

PATCH In review Fabio Estevam 2 participants 3 messages Aug 16, 2024 – Aug 26, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gw_ventana: Remove unneeded comments

From: Fabio Estevam <[email protected]>

Remove several comments that do not apply anymore to the current file content.

While at it, write 'PMIC' into a single line for consistency.

---
 include/configs/gw_ventana.h | 31 +------------------------------
 1 file changed, 1 insertion(+), 30 deletions(-)
include/configs/gw_ventana.h +1 -30
index ebc5d03d0d5..3e720a6e0af 100644
@@ -6,55 +6,26 @@
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-/* SPL */
-/* Location in NAND to read U-Boot from */
-
-/* Falcon Mode */
-
-/* Falcon Mode - MMC support: args@1MB kernel@2MB */
-
 #include "mx6_common.h"
 
 /* Serial */
 #define CFG_MXC_UART_BASE	       UART2_BASE
 
-/* NAND */
-
 /* MMC Configs */
 #define CFG_SYS_FSL_ESDHC_ADDR      0
 
-/*
- * PCI express
- */
-
-/*
- * PMIC
- */
+/* PMIC */
 #define CFG_POWER_PFUZE100_I2C_ADDR	0x08
 #define CFG_POWER_LTC3676_I2C_ADDR  0x3c
 
-/* Various command support */
-
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC     (PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CFG_MXC_USB_FLAGS      0
 
-/* Miscellaneous configurable options */
-
-/* Memory configuration */
-
 /* Physical Memory Map */
 #define PHYS_SDRAM                     MMDC0_ARB_BASE_ADDR
 #define CFG_SYS_SDRAM_BASE          PHYS_SDRAM
 #define CFG_SYS_INIT_RAM_ADDR       IRAM_BASE_ADDR
 #define CFG_SYS_INIT_RAM_SIZE       IRAM_SIZE
 
-/*
- * MTD Command for mtdparts
- */
-
-/* Persistent Environment Config */
-
-/* Environment */
-
 #endif			       /* __CONFIG_H */
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 75 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Remove several comments that do not apply anymore to the current file content.

While at it, write 'PMIC' into a single line for consistency.

---
 include/configs/gw_ventana.h | 31 +------------------------------
 1 file changed, 1 insertion(+), 30 deletions(-)
include/configs/gw_ventana.h +1 -31
index ebc5d03d0d5..3e720a6e0af 100644
@@ -6,55 +6,26 @@
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-/* SPL */
-/* Location in NAND to read U-Boot from */
-
-/* Falcon Mode */
-
-/* Falcon Mode - MMC support: args@1MB kernel@2MB */
-
 #include "mx6_common.h"
 
 /* Serial */
 #define CFG_MXC_UART_BASE             UART2_BASE
 
-/* NAND */
-
 /* MMC Configs */
 #define CFG_SYS_FSL_ESDHC_ADDR      0
 
-/*
- * PCI express
- */
-
-/*
- * PMIC
- */
+/* PMIC */
 #define CFG_POWER_PFUZE100_I2C_ADDR    0x08
 #define CFG_POWER_LTC3676_I2C_ADDR  0x3c
 
-/* Various command support */
-
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC     (PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CFG_MXC_USB_FLAGS      0
 
-/* Miscellaneous configurable options */
-
-/* Memory configuration */
-
 /* Physical Memory Map */
 #define PHYS_SDRAM                     MMDC0_ARB_BASE_ADDR
 #define CFG_SYS_SDRAM_BASE          PHYS_SDRAM
 #define CFG_SYS_INIT_RAM_ADDR       IRAM_BASE_ADDR
 #define CFG_SYS_INIT_RAM_SIZE       IRAM_SIZE
 
-/*
- * MTD Command for mtdparts
- */
-
-/* Persistent Environment Config */
-
-/* Environment */
-
 #endif                        /* __CONFIG_H */
--
Quoted 2 lines

2.34.1

Hi Fabio,

Looks like there isn't much left to be moved to Kconfig. I'm not sure if your interested or have the time (I know I currently don't) but the USB defines can be cleaned up pretty easily:
- '#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)' can
be removed from mx6/mx7/mx8m includes as its defaulted in drivers/usb/host/ehci-mx6.c
- CFG_MXC_USB_FLAGS is only used for drivers/usb/host/ehci-mx5.c so can be removed for all mx6/mx7/mx8m and the mx51evk.h is the only place its not set to 0

best regards,

Tim

#2 lore raw

Hi Tim,

Quoted 9 lines · Tim Harvey

Looks like there isn't much left to be moved to Kconfig. I'm not sure if your interested or have the time (I know I currently don't) but the USB defines can be cleaned up pretty easily:
- '#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)' can
be removed from mx6/mx7/mx8m includes as its defaulted in drivers/usb/host/ehci-mx6.c
- CFG_MXC_USB_FLAGS is only used for drivers/usb/host/ehci-mx5.c so can be removed for all mx6/mx7/mx8m and the mx51evk.h is the only place its not set to 0

Good point. I will work on cleaning these two CFG symbols.

Thanks