staging: media: starfive: Add the dynamic resolution support
Subsystems (2)
PATCH v2 1/1 staging: media: starfive: Add the dynamic resolution support
Add the dynamic resolution support for video "capture_raw" device.
--- drivers/staging/media/starfive/camss/stf-capture.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/media/starfive/camss/stf-capture.c +3 -1
@@ -180,6 +180,8 @@ static void stf_channel_set(struct stfcamss_video *video)u32 val;if (cap->type ==STF_CAPTURE_RAW ) { +const struct v4l2_pix_format *pix = &video->active_fmt.fmt.pix; + val =stf_syscon_reg_read (stfcamss,VIN_CHANNEL_SEL_EN ); val &= ~U0_VIN_CHANNEL_SEL_MASK ; val |=CHANNEL (0 );
@@ -193,7 +195,7 @@ static void stf_channel_set(struct stfcamss_video *video) val |=PIXEL_HEIGH_BIT_SEL (0 ); val &= ~U0_VIN_PIX_CNT_END_MASK ; - val |=PIX_CNT_END (IMAGE_MAX_WIDTH /4 -1 ); + val |=PIX_CNT_END (pix->width /4 -1 );stf_syscon_reg_write (stfcamss,VIN_INRT_PIX_CFG , val); }else if (cap->type ==STF_CAPTURE_YUV ) {
Signature · 1 line
2.25.1
Quoted 2 lines · Changhuang Liang
Add the dynamic resolution support for video "
capture_raw" device.
What does this change look like from a use perspective if a user is reading the git log?
Quoted 2 lines
Fixes e080f339c80a ("media: staging: media: starfive: camss: Add capture driver")
This looks like a new feature and not a bugfix. Please describe the bug more clearly if it's really a bugfix.
regards,
dan carpenter
Quoted 4 lines · Dan Carpenter
Quoted 2 lines · Changhuang Liang
Add the dynamic resolution support for video "
capture_raw" device.
Quoted 9 lines
What does this change look like from a use perspective if a user is reading the git log?
Quoted 2 lines
Fixes e080f339c80a ("media: staging: media: starfive: camss: Add capture driver")This looks like a new feature and not a bugfix. Please describe the bug more clearly if it's really a bugfix.
Actually the first version of the commit had a good description. Just go back to that.
Quoted 2 lines
Add multiple resolution support for video "
capture_raw" device. Otherwise it will capture the wrong image data if the width is not 1920.
Btw:
1) Don't put a blank line after the Fixes tag.
2) Put a note under the --- cut off line that says what changed.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Please send v3.
regards,
dan carpenter
Hi, Dan
Thanks for your comments.
Quoted 11 lines · Dan Carpenter
Quoted 10 lines · Changhuang Liang
Quoted 2 lines
Add the dynamic resolution support for video "
capture_raw" device.What does this change look like from a use perspective if a user is reading the git log?
Quoted 2 lines
Fixes e080f339c80a ("media: staging: media: starfive: camss: Add capture driver")
Quoted 7 lines
Quoted 3 lines
This looks like a new feature and not a bugfix. Please describe the bug more clearly if it's really a bugfix.
Actually the first version of the commit had a good description. Just go back to that.
Yes, I forgot to synchronous description.
Quoted 9 lines
Quoted 2 lines
Add multiple resolution support for video "
capture_raw" device. Otherwise it will capture the wrong image data if the width is not 1920.Btw:
1) Don't put a blank line after the Fixes tag.
2) Put a note under the --- cut off line that says what changed.https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Thanks for this.
Quoted 1 line
Please send v3.
regards,
Changhuang