Skip to contentSkip to conversation

Adding Support for Thinkpad X12 Gen 2 Kbd Portfolio with 0x61AE as PID

PATCH In review Vishnu Sankar 2 participants 4 messages Aug 18, 2024 – Sep 12, 2024 1 message not in the archive HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Adding Support for Thinkpad X12 Gen 2 Kbd Portfolio with 0x61AE as PID

This applies similar quirks used by previous generation device, so that Trackpoint and buttons on the touchpad works.
New USB KBD PID 0x61AE for Thinkpad X12 Tab is added.

---
 drivers/hid/hid-ids.h        | 1 +
 drivers/hid/hid-multitouch.c | 6 ++++++
 2 files changed, 7 insertions(+)
drivers/hid/hid-ids.h +1 -0
index 72d56ee7c..981813f50 100644
@@ -807,6 +807,7 @@
 #define USB_DEVICE_ID_LENOVO_X1_TAB	0x60a3
 #define USB_DEVICE_ID_LENOVO_X1_TAB3	0x60b5
 #define USB_DEVICE_ID_LENOVO_X12_TAB	0x60fe
+#define USB_DEVICE_ID_LENOVO_X12_TAB2	0x61ae
 #define USB_DEVICE_ID_LENOVO_OPTICAL_USB_MOUSE_600E	0x600e
 #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D	0x608d
 #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_6019	0x6019
drivers/hid/hid-multitouch.c +6 -0
index 56fc78841..1b0844ffa 100644
@@ -2081,6 +2081,12 @@ static const struct hid_device_id mt_devices[] = {
 			   USB_VENDOR_ID_LENOVO,
 			   USB_DEVICE_ID_LENOVO_X12_TAB) },
 
+	/* Lenovo X12 TAB Gen 2 */
+	{ .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU,
+		HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
+			   USB_VENDOR_ID_LENOVO,
+			   USB_DEVICE_ID_LENOVO_X12_TAB2) },
+
 	/* Logitech devices */
 	{ .driver_data = MT_CLS_NSMU,
 		HID_DEVICE(BUS_BLUETOOTH, HID_GROUP_MULTITOUCH_WIN_8,
Signature · 1 line
2.43.0
#1 lore raw

All,

Do we have any comments or feedback on this patch?

Quoted 44 lines · Vishnu Sankar

This applies similar quirks used by previous generation device, so that Trackpoint and buttons on the touchpad works.
New USB KBD PID 0x61AE for Thinkpad X12 Tab is added.

---
 drivers/hid/hid-ids.h        | 1 +
 drivers/hid/hid-multitouch.c | 6 ++++++
 2 files changed, 7 insertions(+)
drivers/hid/hid-ids.h +1 -0
index 72d56ee7c..981813f50 100644
@@ -807,6 +807,7 @@
 #define USB_DEVICE_ID_LENOVO_X1_TAB    0x60a3
 #define USB_DEVICE_ID_LENOVO_X1_TAB3   0x60b5
 #define USB_DEVICE_ID_LENOVO_X12_TAB   0x60fe
+#define USB_DEVICE_ID_LENOVO_X12_TAB2  0x61ae
 #define USB_DEVICE_ID_LENOVO_OPTICAL_USB_MOUSE_600E    0x600e
 #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D     0x608d
 #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_6019     0x6019
drivers/hid/hid-multitouch.c +6 -1
index 56fc78841..1b0844ffa 100644
@@ -2081,6 +2081,12 @@ static const struct hid_device_id mt_devices[] = {
                           USB_VENDOR_ID_LENOVO,
                           USB_DEVICE_ID_LENOVO_X12_TAB) },
 
+       /* Lenovo X12 TAB Gen 2 */
+       { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU,
+               HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
+                          USB_VENDOR_ID_LENOVO,
+                          USB_DEVICE_ID_LENOVO_X12_TAB2) },
+
        /* Logitech devices */
        { .driver_data = MT_CLS_NSMU,
                HID_DEVICE(BUS_BLUETOOTH, HID_GROUP_MULTITOUCH_WIN_8,
--

2.43.0

Signature · 4 lines
Regards,

      Vishnu Sankar
     +817015150407 (Japan)

A message that is not in the archive (sent off-list or not yet received): CABxCQKtfFttYVpfZE0jsjt=xgO4EJ0vNeb4Wf-==xOr3XnKnxQ@mail.gmail.com

maintainer
#3 lore raw
Quoted 1 line · Vishnu Sankar

Do we have any feedback or comments about this patch?

Sorry, this slipped in between cracks.

Now applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs
#4 lore raw

Thank you for the acceptance.

Quoted 13 lines · Jiri Kosina
Quoted 1 line · Vishnu Sankar

Do we have any feedback or comments about this patch?

Sorry, this slipped in between cracks.

Now applied, thanks.

--
Jiri Kosina
SUSE Labs

Signature · 4 lines
Regards,

      Vishnu Sankar
     +817015150407 (Japan)