Skip to contentSkip to conversation

clocksource/timer-of: Add missing casts to percpu address space

PATCH In review Uros Bizjak 2 participants 3 messages Aug 19, 2024 Clocksource, clockevent drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clocksource/timer-of: Add missing casts to percpu address space

Add missing casts to percpu address space to fix

timer-of.c:29:46: warning: incorrect type in argument 2 (different address spaces)
timer-of.c:29:46: expected void [noderef] __percpu *
timer-of.c:29:46: got struct clock_event_device *clkevt
timer-of.c:74:51: warning: incorrect type in argument 4 (different address spaces)
timer-of.c:74:51: expected void [noderef] __percpu *percpu_dev_id
timer-of.c:74:51: got struct clock_event_device *clkevt

sparse warnings.

Found by GCC's named address space checks.

There were no changes in the resulting object file.

Cc Daniel Lezcano <[email protected]>
Cc Thomas Gleixner <[email protected]>
---
 drivers/clocksource/timer-of.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/clocksource/timer-of.c +4 -3
index c3f54d9912be..7e0375a804ff 100644
@@ -26,7 +26,8 @@ static __init void timer_of_irq_exit(struct of_timer_irq *of_irq)
 	struct clock_event_device *clkevt = &to->clkevt;
 
 	if (of_irq->percpu)
-		free_percpu_irq(of_irq->irq, clkevt);
+		free_percpu_irq(of_irq->irq,
+				(void __percpu *)(unsigned long)clkevt);
 	else
 		free_irq(of_irq->irq, clkevt);
 }
@@ -70,8 +71,8 @@ static __init int timer_of_irq_init(struct device_node *np,
 	}
 
 	ret = of_irq->percpu ?
-		request_percpu_irq(of_irq->irq, of_irq->handler,
-				   np->full_name, clkevt) :
+		request_percpu_irq(of_irq->irq, of_irq->handler, np->full_name,
+				   (void __percpu *)(unsigned long)clkevt) :
 		request_irq(of_irq->irq, of_irq->handler,
 			    of_irq->flags ? of_irq->flags : IRQF_TIMER,
 			    np->full_name, clkevt);
Signature · 1 line
2.46.0
#1 lore raw
Quoted 9 lines · Uros Bizjak

Add missing casts to percpu address space to fix

timer-of.c:29:46: warning: incorrect type in argument 2 (different address spaces)
timer-of.c:29:46: expected void [noderef] __percpu *
timer-of.c:29:46: got struct clock_event_device *clkevt
timer-of.c:74:51: warning: incorrect type in argument 4 (different address spaces)
timer-of.c:74:51: expected void [noderef] __percpu *percpu_dev_id
timer-of.c:74:51: got struct clock_event_device *clkevt

Quoted 5 lines

sparse warnings.

Found by GCC's named address space checks.

There were no changes in the resulting object file.

The warning may go away but the problem sparse is spotting is still there.

IMO sparse is totally right and the code related to the percpu is broken. It seems the .percpu flag is never used in the drivers and we should be able to just remove the percpu related code in timer-of.c

Quoted 32 lines
Cc Daniel Lezcano <[email protected]>
Cc Thomas Gleixner <[email protected]>
---
  drivers/clocksource/timer-of.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
drivers/clocksource/timer-of.c +4 -3
index c3f54d9912be..7e0375a804ff 100644
@@ -26,7 +26,8 @@ static __init void timer_of_irq_exit(struct of_timer_irq *of_irq)
  	struct clock_event_device *clkevt = &to->clkevt;
 
  	if (of_irq->percpu)
-		free_percpu_irq(of_irq->irq, clkevt);
+		free_percpu_irq(of_irq->irq,
+				(void __percpu *)(unsigned long)clkevt);
  	else
  		free_irq(of_irq->irq, clkevt);
  }
@@ -70,8 +71,8 @@ static __init int timer_of_irq_init(struct device_node *np,
  	}
 
  	ret = of_irq->percpu ?
-		request_percpu_irq(of_irq->irq, of_irq->handler,
-				   np->full_name, clkevt) :
+		request_percpu_irq(of_irq->irq, of_irq->handler, np->full_name,
+				   (void __percpu *)(unsigned long)clkevt) :
  		request_irq(of_irq->irq, of_irq->handler,
  			    of_irq->flags ? of_irq->flags : IRQF_TIMER,
  			    np->full_name, clkevt);
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#2 lore raw
Quoted 15 lines · Daniel Lezcano
Quoted 13 lines · Uros Bizjak

Add missing casts to percpu address space to fix

timer-of.c:29:46: warning: incorrect type in argument 2 (different address spaces)
timer-of.c:29:46: expected void [noderef] __percpu *
timer-of.c:29:46: got struct clock_event_device *clkevt
timer-of.c:74:51: warning: incorrect type in argument 4 (different address spaces)
timer-of.c:74:51: expected void [noderef] __percpu *percpu_dev_id
timer-of.c:74:51: got struct clock_event_device *clkevt

sparse warnings.

Found by GCC's named address space checks.

Quoted 7 lines
Quoted 1 line

There were no changes in the resulting object file.

The warning may go away but the problem sparse is spotting is still there.

IMO sparse is totally right and the code related to the percpu is broken. It seems the .percpu flag is never used in the drivers and we should be able to just remove the percpu related code in timer-of.c

This issue also breaks allyesconfig build on x86 when strict percpu address space checker is enabled. However, I have little idea what the code is doing, so I try to keep the proposed changes as non intrusive as possible. The referred code is questionable as it tries to reuse the clkevent pointer once as percpu pointer and once as generic pointer, which should be avoided.

The only other issue flagged in clocksource drivers directory is reported in [1] where generic request_irq() function apparently tries to handle the percpu pointer.

[1] https://lore.kernel.org/lkml/[email protected]/

Thanks,
Uros.