Skip to contentSkip to conversation

mfd: cros_ec: simplify cros_ec_dev_init()

PATCH Applied [email protected] 2 participants 2 messages Aug 19, 2024 – Aug 22, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: cros_ec: simplify cros_ec_dev_init()

From: Tzung-Bi Shih <[email protected]>

Simplify cros_ec_dev_init() by the following changes:
- Get rid of label failed_devreg.
- Remove a redundant space and comment.
- Use if (ret) instead of if (ret < 0).

---
 drivers/mfd/cros_ec_dev.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/mfd/cros_ec_dev.c +3 -8
index e2aae8918679..55b30076763b 100644
@@ -353,22 +353,17 @@ static int __init cros_ec_dev_init(void)
 {
 	int ret;
 
-	ret  = class_register(&cros_class);
+	ret = class_register(&cros_class);
 	if (ret) {
 		pr_err(CROS_EC_DEV_NAME ": failed to register device class\n");
 		return ret;
 	}
 
-	/* Register the driver */
 	ret = platform_driver_register(&cros_ec_dev_driver);
-	if (ret < 0) {
+	if (ret) {
 		pr_warn(CROS_EC_DEV_NAME ": can't register driver: %d\n", ret);
-		goto failed_devreg;
+		class_unregister(&cros_class);
 	}
-	return 0;
-
-failed_devreg:
-	class_unregister(&cros_class);
 	return ret;
 }
 
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw

Re: (subset) [PATCH] mfd: cros_ec: simplify cros_ec_dev_init()

Quoted 6 lines · On Mon, 19 Aug 2024 18:23:26 +0800, [email protected] wrote:

Simplify cros_ec_dev_init() by the following changes:
- Get rid of label failed_devreg.
- Remove a redundant space and comment.
- Use if (ret) instead of if (ret < 0).

Applied, thanks!

[1/1] mfd: cros_ec: simplify cros_ec_dev_init()

      commit: 70596c588adb5344e7002086d78ab5792d7d1069

--
Lee Jones [李琼斯]