Skip to contentSkip to conversation

drm/i915/gt: Continue creating engine sysfs files even after a failure

PATCH In review Andi Shyti 6 participants 14 messages Aug 19, 2024 – Sep 4, 2024

Subsystems (2)
lore
Share & tools
lore

Andi Shyti

author
#0 lore raw

PATCH 1/1 drm/i915/gt: Continue creating engine sysfs files even after a failure

The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/.

The process is straightforward: we loop over the UABI engines and for each one, we:

- Create the object.
- Create basic files.
- If the engine supports timeslicing, create timeslice duration files.
- If the engine supports preemption, create preemption-related files.
- Create default value files.

Currently, if any of these steps fail, the process stops, and no further sysfs files are created.

However, it's not necessary to stop the process on failure. Instead, we can continue creating the remaining sysfs files for the other engines. Even if some files fail to be created, the list of engines can still be retrieved by querying i915.

---
Hi,

It might make sense to create an "inv-<engine_name>" if something goes wrong, so that the user is aware that the engine exists, but the sysfs file is not present.

One further improvement would be to provide more information about thei failure reason the dev_warn() message.

Andi

 drivers/gpu/drm/i915/gt/sysfs_engines.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/sysfs_engines.c +2 -3
index 021f51d9b456..aab2759067d2 100644
@@ -530,9 +530,8 @@ void intel_engines_add_sysfs(struct drm_i915_private *i915)
 err_object:
 			kobject_put(kobj);
 err_engine:
-			dev_err(kdev, "Failed to add sysfs engine '%s'\n",
-				engine->name);
-			break;
+			dev_warn(kdev, "Failed to add sysfs engine '%s'\n",
+				 engine->name);
 		}
 	}
 }
Signature · 1 line
2.45.2
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915/gt: Continue creating engine sysfs files even after a failure

== Series Details ==

== Series Details ==

Series: drm/i915/gt: Continue creating engine sysfs files even after a failure
URL : https://patchwork.freedesktop.org/series/137451/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_15255 -> Patchwork_137451v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/index.html

Participating hosts (41 -> 40)
------------------------------

Additional (1): fi-kbl-8809g
Missing (2): fi-snb-2520m fi-bsw-n3050

Known issues
------------

Here are the changes found in Patchwork_137451v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][1] ([i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/fi-kbl-8809g/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-kbl-8809g: NOTRUN -> [SKIP][2] ([i915#4613]) +3 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/fi-kbl-8809g/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-kbl-8809g: NOTRUN -> [SKIP][3] +30 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/fi-kbl-8809g/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@ring_submission:
- fi-cfl-8109u: [DMESG-WARN][4] ([i915#11621]) -> [PASS][5] +81 other tests pass
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html

* igt@kms_flip@basic-flip-vs-wf_vblank@c-dp2:
- fi-cfl-8109u: [DMESG-WARN][6] ([i915#11621] / [i915#9925]) -> [PASS][7] +37 other tests pass
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/fi-cfl-8109u/igt@kms_flip@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/fi-cfl-8109u/igt@kms_flip@[email protected]

[i915#11621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11621
[i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#9925]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9925

Build changes
-------------

* Linux: CI_DRM_15255 -> Patchwork_137451v1

CI-20190529: 20190529
CI_DRM_15255: 02f693a1a747b2784cedbbd7f6cf35be9a652d94 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7975: 7975
Patchwork_137451v1: 02f693a1a747b2784cedbbd7f6cf35be9a652d94 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/index.html

#2 lore raw

✗ Fi.CI.IGT: failure for drm/i915/gt: Continue creating engine sysfs files even after a failure

In reply to Andi Shyti
== Series Details ==

== Series Details ==

Series: drm/i915/gt: Continue creating engine sysfs files even after a failure
URL : https://patchwork.freedesktop.org/series/137451/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_15255_full -> Patchwork_137451v1_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_137451v1_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_137451v1_full, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (9 -> 9)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_137451v1_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_create@forked@lmem0:
- shard-dg1: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg1-18/igt@gem_exec_create@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-15/igt@gem_exec_create@[email protected]

Known issues
------------

Here are the changes found in Patchwork_137451v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@device_reset@unbind-cold-reset-rebind:
- shard-rkl: NOTRUN -> [SKIP][3] ([i915#11078])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@[email protected]

* igt@drm_fdinfo@busy-idle-check-all@vcs1:
- shard-dg1: NOTRUN -> [SKIP][4] ([i915#8414]) +4 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@drm_fdinfo@[email protected]

* igt@drm_fdinfo@idle@rcs0:
- shard-rkl: NOTRUN -> [FAIL][5] ([i915#7742])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-2/igt@drm_fdinfo@[email protected]

* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [PASS][6] -> [FAIL][7] ([i915#7742])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-rkl-5/igt@drm_fdinfo@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@drm_fdinfo@[email protected]

* igt@drm_fdinfo@virtual-busy-idle-all:
- shard-dg2: NOTRUN -> [SKIP][8] ([i915#8414]) +1 other test skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gem_bad_reloc@negative-reloc:
- shard-rkl: NOTRUN -> [SKIP][9] ([i915#3281]) +13 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-2/igt@[email protected]

* igt@gem_basic@multigpu-create-close:
- shard-rkl: NOTRUN -> [SKIP][10] ([i915#7697])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@[email protected]

* igt@gem_ccs@block-multicopy-inplace:
- shard-tglu: NOTRUN -> [SKIP][11] ([i915#3555] / [i915#9323])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@gem_ccs@ctrl-surf-copy:
- shard-rkl: NOTRUN -> [SKIP][12] ([i915#3555] / [i915#9323])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@[email protected]

* igt@gem_ccs@ctrl-surf-copy-new-ctx:
- shard-rkl: NOTRUN -> [SKIP][13] ([i915#9323])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@gem_ctx_persistence@hostile:
- shard-tglu: [PASS][14] -> [FAIL][15] ([i915#11980])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-tglu-9/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@gem_ctx_sseu@mmap-args:
- shard-rkl: NOTRUN -> [SKIP][16] ([i915#280])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@[email protected]

* igt@gem_exec_balancer@bonded-dual:
- shard-dg2: NOTRUN -> [SKIP][17] ([i915#4771])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gem_exec_balancer@bonded-true-hang:
- shard-dg1: NOTRUN -> [SKIP][18] ([i915#4812])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@gem_exec_fair@basic-none:
- shard-dg1: NOTRUN -> [SKIP][19] ([i915#3539] / [i915#4852])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@gem_exec_fair@basic-none-share:
- shard-dg2: NOTRUN -> [SKIP][20] ([i915#3539] / [i915#4852]) +2 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-rkl: NOTRUN -> [FAIL][21] ([i915#2842]) +3 other tests fail
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: NOTRUN -> [FAIL][22] ([i915#2842])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-glk5/igt@gem_exec_fair@[email protected]
- shard-tglu: NOTRUN -> [FAIL][23] ([i915#2842])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-cpu-read:
- shard-dg1: NOTRUN -> [SKIP][24] ([i915#3281]) +1 other test skip
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@gem_exec_reloc@basic-cpu-wc-noreloc:
- shard-dg2: NOTRUN -> [SKIP][25] ([i915#3281]) +2 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gem_fence_thrash@bo-write-verify-threaded-none:
- shard-dg2: NOTRUN -> [SKIP][26] ([i915#4860])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-rkl: NOTRUN -> [SKIP][27] ([i915#4613]) +4 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@[email protected]

* igt@gem_lmem_swapping@verify-ccs:
- shard-glk: NOTRUN -> [SKIP][28] ([i915#4613]) +1 other test skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-glk5/igt@[email protected]

* igt@gem_mmap_gtt@bad-object:
- shard-dg2: NOTRUN -> [SKIP][29] ([i915#4077]) +3 other tests skip
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gem_mmap_gtt@coherency:
- shard-dg1: NOTRUN -> [SKIP][30] ([i915#4077]) +3 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@gem_mmap_offset@clear@smem0:
- shard-mtlp: [PASS][31] -> [ABORT][32] ([i915#10029] / [i915#10729])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-mtlp-6/igt@gem_mmap_offset@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-mtlp-2/igt@gem_mmap_offset@[email protected]

* igt@gem_mmap_wc@write-read:
- shard-dg1: NOTRUN -> [SKIP][33] ([i915#4083]) +2 other tests skip
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@gem_mmap_wc@write-wc-read-gtt:
- shard-dg2: NOTRUN -> [SKIP][34] ([i915#4083])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-rkl: NOTRUN -> [SKIP][35] ([i915#3282]) +5 other tests skip
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@gem_pwrite@basic-self:
- shard-dg1: NOTRUN -> [SKIP][36] ([i915#3282])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@gem_pxp@create-protected-buffer:
- shard-tglu: NOTRUN -> [SKIP][37] ([i915#4270])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@gem_pxp@reject-modify-context-protection-off-1:
- shard-dg2: NOTRUN -> [SKIP][38] ([i915#4270])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gem_pxp@reject-modify-context-protection-on:
- shard-rkl: NOTRUN -> [SKIP][39] ([i915#4270]) +2 other tests skip
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@gem_readwrite@write-bad-handle:
- shard-dg2: NOTRUN -> [SKIP][40] ([i915#3282])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gem_render_copy@y-tiled-to-vebox-y-tiled:
- shard-dg2: NOTRUN -> [SKIP][41] ([i915#5190] / [i915#8428]) +1 other test skip
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gem_set_tiling_vs_blt@tiled-to-tiled:
- shard-rkl: NOTRUN -> [SKIP][42] ([i915#8411]) +1 other test skip
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@gem_userptr_blits@access-control:
- shard-rkl: NOTRUN -> [SKIP][43] ([i915#3297])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-2/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-rkl: NOTRUN -> [SKIP][44] ([i915#3297] / [i915#3323])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@gem_userptr_blits@forbidden-operations:
- shard-dg1: NOTRUN -> [SKIP][45] ([i915#3282] / [i915#3297])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@gen7_exec_parse@basic-allocation:
- shard-dg2: NOTRUN -> [SKIP][46] +5 other tests skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gen9_exec_parse@bb-oversize:
- shard-dg1: NOTRUN -> [SKIP][47] ([i915#2527])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@gen9_exec_parse@bb-start-out:
- shard-rkl: NOTRUN -> [SKIP][48] ([i915#2527]) +4 other tests skip
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@[email protected]

* igt@gen9_exec_parse@secure-batches:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#2856])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@gen9_exec_parse@valid-registers:
- shard-tglu: NOTRUN -> [SKIP][50] ([i915#2527] / [i915#2856]) +1 other test skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@i915_fb_tiling:
- shard-dg1: NOTRUN -> [SKIP][51] ([i915#4881])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@i915_fb_tiling.html

* igt@i915_module_load@reload-with-fault-injection:
- shard-dg1: [PASS][52] -> [ABORT][53] ([i915#9820])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg1-16/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-16/igt@[email protected]
- shard-dg2: NOTRUN -> [ABORT][54] ([i915#9820])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@i915_pm_freq_api@freq-reset:
- shard-rkl: NOTRUN -> [SKIP][55] ([i915#8399])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@i915_pm_sseu@full-enable:
- shard-rkl: NOTRUN -> [SKIP][56] ([i915#4387])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@i915_query@hwconfig_table:
- shard-tglu: NOTRUN -> [SKIP][57] ([i915#6245])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@i915_query@hwconfig_table.html

* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-dg2: NOTRUN -> [SKIP][58] ([i915#1769] / [i915#3555]) +1 other test skip
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html

* igt@kms_big_fb@4-tiled-64bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][59] ([i915#4538] / [i915#5286]) +1 other test skip
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@kms_big_fb@4-tiled-addfb:
- shard-rkl: NOTRUN -> [SKIP][60] ([i915#5286]) +7 other tests skip
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-2/igt@[email protected]

* igt@kms_big_fb@4-tiled-addfb-size-offset-overflow:
- shard-tglu: NOTRUN -> [SKIP][61] ([i915#5286]) +1 other test skip
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-dg1: NOTRUN -> [SKIP][62] ([i915#3638])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-dg2: NOTRUN -> [SKIP][63] ([i915#4538] / [i915#5190]) +2 other tests skip
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-rkl: NOTRUN -> [SKIP][64] ([i915#3638]) +2 other tests skip
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@[email protected]

* igt@kms_big_joiner@basic:
- shard-dg2: NOTRUN -> [SKIP][65] ([i915#10656]) +1 other test skip
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@kms_big_joiner@invalid-modeset-force-joiner:
- shard-tglu: NOTRUN -> [SKIP][66] ([i915#10656])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@kms_ccs@bad-pixel-format-y-tiled-gen12-rc-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][67] ([i915#10307] / [i915#10434] / [i915#6095]) +1 other test skip
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-2/igt@kms_ccs@[email protected]

* igt@kms_ccs@bad-rotation-90-4-tiled-mtl-mc-ccs@pipe-d-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][68] ([i915#6095]) +7 other tests skip
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@kms_ccs@[email protected]

* igt@kms_ccs@bad-rotation-90-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][69] ([i915#6095]) +43 other tests skip
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-primary-rotation-180-yf-tiled-ccs@pipe-d-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][70] ([i915#6095]) +31 other tests skip
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][71] ([i915#10307] / [i915#6095]) +165 other tests skip
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-5/igt@kms_ccs@[email protected]

* igt@kms_ccs@random-ccs-data-y-tiled-gen12-rc-ccs@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][72] +104 other tests skip
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-glk5/igt@kms_ccs@[email protected]

* igt@kms_cdclk@mode-transition:
- shard-rkl: NOTRUN -> [SKIP][73] ([i915#3742])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][74] ([i915#11616] / [i915#7213]) +3 other tests skip
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-2/igt@kms_cdclk@[email protected]

* igt@kms_chamelium_audio@dp-audio-edid:
- shard-dg2: NOTRUN -> [SKIP][75] ([i915#7828]) +2 other tests skip
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@kms_chamelium_audio@hdmi-audio-edid:
- shard-dg1: NOTRUN -> [SKIP][76] ([i915#7828]) +1 other test skip
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@kms_chamelium_edid@hdmi-mode-timings:
- shard-tglu: NOTRUN -> [SKIP][77] ([i915#7828]) +2 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@kms_chamelium_hpd@vga-hpd-fast:
- shard-rkl: NOTRUN -> [SKIP][78] ([i915#7828]) +10 other tests skip
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@[email protected]

* igt@kms_color@deep-color:
- shard-dg2: NOTRUN -> [SKIP][79] ([i915#3555]) +1 other test skip
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-6/igt@[email protected]

* igt@kms_content_protection@content-type-change:
- shard-tglu: NOTRUN -> [SKIP][80] ([i915#6944] / [i915#9424])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-rkl: NOTRUN -> [SKIP][81] ([i915#3116])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@[email protected]

* igt@kms_content_protection@lic-type-0@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][82] ([i915#7173])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-11/igt@kms_content_protection@[email protected]

* igt@kms_cursor_crc@cursor-offscreen-max-size:
- shard-dg1: NOTRUN -> [SKIP][83] ([i915#3555])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-rkl: NOTRUN -> [SKIP][84] ([i915#11453]) +3 other tests skip
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size:
- shard-rkl: NOTRUN -> [SKIP][85] ([i915#4103]) +1 other test skip
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size.html

* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-tglu: NOTRUN -> [SKIP][86] ([i915#4103])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html

* igt@kms_dirtyfb@psr-dirtyfb-ioctl:
- shard-rkl: NOTRUN -> [SKIP][87] ([i915#9723])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@kms_dsc@dsc-with-formats:
- shard-rkl: NOTRUN -> [SKIP][88] ([i915#3555] / [i915#3840])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-2/igt@[email protected]

* igt@kms_dsc@dsc-with-output-formats:
- shard-tglu: NOTRUN -> [SKIP][89] ([i915#3555] / [i915#3840])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@kms_feature_discovery@chamelium:
- shard-rkl: NOTRUN -> [SKIP][90] ([i915#4854])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@kms_feature_discovery@psr2:
- shard-rkl: NOTRUN -> [SKIP][91] ([i915#658])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible:
- shard-dg1: NOTRUN -> [SKIP][92] ([i915#9934])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible.html

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-tglu: NOTRUN -> [SKIP][93] ([i915#3637])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@kms_flip@2x-plain-flip:
- shard-rkl: NOTRUN -> [SKIP][94] +28 other tests skip
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@kms_flip@plain-flip-ts-check@b-vga1:
- shard-snb: [PASS][95] -> [FAIL][96] ([i915#2122]) +1 other test fail
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-snb4/igt@kms_flip@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-snb7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-valid-mode:
- shard-dg1: NOTRUN -> [SKIP][97] ([i915#2587] / [i915#2672]) +1 other test skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][98] ([i915#2672]) +3 other tests skip
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][99] ([i915#2587] / [i915#2672])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][100] ([i915#2672] / [i915#3555])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-dg2: NOTRUN -> [SKIP][101] ([i915#5354]) +11 other tests skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen:
- shard-dg2: NOTRUN -> [SKIP][102] ([i915#3458]) +6 other tests skip
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-render:
- shard-tglu: NOTRUN -> [SKIP][103] +14 other tests skip
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt:
- shard-rkl: NOTRUN -> [SKIP][104] ([i915#1825]) +43 other tests skip
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-render:
- shard-dg1: NOTRUN -> [SKIP][105] ([i915#3458]) +3 other tests skip
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][106] ([i915#8708]) +3 other tests skip
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-rkl: NOTRUN -> [SKIP][107] ([i915#3023]) +24 other tests skip
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-blt:
- shard-dg1: NOTRUN -> [SKIP][108] +6 other tests skip
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-dg2: NOTRUN -> [SKIP][109] ([i915#8708]) +7 other tests skip
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-wc.html

* igt@kms_hdr@bpc-switch:
- shard-dg1: NOTRUN -> [SKIP][110] ([i915#3555] / [i915#8228])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@kms_hdr@invalid-hdr:
- shard-dg2: NOTRUN -> [SKIP][111] ([i915#3555] / [i915#8228]) +1 other test skip
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@kms_hdr@static-toggle:
- shard-rkl: NOTRUN -> [SKIP][112] ([i915#3555] / [i915#8228]) +1 other test skip
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@[email protected]

* igt@kms_panel_fitting@legacy:
- shard-rkl: NOTRUN -> [SKIP][113] ([i915#6301])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@[email protected]

* igt@kms_plane_multiple@tiling-yf:
- shard-rkl: NOTRUN -> [SKIP][114] ([i915#3555]) +6 other tests skip
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-b-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][115] ([i915#9423]) +23 other tests skip
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-1/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-b-hdmi-a-3.html

* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][116] ([i915#9423]) +9 other tests skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-upscale-20x20-with-rotation@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][117] ([i915#9423]) +7 other tests skip
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-18/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][118] ([i915#5235]) +2 other tests skip
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-3.html

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][119] ([i915#9728]) +4 other tests skip
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@kms_plane_scaling@[email protected]

* igt@kms_pm_backlight@fade-with-suspend:
- shard-tglu: NOTRUN -> [SKIP][120] ([i915#9812])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@kms_pm_dc@dc5-psr:
- shard-rkl: NOTRUN -> [SKIP][121] ([i915#9685])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-2/igt@[email protected]

* igt@kms_pm_dc@dc6-dpms:
- shard-tglu: [PASS][122] -> [FAIL][123] ([i915#9295])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-tglu-3/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-7/igt@[email protected]

* igt@kms_pm_dc@dc6-psr:
- shard-dg2: NOTRUN -> [SKIP][124] ([i915#9685]) +1 other test skip
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@kms_pm_dc@dc9-dpms:
- shard-rkl: NOTRUN -> [SKIP][125] ([i915#3361])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp-stress:
- shard-dg2: NOTRUN -> [SKIP][126] ([i915#9519])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]
- shard-rkl: [PASS][127] -> [SKIP][128] ([i915#9519])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-rkl-4/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-3/igt@[email protected]

* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-dg2: [PASS][129] -> [SKIP][130] ([i915#9519]) +3 other tests skip
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-3/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-8/igt@[email protected]

* igt@kms_prime@basic-modeset-hybrid:
- shard-rkl: NOTRUN -> [SKIP][131] ([i915#6524])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-rkl: NOTRUN -> [SKIP][132] ([i915#11520]) +4 other tests skip
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-dg1: NOTRUN -> [SKIP][133] ([i915#11520])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-tglu: NOTRUN -> [SKIP][134] ([i915#11520])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-dg2: NOTRUN -> [SKIP][135] ([i915#11520])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-dg2: NOTRUN -> [SKIP][136] ([i915#9683])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@kms_psr2_su@page_flip-p010:
- shard-rkl: NOTRUN -> [SKIP][137] ([i915#9683])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@kms_psr2_su@page_flip-p010.html

* igt@kms_psr@fbc-pr-primary-mmap-gtt:
- shard-tglu: NOTRUN -> [SKIP][138] ([i915#9732]) +4 other tests skip
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@kms_psr@fbc-pr-sprite-render:
- shard-dg1: NOTRUN -> [SKIP][139] ([i915#1072] / [i915#9732]) +5 other tests skip
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-13/igt@[email protected]

* igt@kms_psr@psr-sprite-plane-onoff:
- shard-rkl: NOTRUN -> [SKIP][140] ([i915#1072] / [i915#9732]) +24 other tests skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@kms_psr@psr2-cursor-plane-move:
- shard-dg2: NOTRUN -> [SKIP][141] ([i915#1072] / [i915#9732]) +4 other tests skip
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-rkl: NOTRUN -> [SKIP][142] ([i915#5289]) +2 other tests skip
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@[email protected]

* igt@kms_sysfs_edid_timing:
- shard-dg2: [PASS][143] -> [FAIL][144] ([IGT#2])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-11/igt@kms_sysfs_edid_timing.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-6/igt@kms_sysfs_edid_timing.html

* igt@kms_vrr@max-min:
- shard-rkl: NOTRUN -> [SKIP][145] ([i915#9906])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@kms_vrr@seamless-rr-switch-vrr:
- shard-dg2: NOTRUN -> [SKIP][146] ([i915#9906])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-rkl: NOTRUN -> [SKIP][147] ([i915#2437])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]

* igt@kms_writeback@writeback-check-output-xrgb2101010:
- shard-rkl: NOTRUN -> [SKIP][148] ([i915#2437] / [i915#9412]) +1 other test skip
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-6/igt@[email protected]

* igt@perf@per-context-mode-unprivileged:
- shard-rkl: NOTRUN -> [SKIP][149] ([i915#2435])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@[email protected]

* igt@perf_pmu@busy-idle@vecs1:
- shard-dg2: [PASS][150] -> [INCOMPLETE][151] ([i915#9853])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-11/igt@perf_pmu@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-7/igt@perf_pmu@[email protected]

* igt@perf_pmu@enable-race@vcs0:
- shard-glk: [PASS][152] -> [DMESG-WARN][153] ([i915#118])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-glk5/igt@perf_pmu@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-glk8/igt@perf_pmu@[email protected]

* igt@perf_pmu@rc6-all-gts:
- shard-tglu: NOTRUN -> [SKIP][154] ([i915#8516])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-8/igt@[email protected]

* igt@perf_pmu@rc6@other-idle-gt0:
- shard-rkl: NOTRUN -> [SKIP][155] ([i915#8516])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-2/igt@perf_pmu@[email protected]

* igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
- shard-dg2: NOTRUN -> [CRASH][156] ([i915#9351])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html

* igt@prime_vgem@basic-gtt:
- shard-dg2: NOTRUN -> [SKIP][157] ([i915#3708] / [i915#4077]) +1 other test skip
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@prime_vgem@basic-write:
- shard-rkl: NOTRUN -> [SKIP][158] ([i915#3291] / [i915#3708]) +1 other test skip
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-2/igt@[email protected]

* igt@prime_vgem@fence-read-hang:
- shard-dg2: NOTRUN -> [SKIP][159] ([i915#3708])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@sriov_basic@enable-vfs-bind-unbind-each-numvfs-all:
- shard-dg2: NOTRUN -> [SKIP][160] ([i915#9917])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@[email protected]

* igt@syncobj_timeline@invalid-wait-zero-handles:
- shard-rkl: NOTRUN -> [FAIL][161] ([i915#9781]) +1 other test fail
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-4/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][162] ([i915#9781]) +1 other test fail
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-glk5/igt@[email protected]

* igt@tools_test@sysfs_l3_parity:
- shard-dg2: NOTRUN -> [SKIP][163] ([i915#4818])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-3/igt@tools_test@sysfs_l3_parity.html

#### Possible fixes ####

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-rkl: [FAIL][164] ([i915#2842]) -> [PASS][165]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-rkl-4/igt@gem_exec_fair@[email protected]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-2/igt@gem_exec_fair@[email protected]

* igt@i915_module_load@reload:
- shard-dg1: [DMESG-WARN][166] ([i915#4391] / [i915#4423]) -> [PASS][167]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg1-14/igt@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-16/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@gt0-bcs0:
- shard-dg1: [FAIL][168] ([i915#3591]) -> [PASS][169]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg1-17/igt@i915_pm_rc6_residency@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-16/igt@i915_pm_rc6_residency@[email protected]

* igt@kms_atomic_transition@modeset-transition-fencing@2x-outputs:
- shard-glk: [FAIL][170] ([i915#11859]) -> [PASS][171]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-glk8/igt@kms_atomic_transition@[email protected]
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-glk9/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-hdmi-a-1:
- shard-tglu: [FAIL][172] ([i915#11808]) -> [PASS][173]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-tglu-9/igt@kms_atomic_transition@[email protected]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-3/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-hdmi-a-4:
- shard-dg1: [FAIL][174] ([i915#5956]) -> [PASS][175]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg1-18/igt@kms_atomic_transition@[email protected]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg1-18/igt@kms_atomic_transition@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-dg2: [FAIL][176] ([i915#6880]) -> [PASS][177]
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html

* igt@kms_pm_rpm@dpms-non-lpsp:
- shard-dg2: [SKIP][178] ([i915#9519]) -> [PASS][179]
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-4/igt@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-11/igt@[email protected]
- shard-rkl: [SKIP][180] ([i915#9519]) -> [PASS][181]
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-rkl-2/igt@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-rkl-5/igt@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-b-edp-1:
- shard-mtlp: [FAIL][182] ([i915#9196]) -> [PASS][183]
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-mtlp-3/igt@kms_universal_plane@[email protected]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-mtlp-5/igt@kms_universal_plane@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-d-hdmi-a-1:
- shard-tglu: [FAIL][184] ([i915#9196]) -> [PASS][185] +2 other tests pass
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-tglu-7/igt@kms_universal_plane@[email protected]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-tglu-9/igt@kms_universal_plane@[email protected]

#### Warnings ####

* igt@kms_cursor_crc@cursor-random-512x512:
- shard-dg2: [SKIP][186] ([i915#11453]) -> [SKIP][187] ([i915#11453] / [i915#3359]) +2 other tests skip
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-2/igt@[email protected]
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-11/igt@[email protected]

* igt@kms_cursor_crc@cursor-rapid-movement-512x512:
- shard-dg2: [SKIP][188] ([i915#11453] / [i915#3359]) -> [SKIP][189] ([i915#11453]) +1 other test skip
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-11/igt@[email protected]
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu:
- shard-dg2: [SKIP][190] ([i915#3458]) -> [SKIP][191] ([i915#10433] / [i915#3458]) +1 other test skip
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu.html
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-dg2: [SKIP][192] ([i915#10433] / [i915#3458]) -> [SKIP][193] ([i915#3458]) +2 other tests skip
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html

* igt@kms_psr@fbc-psr-cursor-plane-move:
- shard-dg2: [SKIP][194] ([i915#1072] / [i915#9732]) -> [SKIP][195] ([i915#1072] / [i915#9673] / [i915#9732]) +15 other tests skip
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-1/igt@[email protected]
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-11/igt@[email protected]

* igt@kms_psr@psr-cursor-mmap-cpu:
- shard-dg2: [SKIP][196] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][197] ([i915#1072] / [i915#9732]) +13 other tests skip
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-11/igt@[email protected]
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-1/igt@[email protected]

* igt@kms_rotation_crc@primary-y-tiled-reflect-x-270:
- shard-dg2: [SKIP][198] ([i915#11131] / [i915#4235] / [i915#5190]) -> [SKIP][199] ([i915#11131] / [i915#5190])
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-11/igt@[email protected]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-1/igt@[email protected]

* igt@kms_rotation_crc@primary-y-tiled-reflect-x-90:
- shard-dg2: [SKIP][200] ([i915#11131] / [i915#5190]) -> [SKIP][201] ([i915#11131] / [i915#4235] / [i915#5190])
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-4/igt@[email protected]
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-11/igt@[email protected]

* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-dg2: [SKIP][202] ([i915#11131]) -> [SKIP][203] ([i915#11131] / [i915#4235]) +1 other test skip
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-dg2-1/igt@[email protected]
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-dg2-11/igt@[email protected]

* igt@kms_tiled_display@basic-test-pattern:
- shard-glk: [SKIP][204] -> [FAIL][205] ([i915#10959])
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15255/shard-glk8/igt@[email protected]
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/shard-glk5/igt@[email protected]

[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[i915#10029]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10029
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10656
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#10729]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10729
[i915#10959]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10959
[i915#11078]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11078
[i915#11131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11131
[i915#11453]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11453
[i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
[i915#11616]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11616
[i915#118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/118
[i915#11808]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11808
[i915#11859]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11859
[i915#11980]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11980
[i915#1769]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#2122]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2122
[i915#2435]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4423
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4818
[i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860
[i915#4881]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4881
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5956]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5956
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6245]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6245
[i915#6301]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6301
[i915#6524]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/658
[i915#6880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6880
[i915#6944]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6944
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7213
[i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697
[i915#7742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8399]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8399
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8516]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8516
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
[i915#9295]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9295
[i915#9323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9323
[i915#9351]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9351
[i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
[i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
[i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
[i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
[i915#9728]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9728
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9781]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9781
[i915#9812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9812
[i915#9820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9820
[i915#9853]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9853
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934

Build changes
-------------

* Linux: CI_DRM_15255 -> Patchwork_137451v1

CI-20190529: 20190529
CI_DRM_15255: 02f693a1a747b2784cedbbd7f6cf35be9a652d94 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7975: 7975
Patchwork_137451v1: 02f693a1a747b2784cedbbd7f6cf35be9a652d94 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137451v1/index.html

maintainer
#3 lore raw
In reply to Andi Shyti
Quoted 20 lines · Andi Shyti

The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/.

The process is straightforward: we loop over the UABI engines and for each one, we:

- Create the object.
- Create basic files.
- If the engine supports timeslicing, create timeslice duration files.
- If the engine supports preemption, create preemption-related files.
- Create default value files.

Currently, if any of these steps fail, the process stops, and no further sysfs files are created.

However, it's not necessary to stop the process on failure. Instead, we can continue creating the remaining sysfs files for the other engines. Even if some files fail to be created, the list of engines can still be retrieved by querying i915.

Quoted 7 lines

---
Hi,

It might make sense to create an "inv-<engine_name>" if something goes wrong, so that the user is aware that the engine exists, but the sysfs file is not present.

well, if the sysfs dir/files creation is failing, then it will probably be unreliable anyway right?

Quoted 3 lines

One further improvement would be to provide more information about thei failure reason the dev_warn() message.

So, perhaps this patch should already go there and remove the dev_err and add individual dev_warn for each failing path?

Also it looks something is off with the goto paths...

That if (0) is also ugly... probably better to use a kobject_put with continue on every failing point as well...

Quoted 25 lines

Andi

 drivers/gpu/drm/i915/gt/sysfs_engines.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/sysfs_engines.c +2 -3
index 021f51d9b456..aab2759067d2 100644
@@ -530,9 +530,8 @@ void intel_engines_add_sysfs(struct drm_i915_private *i915)
 err_object:
 			kobject_put(kobj);
 err_engine:
-			dev_err(kdev, "Failed to add sysfs engine '%s'\n",
-				engine->name);
-			break;
+			dev_warn(kdev, "Failed to add sysfs engine '%s'\n",
+				 engine->name);
 		}
 	}
 }
Signature · 1 line
2.45.2
author
#4 lore raw

Hi Rodrigo,

Quoted 25 lines · Rodrigo Vivi
Quoted 24 lines · Andi Shyti

The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/.

The process is straightforward: we loop over the UABI engines and for each one, we:

- Create the object.
- Create basic files.
- If the engine supports timeslicing, create timeslice duration files.
- If the engine supports preemption, create preemption-related files.
- Create default value files.

Currently, if any of these steps fail, the process stops, and no further sysfs files are created.

However, it's not necessary to stop the process on failure. Instead, we can continue creating the remaining sysfs files for the other engines. Even if some files fail to be created, the list of engines can still be retrieved by querying i915.

---
Hi,

Quoted 6 lines
Quoted 3 lines

It might make sense to create an "inv-<engine_name>" if something goes wrong, so that the user is aware that the engine exists, but the sysfs file is not present.

well, if the sysfs dir/files creation is failing, then it will probably be unreliable anyway right?

Are you suggesting that "inv-<engine_name>" is OK?

Quoted 5 lines
Quoted 2 lines

One further improvement would be to provide more information about thei failure reason the dev_warn() message.

So, perhaps this patch should already go there and remove the dev_err and add individual dev_warn for each failing path?

That's a suggestion, but it doesn't mean that it necessarily improves things as it might add some innecessary information. Just thinking.

Quoted 4 lines

Also it looks something is off with the goto paths...

That if (0) is also ugly... probably better to use a kobject_put with continue on every failing point as well...

ehehe... I came to like it, to be honest. Besides I like single exit paths instead of distributed returns. In this particular case we would replcate the same "kobject_put() ... dev_warn()" in several places, so that I'm not sure it's better.

If you like more we could do:

	for (...) {
		...
		...
		/* everything goes fine */
		continue

err_engine:

		kobject_put(...);
		dev_warn(...);
	}

And we avoid using the "if (0)" that you don't like.

Thanks,
Andi

author
#5 lore raw

Hi Again, Rodrigo,

...

Quoted 18 lines
Quoted 4 lines

Also it looks something is off with the goto paths...

That if (0) is also ugly... probably better to use a kobject_put with continue on every failing point as well...

ehehe... I came to like it, to be honest. Besides I like single exit paths instead of distributed returns. In this particular case we would replcate the same "kobject_put() ... dev_warn()" in several places, so that I'm not sure it's better.

If you like more we could do:

	for (...) {
		...
		...
		/* everything goes fine */
		continue
Quoted 6 lines

err_engine:

		kobject_put(...);
		dev_warn(...);
	}

And we avoid using the "if (0)" that you don't like.

BTW, the purpose of the patch is to remove the break and, as I was at it, I chhanged dev_err/dev_warn.

Refactoring the "if (0)" is a bit out of scope. Right?

Thanks,
Andi

maintainer Reviewed-by
#6 lore raw
In reply to Andi Shyti
Quoted 28 lines · Andi Shyti

Hi Rodrigo,

Quoted 25 lines · Rodrigo Vivi
Quoted 24 lines · Andi Shyti

The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/.

The process is straightforward: we loop over the UABI engines and for each one, we:

- Create the object.
- Create basic files.
- If the engine supports timeslicing, create timeslice duration files.
- If the engine supports preemption, create preemption-related files.
- Create default value files.

Currently, if any of these steps fail, the process stops, and no further sysfs files are created.

However, it's not necessary to stop the process on failure. Instead, we can continue creating the remaining sysfs files for the other engines. Even if some files fail to be created, the list of engines can still be retrieved by querying i915.

---
Hi,

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

It might make sense to create an "inv-<engine_name>" if something goes wrong, so that the user is aware that the engine exists, but the sysfs file is not present.

well, if the sysfs dir/files creation is failing, then it will probably be unreliable anyway right?

Are you suggesting that "inv-<engine_name>" is OK?

it is okay I guess.
But my point is more on, how are we going to create this if the creation mechanism is what is likely failing here.

Quoted 10 lines
Quoted 6 lines
Quoted 3 lines

One further improvement would be to provide more information about thei failure reason the dev_warn() message.

So, perhaps this patch should already go there and remove the dev_err and add individual dev_warn for each failing path?

That's a suggestion, but it doesn't mean that it necessarily improves things as it might add some innecessary information. Just thinking.

okay then.

Quoted 19 lines
Quoted 5 lines

Also it looks something is off with the goto paths...

That if (0) is also ugly... probably better to use a kobject_put with continue on every failing point as well...

ehehe... I came to like it, to be honest. Besides I like single exit paths instead of distributed returns. In this particular case we would replcate the same "kobject_put() ... dev_warn()" in several places, so that I'm not sure it's better.

If you like more we could do:

	for (...) {
		...
		...
		/* everything goes fine */
		continue
Quoted 6 lines

err_engine:

		kobject_put(...);
		dev_warn(...);
	}

And we avoid using the "if (0)" that you don't like.

nah, no strong feeling from my side. It is there, let's avoid unnecessary refactors.

on this patch as is. And sorry for the delay.

Quoted 3 lines

Thanks,
Andi

author
#7 lore raw

Hi Rodrigo,

Quoted 3 lines · Rodrigo Vivi
Quoted 2 lines · Andi Shyti
Quoted 1 line · Rodrigo Vivi

On Mon, Aug 19, 2024 at 01:31:40PM +0200, Andi Shyti wrote:

...

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

It might make sense to create an "inv-<engine_name>" if something goes wrong, so that the user is aware that the engine exists, but the sysfs file is not present.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

well, if the sysfs dir/files creation is failing, then it will probably be unreliable anyway right?

Are you suggesting that "inv-<engine_name>" is OK?

it is okay I guess.
But my point is more on, how are we going to create this if the creation mechanism is what is likely failing here.

We can fail for different reasons... but yeah you are right, it doesn't make much sense, as also the creation of "inv-<...>" interfaces might be unreliable.

Quoted 23 lines
Quoted 23 lines
Quoted 4 lines

Also it looks something is off with the goto paths...

That if (0) is also ugly... probably better to use a kobject_put with continue on every failing point as well...

ehehe... I came to like it, to be honest. Besides I like single exit paths instead of distributed returns. In this particular case we would replcate the same "kobject_put() ... dev_warn()" in several places, so that I'm not sure it's better.

If you like more we could do:

	for (...) {
		...
		...
		/* everything goes fine */
		continue

err_engine:

		kobject_put(...);
		dev_warn(...);
	}
Quoted 8 lines
Quoted 1 line

And we avoid using the "if (0)" that you don't like.

nah, no strong feeling from my side. It is there, let's avoid unnecessary refactors.

on this patch as is. And sorry for the delay.

Thanks a lot for your review :-)

Andi

#8 lore raw
In reply to Andi Shyti
Quoted 15 lines · Andi Shyti

The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/.

The process is straightforward: we loop over the UABI engines and for each one, we:

- Create the object.
- Create basic files.
- If the engine supports timeslicing, create timeslice duration files.
- If the engine supports preemption, create preemption-related files.
- Create default value files.

Currently, if any of these steps fail, the process stops, and no further sysfs files are created.

Quoted 6 lines

However, it's not necessary to stop the process on failure. Instead, we can continue creating the remaining sysfs files for the other engines. Even if some files fail to be created, the list of engines can still be retrieved by querying i915.

Uh, sysfs is uapi. Either we need it, and it _must_ be there, or it's not needed, and we should delete those files probably.

This is different from debugfs, where failures are consistently ignored because that's the conscious design choice Greg made and wants supported. Because debugfs is optional.

So please make sure we correctly fail driver load if these don't register. Even better would be if sysfs files are registered atomically as attribute blocks, but that's an entire different can of worms. But that would really clean up this code and essentially put any failure handling onto core driver model and sysfs code.
-Sima

Quoted 34 lines

---
Hi,

It might make sense to create an "inv-<engine_name>" if something goes wrong, so that the user is aware that the engine exists, but the sysfs file is not present.

One further improvement would be to provide more information about thei failure reason the dev_warn() message.

Andi

 drivers/gpu/drm/i915/gt/sysfs_engines.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/sysfs_engines.c +2 -3
index 021f51d9b456..aab2759067d2 100644
@@ -530,9 +530,8 @@ void intel_engines_add_sysfs(struct drm_i915_private *i915)
 err_object:
 			kobject_put(kobj);
 err_engine:
-			dev_err(kdev, "Failed to add sysfs engine '%s'\n",
-				engine->name);
-			break;
+			dev_warn(kdev, "Failed to add sysfs engine '%s'\n",
+				 engine->name);
 		}
 	}
 }
Signature · 1 line
2.45.2
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
maintainer
#9 lore raw
Quoted 30 lines · Daniel Vetter
Quoted 15 lines · Andi Shyti

The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/.

The process is straightforward: we loop over the UABI engines and for each one, we:

- Create the object.
- Create basic files.
- If the engine supports timeslicing, create timeslice duration files.
- If the engine supports preemption, create preemption-related files.
- Create default value files.

Currently, if any of these steps fail, the process stops, and no further sysfs files are created.

Quoted 6 lines

However, it's not necessary to stop the process on failure. Instead, we can continue creating the remaining sysfs files for the other engines. Even if some files fail to be created, the list of engines can still be retrieved by querying i915.

Uh, sysfs is uapi. Either we need it, and it _must_ be there, or it's not needed, and we should delete those files probably.

This is different from debugfs, where failures are consistently ignored because that's the conscious design choice Greg made and wants supported. Because debugfs is optional.

Quoted 5 lines

So please make sure we correctly fail driver load if these don't register. Even better would be if sysfs files are registered atomically as attribute blocks, but that's an entire different can of worms. But that would really clean up this code and essentially put any failure handling onto core driver model and sysfs code.

Indeed very good point. Sorry for having missed this perspective.

Quoted 41 lines

-Sima

Quoted 34 lines

---
Hi,

It might make sense to create an "inv-<engine_name>" if something goes wrong, so that the user is aware that the engine exists, but the sysfs file is not present.

One further improvement would be to provide more information about thei failure reason the dev_warn() message.

Andi

 drivers/gpu/drm/i915/gt/sysfs_engines.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/sysfs_engines.c +2 -3
index 021f51d9b456..aab2759067d2 100644
@@ -530,9 +530,8 @@ void intel_engines_add_sysfs(struct drm_i915_private *i915)
 err_object:
 			kobject_put(kobj);
 err_engine:
-			dev_err(kdev, "Failed to add sysfs engine '%s'\n",
-				engine->name);
-			break;
+			dev_warn(kdev, "Failed to add sysfs engine '%s'\n",
+				 engine->name);
 		}
 	}
 }
Signature · 1 line
2.45.2
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
author
#10 lore raw
In reply to Daniel Vetter

Hi Sima,

Quoted 30 lines · Daniel Vetter
Quoted 15 lines · Andi Shyti

The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/.

The process is straightforward: we loop over the UABI engines and for each one, we:

- Create the object.
- Create basic files.
- If the engine supports timeslicing, create timeslice duration files.
- If the engine supports preemption, create preemption-related files.
- Create default value files.

Currently, if any of these steps fail, the process stops, and no further sysfs files are created.

Quoted 6 lines

However, it's not necessary to stop the process on failure. Instead, we can continue creating the remaining sysfs files for the other engines. Even if some files fail to be created, the list of engines can still be retrieved by querying i915.

Uh, sysfs is uapi. Either we need it, and it _must_ be there, or it's not needed, and we should delete those files probably.

This is different from debugfs, where failures are consistently ignored because that's the conscious design choice Greg made and wants supported. Because debugfs is optional.

Quoted 5 lines

So please make sure we correctly fail driver load if these don't register. Even better would be if sysfs files are registered atomically as attribute blocks, but that's an entire different can of worms. But that would really clean up this code and essentially put any failure handling onto core driver model and sysfs code.

This comment came after I merged the patch. So far, we have been keeping the driver going even if sysfs fails to create, with the idea of "if there is something wrong let it go as far as it can and fail on its own".

This change is just setting the behavior to what the rest of the interfaces are doing, so that either we change them all to fail the driver's probe or we have them behaving consistently as they are.

Tvrtko, Chris, Rodrigo any opinion from your side? Shall we bail out as Sima is suggesting?

Thanks,
Andi

maintainer
#11 lore raw
Quoted 44 lines · Andi Shyti

Hi Sima,

Quoted 30 lines · Daniel Vetter
Quoted 15 lines · Andi Shyti

The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/.

The process is straightforward: we loop over the UABI engines and for each one, we:

- Create the object.
- Create basic files.
- If the engine supports timeslicing, create timeslice duration files.
- If the engine supports preemption, create preemption-related files.
- Create default value files.

Currently, if any of these steps fail, the process stops, and no further sysfs files are created.

Quoted 6 lines

However, it's not necessary to stop the process on failure. Instead, we can continue creating the remaining sysfs files for the other engines. Even if some files fail to be created, the list of engines can still be retrieved by querying i915.

Uh, sysfs is uapi. Either we need it, and it _must_ be there, or it's not needed, and we should delete those files probably.

This is different from debugfs, where failures are consistently ignored because that's the conscious design choice Greg made and wants supported. Because debugfs is optional.

Quoted 5 lines

So please make sure we correctly fail driver load if these don't register. Even better would be if sysfs files are registered atomically as attribute blocks, but that's an entire different can of worms. But that would really clean up this code and essentially put any failure handling onto core driver model and sysfs code.

This comment came after I merged the patch. So far, we have been keeping the driver going even if sysfs fails to create, with the idea of "if there is something wrong let it go as far as it can and fail on its own".

Quoted 7 lines

This change is just setting the behavior to what the rest of the interfaces are doing, so that either we change them all to fail the driver's probe or we have them behaving consistently as they are.

Tvrtko, Chris, Rodrigo any opinion from your side? Shall we bail out as Sima is suggesting?

Are there any causes for sysfs creation errors that would be acceptable to ignore? I didn't see any examples. Or is this just speculative?

IMO fail fast and loud. We get enough bug reports where there's some big backtrace splash copy-pasted on the bug, but the root cause happened much earlier and was ignored.

BR,
Jani.

Signature · 1 line
Jani Nikula, Intel
maintainer
#12 lore raw
Quoted 50 lines · Jani Nikula
Quoted 49 lines · Andi Shyti

Hi Sima,

Quoted 30 lines · Daniel Vetter
Quoted 15 lines · Andi Shyti

The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/.

The process is straightforward: we loop over the UABI engines and for each one, we:

- Create the object.
- Create basic files.
- If the engine supports timeslicing, create timeslice duration files.
- If the engine supports preemption, create preemption-related files.
- Create default value files.

Currently, if any of these steps fail, the process stops, and no further sysfs files are created.

Quoted 6 lines

However, it's not necessary to stop the process on failure. Instead, we can continue creating the remaining sysfs files for the other engines. Even if some files fail to be created, the list of engines can still be retrieved by querying i915.

Uh, sysfs is uapi. Either we need it, and it _must_ be there, or it's not needed, and we should delete those files probably.

This is different from debugfs, where failures are consistently ignored because that's the conscious design choice Greg made and wants supported. Because debugfs is optional.

Quoted 5 lines

So please make sure we correctly fail driver load if these don't register. Even better would be if sysfs files are registered atomically as attribute blocks, but that's an entire different can of worms. But that would really clean up this code and essentially put any failure handling onto core driver model and sysfs code.

This comment came after I merged the patch. So far, we have been keeping the driver going even if sysfs fails to create, with the idea of "if there is something wrong let it go as far as it can and fail on its own".

This change is just setting the behavior to what the rest of the interfaces are doing, so that either we change them all to fail the driver's probe or we have them behaving consistently as they are.

Quoted 5 lines
Quoted 2 lines

Tvrtko, Chris, Rodrigo any opinion from your side? Shall we bail out as Sima is suggesting?

Are there any causes for sysfs creation errors that would be acceptable to ignore? I didn't see any examples. Or is this just speculative?

I think it is speculative and that the reason for "carry on on failure" was probably simply because there aren't any real world reasons any would ever fail. Either a programming error or kernel out of memory on driver load, and neither of those sounds interesting.

I suspect historically it was probably deemed simpler not to bother with any unwind or such, and that is the only reason i915_setup_sysfs() returns void.

In this context I don't see a big ROI in making someone work on implementing a driver load abort here, but also don't think it would harm.

IMO it would be fine to tie the decision with the fate of dynamic CCS engines. If that will go in then it definitely more than makes sense to propagate all errors to the entity doing the sysfs write.

Regards,

Tvrtko

Quoted 8 lines

IMO fail fast and loud. We get enough bug reports where there's some big backtrace splash copy-pasted on the bug, but the root cause happened much earlier and was ignored.

BR,
Jani.

maintainer
#13 lore raw
In reply to Jani Nikula
Quoted 45 lines · Jani Nikula
Quoted 44 lines · Andi Shyti

Hi Sima,

Quoted 30 lines · Daniel Vetter
Quoted 15 lines · Andi Shyti

The i915 driver generates sysfs entries for each engine of the GPU in /sys/class/drm/cardX/engines/.

The process is straightforward: we loop over the UABI engines and for each one, we:

- Create the object.
- Create basic files.
- If the engine supports timeslicing, create timeslice duration files.
- If the engine supports preemption, create preemption-related files.
- Create default value files.

Currently, if any of these steps fail, the process stops, and no further sysfs files are created.

Quoted 6 lines

However, it's not necessary to stop the process on failure. Instead, we can continue creating the remaining sysfs files for the other engines. Even if some files fail to be created, the list of engines can still be retrieved by querying i915.

Uh, sysfs is uapi. Either we need it, and it _must_ be there, or it's not needed, and we should delete those files probably.

This is different from debugfs, where failures are consistently ignored because that's the conscious design choice Greg made and wants supported. Because debugfs is optional.

Quoted 5 lines

So please make sure we correctly fail driver load if these don't register. Even better would be if sysfs files are registered atomically as attribute blocks, but that's an entire different can of worms. But that would really clean up this code and essentially put any failure handling onto core driver model and sysfs code.

This comment came after I merged the patch. So far, we have been keeping the driver going even if sysfs fails to create, with the idea of "if there is something wrong let it go as far as it can and fail on its own".

Quoted 7 lines
Quoted 7 lines

This change is just setting the behavior to what the rest of the interfaces are doing, so that either we change them all to fail the driver's probe or we have them behaving consistently as they are.

Tvrtko, Chris, Rodrigo any opinion from your side? Shall we bail out as Sima is suggesting?

I agree with Sima. I'm sorry for not having thought about that perspective sooner.

Quoted 3 lines

Are there any causes for sysfs creation errors that would be acceptable to ignore? I didn't see any examples. Or is this just speculative?

Sima's point is, if the driver can live on this speculative scenario, without the sysfs uapi. It is because it is likely a bogus unneded uapi. So, why should we?

I know, if we take all the frequency control in the sysfs. The driver can be fully functional and we would opperate in our variable frequency normally and admin doesn't necessarily need to know or to tweak the frequency. From this perspective, I accepted Andi's patch.

And this isn't a bogus interface. However, if the sysfs failed to be created and suddently the admin depends on that to inspect for a performance case or something and the sysfs is not there.

When he runs his tools everything will fail and this is a bad regression for that case which we shouldn't had caused/accepted to begin with.

So, in this speculative case it is better to stop probing the driver if we are not able to create the sysfs.

Quoted 11 lines

IMO fail fast and loud. We get enough bug reports where there's some big backtrace splash copy-pasted on the bug, but the root cause happened much earlier and was ignored.

BR,
Jani.

Signature · 1 line
Jani Nikula, Intel