Skip to contentSkip to conversation

package/e2fsprogs: allow uclibc toolchains for e4defrag

PATCH Applied Waldemar Brodkorb 2 participants 2 messages Aug 18, 2024 – Aug 19, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/e2fsprogs: allow uclibc toolchains for e4defrag

Since 2014 e4defrag was only available for musl/glibc toolchains in commit d770abad335a85884cfc2ec7574a331c29522810.

I believe sync_file_range() was already available in 2015 in the uClibc time.

So enable e4defrag. Tested in Qemu on a ext4 filesystem.

---
 package/e2fsprogs/Config.in | 5 -----
 1 file changed, 5 deletions(-)
package/e2fsprogs/Config.in +0 -5
index 23c4ef30b3..a45767d506 100644
@@ -47,14 +47,9 @@ comment "e2scrub needs bash, coreutils, lvm2, and util-linux"
 config BR2_PACKAGE_E2FSPROGS_E4DEFRAG
 	bool "e4defrag"
 	depends on !BR2_nios2 # fallocate not implemented
-	depends on !BR2_TOOLCHAIN_USES_UCLIBC # sync_file_range not impl
 	help
 	  Online defragmenter for ext4 filesystem
 
-comment "e4defrag needs a glibc or musl toolchain"
-	depends on !BR2_nios2
-	depends on BR2_TOOLCHAIN_USES_UCLIBC
-
 config BR2_PACKAGE_E2FSPROGS_FSCK
 	bool "fsck"
 	default y
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 11 lines · On Sun, 18 Aug 2024 11:56:51 +0200 Waldemar Brodkorb <[email protected]> wrote:

Since 2014 e4defrag was only available for musl/glibc toolchains in commit d770abad335a85884cfc2ec7574a331c29522810.

I believe sync_file_range() was already available in 2015 in the uClibc time.

So enable e4defrag. Tested in Qemu on a ext4 filesystem.

---
 package/e2fsprogs/Config.in | 5 -----
 1 file changed, 5 deletions(-)

Applied to next, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot