Skip to contentSkip to conversation

ARM: dts: imx28-apx4devkit: Fix the regulator description

PATCH Applied Fabio Estevam 2 participants 2 messages Aug 20, 2024 – Aug 31, 2024

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx28-apx4devkit: Fix the regulator description

From: Fabio Estevam <[email protected]>

The regulator should not be placed under simple-bus.

Remove it from simple-bus to fix the following dt-schema warnings:

'regulators' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
regulators: #size-cells:0:0: 0 is not one of [1, 2]
regulators: regulator@0:reg:0: [0] is too short
regulators: 'ranges' is a required property

---
 .../arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts | 20 +++++++------------
 1 file changed, 7 insertions(+), 13 deletions(-)
arch/arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts +7 -13
index f9bf40d96568..4c4ea91c286f 100644
@@ -11,19 +11,13 @@ memory@40000000 {
 		reg = <0x40000000 0x04000000>;
 	};
 
-	regulators {
-		compatible = "simple-bus";
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		reg_3p3v: regulator@0 {
-			compatible = "regulator-fixed";
-			reg = <0>;
-			regulator-name = "3P3V";
-			regulator-min-microvolt = <3300000>;
-			regulator-max-microvolt = <3300000>;
-			regulator-always-on;
-		};
+
+	reg_3p3v: regulator-3p3v {
+		compatible = "regulator-fixed";
+		regulator-name = "3P3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
 	};
 
 	sound {
Signature · 1 line
2.34.1
Applied
#1 lore raw
Quoted 4 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The regulator should not be placed under simple-bus.

Quoted 8 lines

Remove it from simple-bus to fix the following dt-schema warnings:

'regulators' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
regulators: #size-cells:0:0: 0 is not one of [1, 2]
regulators: regulator@0:reg:0: [0] is too short
regulators: 'ranges' is a required property

Applied, thanks!