Skip to contentSkip to conversation

Revert "drm/ttm: increase ttm pre-fault value to PMD size"

PATCH In review Alex Deucher 3 participants 3 messages Aug 20, 2024 – Aug 23, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "drm/ttm: increase ttm pre-fault value to PMD size"

This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0.

This patch causes sluggishness and stuttering in graphical apps.

---
 include/drm/ttm/ttm_bo.h | 4 ----
 1 file changed, 4 deletions(-)
include/drm/ttm/ttm_bo.h +0 -4
index ef0f52f56ebc..6ccf96c91f3a 100644
@@ -39,11 +39,7 @@
 #include "ttm_device.h"
 
 /* Default number of pre-faulted pages in the TTM fault handler */
-#if CONFIG_PGTABLE_LEVELS > 2
-#define TTM_BO_VM_NUM_PREFAULT (1 << (PMD_SHIFT - PAGE_SHIFT))
-#else
 #define TTM_BO_VM_NUM_PREFAULT 16
-#endif
 
 struct iosys_map;
 
Signature · 1 line
2.46.0
#1 lore raw

Ping?

Quoted 34 lines · Alex Deucher

This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0.

This patch causes sluggishness and stuttering in graphical apps.

---
 include/drm/ttm/ttm_bo.h | 4 ----
 1 file changed, 4 deletions(-)
include/drm/ttm/ttm_bo.h +0 -5
index ef0f52f56ebc..6ccf96c91f3a 100644
@@ -39,11 +39,7 @@
 #include "ttm_device.h"
 
 /* Default number of pre-faulted pages in the TTM fault handler */
-#if CONFIG_PGTABLE_LEVELS > 2
-#define TTM_BO_VM_NUM_PREFAULT (1 << (PMD_SHIFT - PAGE_SHIFT))
-#else
 #define TTM_BO_VM_NUM_PREFAULT 16
-#endif
 
 struct iosys_map;
 
--

2.46.0

Reviewed-by
#2 lore raw

Am 23.08.24 um 15:13 schrieb Alex Deucher:

Quoted 13 lines

Ping?

Quoted 10 lines · Alex Deucher

This reverts commit 0ddd2ae586d28e521d37393364d989ce118802e0.

This patch causes sluggishness and stuttering in graphical apps.

Quoted 23 lines
Quoted 23 lines
---
  include/drm/ttm/ttm_bo.h | 4 ----
  1 file changed, 4 deletions(-)
include/drm/ttm/ttm_bo.h +0 -5
index ef0f52f56ebc..6ccf96c91f3a 100644
@@ -39,11 +39,7 @@
  #include "ttm_device.h"
 
  /* Default number of pre-faulted pages in the TTM fault handler */
-#if CONFIG_PGTABLE_LEVELS > 2
-#define TTM_BO_VM_NUM_PREFAULT (1 << (PMD_SHIFT - PAGE_SHIFT))
-#else
  #define TTM_BO_VM_NUM_PREFAULT 16
-#endif
 
  struct iosys_map;
 
--

2.46.0