Skip to contentSkip to conversation

MAINTAINERS: Networking updates

PATCH Applied Simon Horman 4 participants 10 messages Aug 21, 2024 – Aug 22, 2024

Subsystems (2)
lore
Share & tools
lore

Simon Horman

author reviewer
#0 lore raw

v2 cover MAINTAINERS: Networking updates

Hi,

This series includes Networking-related updates to MAINTAINERS.

* Patches 1-4 aim to assign header files with "*net*' and '*skbuff*' in their name to Networking-related sections within Maintainers.

There are a few such files left over after this patches. I have to sent separate patches to add them to SCSI SUBSYSTEM and NETWORKING DRIVERS (WIRELESS) sections [1][2].

[1] https://lore.kernel.org/linux-scsi/[email protected]/
[2] https://lore.kernel.org/linux-wireless/[email protected]/

* Patch 5 updates the status of the JME driver to 'Odd Fixes'

---
Changes in v2:
- [PATCH 2/5] Add to SOCKET TIMESTAMPING rather than PTP HARDWARE CLOCK SUPPORT section. This seems more appropriate given that include/uapi/linux/net_tstamp.h is already in the SOCKET TIMESTAMPING section.
- [PATCH 3/5] New patch. Use globs to match files in Networking sections. As suggested by Jakub Kicinski
- [PATCH 4/5] Dropped net_shaper.h as it is not present upstream
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Simon Horman (5):
MAINTAINERS: Add sonet.h to ATM section of MAINTAINERS
MAINTAINERS: Add net_tstamp.h to SOCKET TIMESTAMPING section
MAINTAINERS: Add limited globs for Networking headers
MAINTAINERS: Add header files to NETWORKING sections
MAINTAINERS: Mark JME Network Driver as Odd Fixes

 MAINTAINERS | 32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)

base-commit: 0d76fc7e27b2097e18ee128e484d107ed6d45e88

author reviewer
#1 lore raw

PATCH v2 1/5 MAINTAINERS: Add sonet.h to ATM section of MAINTAINERS

This is part of an effort to assign a section in MAINTAINERS to header files that relate to Networking. In this case the files with "net" in their name.

It seems that sonet.h is included in ATM related source files, and thus that ATM is the most relevant section for these files.

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index a964a34651f5..c682203915a2 100644
@@ -3504,7 +3504,9 @@ S:	Maintained
 W:	http://linux-atm.sourceforge.net
 F:	drivers/atm/
 F:	include/linux/atm*
+F:	include/linux/sonet.h
 F:	include/uapi/linux/atm*
+F:	include/uapi/linux/sonet.h
 
 ATMEL MACB ETHERNET DRIVER
 M:	Nicolas Ferre <[email protected]>
Signature · 1 line
2.43.0
author reviewer
#2 lore raw

PATCH v2 2/5 MAINTAINERS: Add net_tstamp.h to SOCKET TIMESTAMPING section

In reply to Simon Horman

This is part of an effort to assign a section in MAINTAINERS to header files that relate to Networking. In this case the files with "net" in their name.

Cc Richard Cochran <[email protected]>
Cc Willem de Bruijn <[email protected]>

---
v2: Add to SOCKET TIMESTAMPING rather than PTP HARDWARE CLOCK SUPPORT
section. This seems more appropriate given that include/uapi/linux/net_tstamp.h is already in the SOCKET TIMESTAMPING section.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index c682203915a2..e5b9a4d9bc21 100644
@@ -21057,6 +21057,7 @@ SOCKET TIMESTAMPING
 M:	Willem de Bruijn <[email protected]>
 S:	Maintained
 F:	Documentation/networking/timestamping.rst
+F:	include/linux/net_tstamp.h
 F:	include/uapi/linux/net_tstamp.h
 F:	tools/testing/selftests/net/so_txtime.c
 
Signature · 1 line
2.43.0
Acked-by on v2 2/5
#3 lore raw

Re: [PATCH net v2 2/5] MAINTAINERS: Add net_tstamp.h to SOCKET TIMESTAMPING section

Quoted 7 lines · Simon Horman

This is part of an effort to assign a section in MAINTAINERS to header files that relate to Networking. In this case the files with "net" in their name.

Cc Richard Cochran <[email protected]>
Cc Willem de Bruijn <[email protected]>
author reviewer
#4 lore raw

PATCH v2 3/5 MAINTAINERS: Add limited globs for Networking headers

In reply to Simon Horman

This aims to add limited globs to improve the coverage of header files in the NETWORKING DRIVERS and NETWORKING [GENERAL] sections.

It is done so in a minimal way to exclude overlap with other sections. And so as not to require "X" entries to exclude files otherwise matched by these new globs.

While imperfect, due to it's limited nature, this does extend coverage of header files by these sections. And aims to automatically cover new files that seem very likely belong to these sections.

The include/linux/netdev* glob (both sections)
+ Subsumes the entries for:
- include/linux/netdevice.h
+ Extends the sections to cover
- include/linux/netdevice_xmit.h
- include/linux/netdev_features.h

The include/uapi/linux/netdev* globs: (both sections)
+ Subsumes the entries for:
- include/linux/netdevice.h
+ Extends the sections to cover
- include/linux/netdev.h

The include/linux/skbuff* glob (NETWORKING [GENERAL] section only):
+ Subsumes the entry for:
- include/linux/skbuff.h
+ Extends the section to cover
- include/linux/skbuff_ref.h

A include/uapi/linux/net_* glob was not added to the NETWORKING [GENERAL] section. Although it would subsume the entry for include/uapi/linux/net_namespace.h, which is fine, it would also extend coverage to:
- include/uapi/linux/net_dropmon.h, which belongs to the NETWORK DROP MONITOR section
- include/uapi/linux/net_tstamp.h which, as per an earlier patch in this series, belongs to the SOCKET TIMESTAMPING section

---
v2:
* New patch

---
 MAINTAINERS | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
MAINTAINERS +5 -5
index e5b9a4d9bc21..03d571b131eb 100644
@@ -15884,10 +15884,10 @@ F:	include/linux/fddidevice.h
 F:	include/linux/hippidevice.h
 F:	include/linux/if_*
 F:	include/linux/inetdevice.h
-F:	include/linux/netdevice.h
+F:	include/linux/netdev*
 F:	include/uapi/linux/cn_proc.h
 F:	include/uapi/linux/if_*
-F:	include/uapi/linux/netdevice.h
+F:	include/uapi/linux/netdev*
 F:	tools/testing/selftests/drivers/net/
 X:	drivers/net/wireless/
 
@@ -15940,13 +15940,13 @@ F:	include/linux/framer/framer.h
 F:	include/linux/in.h
 F:	include/linux/indirect_call_wrapper.h
 F:	include/linux/net.h
-F:	include/linux/netdevice.h
-F:	include/linux/skbuff.h
+F:	include/linux/netdev*
+F:	include/linux/skbuff*
 F:	include/net/
 F:	include/uapi/linux/in.h
 F:	include/uapi/linux/net.h
 F:	include/uapi/linux/net_namespace.h
-F:	include/uapi/linux/netdevice.h
+F:	include/uapi/linux/netdev*
 F:	lib/net_utils.c
 F:	lib/random32.c
 F:	net/
Signature · 1 line
2.43.0
maintainer
#5 lore raw

Re: [PATCH net v2 3/5] MAINTAINERS: Add limited globs for Networking headers

Quoted 30 lines · Simon Horman

This aims to add limited globs to improve the coverage of header files in the NETWORKING DRIVERS and NETWORKING [GENERAL] sections.

It is done so in a minimal way to exclude overlap with other sections. And so as not to require "X" entries to exclude files otherwise matched by these new globs.

While imperfect, due to it's limited nature, this does extend coverage of header files by these sections. And aims to automatically cover new files that seem very likely belong to these sections.

The include/linux/netdev* glob (both sections)
+ Subsumes the entries for:
- include/linux/netdevice.h
+ Extends the sections to cover
- include/linux/netdevice_xmit.h
- include/linux/netdev_features.h

The include/uapi/linux/netdev* globs: (both sections)
+ Subsumes the entries for:
- include/linux/netdevice.h
+ Extends the sections to cover
- include/linux/netdev.h

The include/linux/skbuff* glob (NETWORKING [GENERAL] section only):
+ Subsumes the entry for:
- include/linux/skbuff.h
+ Extends the section to cover
- include/linux/skbuff_ref.h

Quoted 8 lines

A include/uapi/linux/net_* glob was not added to the NETWORKING [GENERAL] section. Although it would subsume the entry for include/uapi/linux/net_namespace.h, which is fine, it would also extend coverage to:
- include/uapi/linux/net_dropmon.h, which belongs to the NETWORK DROP MONITOR section
- include/uapi/linux/net_tstamp.h which, as per an earlier patch in this series, belongs to the SOCKET TIMESTAMPING section

I think both the above files should belong also to the generic networking section. If there is agreement, I think can be adjusted with an incremental patch, instead of re-spinning the whole series - that I'm applying now.

Thanks,

Paolo

author reviewer
#6 lore raw

Re: [PATCH net v2 3/5] MAINTAINERS: Add limited globs for Networking headers

Quoted 40 lines · Paolo Abeni
Quoted 30 lines · Simon Horman

This aims to add limited globs to improve the coverage of header files in the NETWORKING DRIVERS and NETWORKING [GENERAL] sections.

It is done so in a minimal way to exclude overlap with other sections. And so as not to require "X" entries to exclude files otherwise matched by these new globs.

While imperfect, due to it's limited nature, this does extend coverage of header files by these sections. And aims to automatically cover new files that seem very likely belong to these sections.

The include/linux/netdev* glob (both sections)
+ Subsumes the entries for:
- include/linux/netdevice.h
+ Extends the sections to cover
- include/linux/netdevice_xmit.h
- include/linux/netdev_features.h

The include/uapi/linux/netdev* globs: (both sections)
+ Subsumes the entries for:
- include/linux/netdevice.h
+ Extends the sections to cover
- include/linux/netdev.h

The include/linux/skbuff* glob (NETWORKING [GENERAL] section only):
+ Subsumes the entry for:
- include/linux/skbuff.h
+ Extends the section to cover
- include/linux/skbuff_ref.h

Quoted 8 lines

A include/uapi/linux/net_* glob was not added to the NETWORKING [GENERAL] section. Although it would subsume the entry for include/uapi/linux/net_namespace.h, which is fine, it would also extend coverage to:
- include/uapi/linux/net_dropmon.h, which belongs to the NETWORK DROP MONITOR section
- include/uapi/linux/net_tstamp.h which, as per an earlier patch in this series, belongs to the SOCKET TIMESTAMPING section

Quoted 3 lines

I think both the above files should belong also to the generic networking section. If there is agreement, I think can be adjusted with an incremental patch, instead of re-spinning the whole series - that I'm applying now.

Thanks.

I'm quite fine with adding a include/uapi/linux/net_* entry as a follow-up. The reason that I didn't add it is to avoid including files in multiple sections. But if there is consensus around that being ok then I have no objections.

author reviewer
#7 lore raw

PATCH v2 4/5 MAINTAINERS: Add header files to NETWORKING sections

In reply to Simon Horman

This is part of an effort to assign a section in MAINTAINERS to header files that relate to Networking. In this case the files with "net" or "skbuff" in their name.

This patch adds a number of such files to the NETWORKING DRIVERS and NETWORKING [GENERAL] sections.

---
v2:
* Do not add net_shaper.h, it is not present upstream (hopefully soon :)
* Update for new, earlier, patch in series which adds more globs

---
 MAINTAINERS | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
MAINTAINERS +17 -0
index 03d571b131eb..798f1ffcbbaa 100644
@@ -15879,13 +15879,16 @@ F:	drivers/net/
 F:	include/dt-bindings/net/
 F:	include/linux/cn_proc.h
 F:	include/linux/etherdevice.h
+F:	include/linux/ethtool_netlink.h
 F:	include/linux/fcdevice.h
 F:	include/linux/fddidevice.h
 F:	include/linux/hippidevice.h
 F:	include/linux/if_*
 F:	include/linux/inetdevice.h
 F:	include/linux/netdev*
+F:	include/linux/platform_data/wiznet.h
 F:	include/uapi/linux/cn_proc.h
+F:	include/uapi/linux/ethtool_netlink.h
 F:	include/uapi/linux/if_*
 F:	include/uapi/linux/netdev*
 F:	tools/testing/selftests/drivers/net/
@@ -15939,14 +15942,28 @@ F:	include/linux/framer/framer-provider.h
 F:	include/linux/framer/framer.h
 F:	include/linux/in.h
 F:	include/linux/indirect_call_wrapper.h
+F:	include/linux/inet.h
+F:	include/linux/inet_diag.h
 F:	include/linux/net.h
 F:	include/linux/netdev*
+F:	include/linux/netlink.h
+F:	include/linux/netpoll.h
+F:	include/linux/rtnetlink.h
+F:	include/linux/seq_file_net.h
 F:	include/linux/skbuff*
 F:	include/net/
+F:	include/uapi/linux/genetlink.h
+F:	include/uapi/linux/hsr_netlink.h
 F:	include/uapi/linux/in.h
+F:	include/uapi/linux/inet_diag.h
+F:	include/uapi/linux/nbd-netlink.h
 F:	include/uapi/linux/net.h
 F:	include/uapi/linux/net_namespace.h
+F:	include/uapi/linux/netconf.h
 F:	include/uapi/linux/netdev*
+F:	include/uapi/linux/netlink.h
+F:	include/uapi/linux/netlink_diag.h
+F:	include/uapi/linux/rtnetlink.h
 F:	lib/net_utils.c
 F:	lib/random32.c
 F:	net/
Signature · 1 line
2.43.0
author reviewer
#8 lore raw

PATCH v2 5/5 MAINTAINERS: Mark JME Network Driver as Odd Fixes

In reply to Simon Horman

This driver only appears to have received sporadic clean-ups, typically part of some tree-wide activity, and fixes for quite some time. And according to the maintainer, Guo-Fu Tseng, the device has been EOLed for a long time (see Link).

Accordingly, it seems appropriate to mark this driver as odd fixes.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 798f1ffcbbaa..0c94ec0ca478 100644
@@ -11995,7 +11995,7 @@ F:	fs/jfs/
 JME NETWORK DRIVER
 M:	Guo-Fu Tseng <[email protected]>
 L:	[email protected]
-S:	Maintained
+S:	Odd Fixes
 F:	drivers/net/ethernet/jme.*
 
 JOURNALLING FLASH FILE SYSTEM V2 (JFFS2)
Signature · 1 line
2.43.0
#9 lore raw
In reply to Simon Horman
This series was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Wed, 21 Aug 2024 09:46:43 +0100 you wrote:

Hi,

This series includes Networking-related updates to MAINTAINERS.

* Patches 1-4 aim to assign header files with "*net*' and '*skbuff*' in their name to Networking-related sections within Maintainers.

[...]

Here is the summary with links:
- [net,v2,1/5] MAINTAINERS: Add sonet.h to ATM section of MAINTAINERS

    https://git.kernel.org/netdev/net/c/1ac66c4960e1
  - [net,v2,2/5] MAINTAINERS: Add net_tstamp.h to SOCKET TIMESTAMPING section
    https://git.kernel.org/netdev/net/c/eb208fecd77d
  - [net,v2,3/5] MAINTAINERS: Add limited globs for Networking headers
    https://git.kernel.org/netdev/net/c/8cb0a938d90b
  - [net,v2,4/5] MAINTAINERS: Add header files to NETWORKING sections
    https://git.kernel.org/netdev/net/c/f2d20c9b97f0
  - [net,v2,5/5] MAINTAINERS: Mark JME Network Driver as Odd Fixes
    https://git.kernel.org/netdev/net/c/46097a926624

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html