Skip to contentSkip to conversation

gpio: pca953x: Print the error code on read/write failures

PATCH Applied Fabio Estevam 3 participants 6 messages Aug 21, 2024 – Aug 23, 2024 GPIO

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 gpio: pca953x: Print the error code on read/write failures

From: Fabio Estevam <[email protected]>

Print the error code in the pca953x_write_regs() and pca953x_read_regs() functions to help debugging.

Suggested-by Russell King (Oracle) <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/gpio/gpio-pca953x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-pca953x.c +2 -2
index 8baf3edd5274..3f2d33ee20cc 100644
@@ -498,7 +498,7 @@ static int pca953x_write_regs(struct pca953x_chip *chip, int reg, unsigned long
 
 	ret = regmap_bulk_write(chip->regmap, regaddr, value, NBANK(chip));
 	if (ret < 0) {
-		dev_err(&chip->client->dev, "failed writing register\n");
+		dev_err(&chip->client->dev, "failed writing register: %d\n", ret);
 		return ret;
 	}
 

@@ -513,7 +513,7 @@ static int pca953x_read_regs(struct pca953x_chip *chip, int reg, unsigned long *
 
 	ret = regmap_bulk_read(chip->regmap, regaddr, value, NBANK(chip));
 	if (ret < 0) {
-		dev_err(&chip->client->dev, "failed reading register\n");
+		dev_err(&chip->client->dev, "failed reading register: %d\n", ret);
 		return ret;
 	}
Signature · 1 line
2.34.1
#1 lore raw
Quoted 35 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Print the error code in the pca953x_write_regs() and pca953x_read_regs() functions to help debugging.

Suggested-by Russell King (Oracle) <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/gpio/gpio-pca953x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-pca953x.c +2 -3
index 8baf3edd5274..3f2d33ee20cc 100644
@@ -498,7 +498,7 @@ static int pca953x_write_regs(struct pca953x_chip *chip, int reg, unsigned long
 
        ret = regmap_bulk_write(chip->regmap, regaddr, value, NBANK(chip));
        if (ret < 0) {
-               dev_err(&chip->client->dev, "failed writing register\n");
+               dev_err(&chip->client->dev, "failed writing register: %d\n", ret);
                return ret;
        }
 

@@ -513,7 +513,7 @@ static int pca953x_read_regs(struct pca953x_chip *chip, int reg, unsigned long *
 
        ret = regmap_bulk_read(chip->regmap, regaddr, value, NBANK(chip));
        if (ret < 0) {
-               dev_err(&chip->client->dev, "failed reading register\n");
+               dev_err(&chip->client->dev, "failed reading register: %d\n", ret);
                return ret;
        }
 
--
Quoted 2 lines

2.34.1

How about using dev_err_probe() instead?

Bart

author
#2 lore raw

Hi Bartosz,

Quoted 1 line · Bartosz Golaszewski

How about using dev_err_probe() instead?

pca953x_write_regs() and pca953x_read_regs() are not called from probe(), so we should use dev_err().

#3 lore raw
Quoted 9 lines · Fabio Estevam

Hi Bartosz,

Quoted 1 line · Bartosz Golaszewski

How about using dev_err_probe() instead?

pca953x_write_regs() and pca953x_read_regs() are not called from probe(), so we should use dev_err().

Right, sorry for the noise.

Bart

Applied
#4 lore raw
In reply to Fabio Estevam

From: Bartosz Golaszewski <[email protected]>

Quoted 4 lines · Fabio Estevam

Print the error code in the pca953x_write_regs() and pca953x_read_regs() functions to help debugging.

Applied, thanks!

[1/1] gpio: pca953x: Print the error code on read/write failures

      commit: b41a9bf2c64eea119bb6cbef420345f547b9a677

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>
#5 lore raw
In reply to Fabio Estevam
Quoted 2 lines · Fabio Estevam

Print the error code in the pca953x_write_regs() and pca953x_read_regs() functions to help debugging.

May be, or may be better to use (implement?) proper filters for regmap tracepoints? In that case we may drop all these noisy messages and leave only the fatal ones.

Signature · 2 lines
With Best Regards,
Andy Shevchenko