Skip to contentSkip to conversation

usb: gadget: ether: Disable USB pullup in eth probe

PATCH New Zixun LI 1 participant 1 message Aug 22, 2024

lore
Share & tools
lore

Zixun LI

author
#0 lore raw

cover usb: gadget: ether: Disable USB pullup in eth probe

With feedbacks from Marek and a deeper look the patch "usb: gadget: ether:
Handle gadget driver registration in start and stop" doesn't fix the issue in the right way.

We can't keep pullup disabled in udc start and remove usb_gadget_connect from usb_gadget_register_driver since g_dnl doesn't call usb_gadget_connect after driver register (it does call before udc start in which case the controller may be not initialized yet eg. DWC2).

I think fix the issue in usb_ether probe is the simplest way to avoid touch too much things.

Zixun LI (1):
usb: gadget: ether: Disable USB pullup in eth probe

 drivers/usb/gadget/ether.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

--
2.45.2