ndctl.spec.in: enable libtrace{event|fs} support for Fedora
[email protected]
maintainerPATCH 1/1 ndctl.spec.in: enable libtrace{event|fs} support for Fedora
From: Jerry James <[email protected]>
As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2,
the expression "0%{?rhel}" evaluates to zero on Fedora, so the conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less than 9. The result is that ndctl builds for Fedora lack support for libtraceevent and libtracefs. Correct the expression.
Reposted here from github pull request:
https://github.com/pmem/ndctl/pull/266/
--- ndctl.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ndctl.spec.in +1 -1
@@ -10,7 +10,7 @@ Requires: LNAME%{?_isa} = %{version}-%{release} Requires: DAX_LNAME%{?_isa} = %{version}-%{release} Requires: CXL_LNAME%{?_isa} = %{version}-%{release} BuildRequires: autoconf -%if 0%{?rhel} < 9 +%if 0%{?rhel} && 0%{?rhel} < 9 BuildRequires: asciidoc %define asciidoctor -Dasciidoctor=disabled %define libtracefs -Dlibtracefs=disabled
Signature · 1 line
2.37.3
Quoted 8 lines · On Wed, 2024-08-21 at 14:45 -0700, [email protected] wrote:
From: Jerry James <[email protected]>
As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2,
the expression "0%{?rhel}" evaluates to zero on Fedora, so the conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less than 9. The result is that ndctl builds for Fedora lack support for libtraceevent and libtracefs. Correct the expression.
Quoted 4 lines
Reposted here from github pull request:
https://github.com/pmem/ndctl/pull/266/Signed-off-by Jerry James <[email protected]>
Looks good,
Quoted 18 lines
---
ndctl.spec.in | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)ndctl.spec.in +0
-0@@ -10,7 +10,7 @@ Requires: LNAME%{?_isa} = %{version}- %{release} Requires: DAX_LNAME%{?_isa} = %{version}-%{release} Requires: CXL_LNAME%{?_isa} = %{version}-%{release}BuildRequires: autoconf
-%if 0%{?rhel} < 9
+%if 0%{?rhel} && 0%{?rhel} < 9
BuildRequires: asciidoc
%define asciidoctor -Dasciidoctor=disabled
%define libtracefs -Dlibtracefs=disabled
Quoted 8 lines · On 8/21/24 2:45 PM, [email protected] wrote:
From: Jerry James <[email protected]>
As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2,
the expression "0%{?rhel}" evaluates to zero on Fedora, so the conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less than 9. The result is that ndctl builds for Fedora lack support for libtraceevent and libtracefs. Correct the expression.
Quoted 4 lines
Reposted here from github pull request:
https://github.com/pmem/ndctl/pull/266/Signed-off-by Jerry James <[email protected]>
Quoted 17 lines
--- ndctl.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)ndctl.spec.in +1
-1@@ -10,7 +10,7 @@ Requires: LNAME%{?_isa} = %{version}-%{release} Requires: DAX_LNAME%{?_isa} = %{version}-%{release} Requires: CXL_LNAME%{?_isa} = %{version}-%{release} BuildRequires: autoconf -%if 0%{?rhel} < 9 +%if 0%{?rhel} && 0%{?rhel} < 9 BuildRequires: asciidoc %define asciidoctor -Dasciidoctor=disabled %define libtracefs -Dlibtracefs=disabled