Staging: rtl8192e: Fix parenthesis alignment

PATCH Superseded Gabriel Maciel Raad 2 participants 2 messages Aug 22, 2024 Staging

Share & tools

Gabriel Maciel Raad

author

2024-08-22 00:24 UTC #0 lore raw

PATCH 1/1 Staging: rtl8192e: Fix parenthesis alignment

Fix parenthesis alignment and unnecessary blank line in rtl92e_leisure_ps_enter to fix the following checkpatch.pl warnings:

CHECK: Alignment should match open parenthesis
CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by Gabriel Maciel Raad <[email protected]>

---
 drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/staging/rtl8192e/rtl8192e/rtl_ps.c +1 -2

index 5aac9110bff6..7b6247acf6f4 100644
@@ -204,12 +204,11 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
 					&priv->rtllib->pwr_save_ctrl;
 
 	if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
-	    (priv->rtllib->link_state == MAC80211_LINKED)))
+	      (priv->rtllib->link_state == MAC80211_LINKED)))
 		return;
 
 	if (psc->bLeisurePs) {
 		if (psc->lps_idle_count >= RT_CHECK_FOR_HANG_PERIOD) {
-
 			if (priv->rtllib->ps == RTLLIB_PS_DISABLED)
 				_rtl92e_ps_set_mode(dev, RTLLIB_PS_MBCAST | RTLLIB_PS_UNICAST);
 		} else {

Signature · 1 line

2.46.0

Greg Kroah-Hartman

maintainer

2024-08-22 07:49 UTC #1 lore raw

Quoted 5 lines · Gabriel Maciel Raad

Fix parenthesis alignment and unnecessary blank line in rtl92e_leisure_ps_enter to fix the following checkpatch.pl warnings:
CHECK: Alignment should match open parenthesis
CHECK: Blank lines aren't necessary after an open brace '{'

You did two different things here (and one was not mentioned in the subject line.)

Always do one "logical thing" per patch, this should be split up into 2 different onces.

thanks,

greg k-h