Skip to contentSkip to conversation

drm/amd/pm: Drop unsupported features on smu v14_0_2

PATCH In review Candice Li 2 participants 2 messages Aug 22, 2024

Subsystems (3)
lore
Share & tools
lore

Candice Li

author
#0 lore raw

PATCH 1/1 drm/amd/pm: Drop unsupported features on smu v14_0_2

Drop unsupported features on smu v14_0_2.

---
 .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c  | 47 -------------------
 1 file changed, 47 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c +0 -47
index 5913f9c60fe002..391d06cc6e5816 100644
@@ -2115,50 +2115,6 @@ static void smu_v14_0_2_set_smu_mailbox_registers(struct smu_context *smu)
 	smu->debug_resp_reg = SOC15_REG_OFFSET(MP1, 0, regMP1_SMN_C2PMSG_54);
 }
 
-static int smu_v14_0_2_smu_send_bad_mem_page_num(struct smu_context *smu,
-		uint32_t size)
-{
-	int ret = 0;
-
-	/* message SMU to update the bad page number on SMUBUS */
-	ret = smu_cmn_send_smc_msg_with_param(smu,
-					  SMU_MSG_SetNumBadMemoryPagesRetired,
-					  size, NULL);
-	if (ret)
-		dev_err(smu->adev->dev,
-			  "[%s] failed to message SMU to update bad memory pages number\n",
-			  __func__);
-
-	return ret;
-}
-
-static int smu_v14_0_2_send_bad_mem_channel_flag(struct smu_context *smu,
-		uint32_t size)
-{
-	int ret = 0;
-
-	/* message SMU to update the bad channel info on SMUBUS */
-	ret = smu_cmn_send_smc_msg_with_param(smu,
-				  SMU_MSG_SetBadMemoryPagesRetiredFlagsPerChannel,
-				  size, NULL);
-	if (ret)
-		dev_err(smu->adev->dev,
-			  "[%s] failed to message SMU to update bad memory pages channel info\n",
-			  __func__);
-
-	return ret;
-}
-
-static ssize_t smu_v14_0_2_get_ecc_info(struct smu_context *smu,
-					void *table)
-{
-	int ret = 0;
-
-	// TODO
-
-	return ret;
-}
-
 static ssize_t smu_v14_0_2_get_gpu_metrics(struct smu_context *smu,
 					   void **table)
 {
@@ -2897,12 +2853,9 @@ static const struct pptable_funcs smu_v14_0_2_ppt_funcs = {
 	.enable_gfx_features = smu_v14_0_2_enable_gfx_features,
 	.set_mp1_state = smu_v14_0_2_set_mp1_state,
 	.set_df_cstate = smu_v14_0_2_set_df_cstate,
-	.send_hbm_bad_pages_num = smu_v14_0_2_smu_send_bad_mem_page_num,
-	.send_hbm_bad_channel_flag = smu_v14_0_2_send_bad_mem_channel_flag,
 #if 0
 	.gpo_control = smu_v14_0_gpo_control,
 #endif
-	.get_ecc_info = smu_v14_0_2_get_ecc_info,
 };
 
 void smu_v14_0_2_set_ppt_funcs(struct smu_context *smu)
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Candice Li

Drop unsupported features on smu v14_0_2.

Quoted 75 lines
---
 .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c  | 47 -------------------
 1 file changed, 47 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c +0 -48
index 5913f9c60fe002..391d06cc6e5816 100644
@@ -2115,50 +2115,6 @@ static void smu_v14_0_2_set_smu_mailbox_registers(struct smu_context *smu)
        smu->debug_resp_reg = SOC15_REG_OFFSET(MP1, 0, regMP1_SMN_C2PMSG_54);
 }
 
-static int smu_v14_0_2_smu_send_bad_mem_page_num(struct smu_context *smu,
-               uint32_t size)
-{
-       int ret = 0;
-
-       /* message SMU to update the bad page number on SMUBUS */
-       ret = smu_cmn_send_smc_msg_with_param(smu,
-                                         SMU_MSG_SetNumBadMemoryPagesRetired,
-                                         size, NULL);
-       if (ret)
-               dev_err(smu->adev->dev,
-                         "[%s] failed to message SMU to update bad memory pages number\n",
-                         __func__);
-
-       return ret;
-}
-
-static int smu_v14_0_2_send_bad_mem_channel_flag(struct smu_context *smu,
-               uint32_t size)
-{
-       int ret = 0;
-
-       /* message SMU to update the bad channel info on SMUBUS */
-       ret = smu_cmn_send_smc_msg_with_param(smu,
-                                 SMU_MSG_SetBadMemoryPagesRetiredFlagsPerChannel,
-                                 size, NULL);
-       if (ret)
-               dev_err(smu->adev->dev,
-                         "[%s] failed to message SMU to update bad memory pages channel info\n",
-                         __func__);
-
-       return ret;
-}
-
-static ssize_t smu_v14_0_2_get_ecc_info(struct smu_context *smu,
-                                       void *table)
-{
-       int ret = 0;
-
-       // TODO
-
-       return ret;
-}
-
 static ssize_t smu_v14_0_2_get_gpu_metrics(struct smu_context *smu,
                                           void **table)
 {
@@ -2897,12 +2853,9 @@ static const struct pptable_funcs smu_v14_0_2_ppt_funcs = {
        .enable_gfx_features = smu_v14_0_2_enable_gfx_features,
        .set_mp1_state = smu_v14_0_2_set_mp1_state,
        .set_df_cstate = smu_v14_0_2_set_df_cstate,
-       .send_hbm_bad_pages_num = smu_v14_0_2_smu_send_bad_mem_page_num,
-       .send_hbm_bad_channel_flag = smu_v14_0_2_send_bad_mem_channel_flag,
 #if 0
        .gpo_control = smu_v14_0_gpo_control,
 #endif
-       .get_ecc_info = smu_v14_0_2_get_ecc_info,
 };
 
 void smu_v14_0_2_set_ppt_funcs(struct smu_context *smu)
--

2.25.1