Skip to contentSkip to conversation

linux-next: build warning after merge of the rpmsg tree

DISCUSSION Stephen Rothwell 3 participants 10 messages Aug 22, 2024 – Sep 18, 2024 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the rpmsg tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [m]:
- TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Probably introduced by commit

ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw

Hi all,

Quoted 4 lines · On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <[email protected]>…

After merging the rpmsg tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

Quoted 8 lines

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [m]:
- TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Probably introduced by commit

ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

I am still seeing this warning.

Signature · 2 lines
Cheers,
Stephen Rothwell
#2 lore raw
Quoted 14 lines · Stephen Rothwell

Hi all,

Quoted 10 lines · On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <[email protected]>…

After merging the rpmsg tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [m]:
  - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Quoted 7 lines
Quoted 4 lines

Probably introduced by commit

  ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

I am still seeing this warning.

OK, just taken a look into this. I think the issue is the result of the inclusion of COMPILE_TEST in the Kconfig entry:

  config TI_K3_M4_REMOTEPROC
         tristate "TI K3 M4 remoteproc support"
         depends on ARCH_K3 || COMPILE_TEST
         select MAILBOX
         select OMAP2PLUS_MBOX
  ...

Looking at the entry for OMAP2PLUS_MBOX, that doesn't have COMPILE_TEST listed under it's dependencies:

  config OMAP2PLUS_MBOX
          tristate "OMAP2+ Mailbox framework support"
          depends on ARCH_OMAP2PLUS || ARCH_K3
  ...

If I understand right, either the COMPILE_TEST needs to be removed from TI_K3_M4_REMOTEPROC or added to OMAP2PLUS_MBOX.

It appears that the OMAP2+ Mailbox support can at least be compiled on x86_64. so I assume the correct thing to do here is to enable that right?

Jassi, I assume there's not specific reason for the OMAP2+ Mailbox framework support not having COMPILE_TEST, other than potentially being added just before it was a thing?

Martyn

#3 lore raw
Quoted 45 lines · Martyn Welch
Quoted 14 lines · Stephen Rothwell

Hi all,

Quoted 10 lines · On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <[email protected]>…

After merging the rpmsg tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [m]:
- TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 ||
COMPILE_TEST [=y])

Quoted 7 lines
Quoted 4 lines

Probably introduced by commit

ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F
subsystem")

I am still seeing this warning.

OK, just taken a look into this. I think the issue is the result of the inclusion of COMPILE_TEST in the Kconfig entry:

  config TI_K3_M4_REMOTEPROC
         tristate "TI K3 M4 remoteproc support"
         depends on ARCH_K3 || COMPILE_TEST
         select MAILBOX
         select OMAP2PLUS_MBOX
  ...

Looking at the entry for OMAP2PLUS_MBOX, that doesn't have COMPILE_TEST listed under it's dependencies:

  config OMAP2PLUS_MBOX
          tristate "OMAP2+ Mailbox framework support"
          depends on ARCH_OMAP2PLUS || ARCH_K3
  ...

If I understand right, either the COMPILE_TEST needs to be removed from TI_K3_M4_REMOTEPROC or added to OMAP2PLUS_MBOX.

Quoted 8 lines

It appears that the OMAP2+ Mailbox support can at least be compiled on x86_64. so I assume the correct thing to do here is to enable that right?

Jassi, I assume there's not specific reason for the OMAP2+ Mailbox framework support not having COMPILE_TEST, other than potentially being added just before it was a thing?

Seems like it.

-j

#4 lore raw
In reply to Stephen Rothwell

Hi all,

Quoted 11 lines · On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell <[email protected]>…
Quoted 9 lines · On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <[email protected]>…

After merging the rpmsg tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [m]:
- TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Quoted 5 lines
Quoted 3 lines

Probably introduced by commit

ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

I am still seeing this warning.

I am still getting this warning.

Signature · 2 lines
Cheers,
Stephen Rothwell
#5 lore raw
Quoted 17 lines · Stephen Rothwell

Hi all,

Quoted 13 lines · On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell <[email protected]>…
Quoted 10 lines · On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <[email protected]>…

After merging the rpmsg tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [m]:
  - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines

Probably introduced by commit

  ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

I am still seeing this warning.

I am still getting this warning.

Hi Stephen,

I believe this is the required fix, but I believe it's waiting for review/merging:

https://lore.kernel.org/all/010201919d8b298f-dd1585dd-7c4d-4865-9483-ff6cd7399a90-000000@eu-west-1.amazonses.com/

Martyn

#6 lore raw

Hi all,

Quoted 19 lines · On Fri, 06 Sep 2024 09:58:23 +0100 Martyn Welch <[email protected]>…
Quoted 17 lines · Stephen Rothwell
Quoted 15 lines · On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell <[email protected]>…
Quoted 12 lines · On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <[email protected]>…

After merging the rpmsg tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [m]:
  - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Probably introduced by commit

  ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

I am still seeing this warning.

I am still getting this warning.

I believe this is the required fix, but I believe it's waiting for review/merging:

https://lore.kernel.org/all/010201919d8b298f-dd1585dd-7c4d-4865-9483-ff6cd7399a90-000000@eu-west-1.amazonses.com/

I am still getting this warning.

Signature · 2 lines
Cheers,
Stephen Rothwell
Acked-by
#7 lore raw
Quoted 25 lines · Stephen Rothwell

Hi all,

Quoted 21 lines · On Fri, 06 Sep 2024 09:58:23 +0100 Martyn Welch <[email protected]>…
Quoted 19 lines · Stephen Rothwell
Quoted 16 lines · On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell <[email protected]>…
Quoted 4 lines · On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <[email protected]>…

After merging the rpmsg tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

Quoted 8 lines

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [m]:
- TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Probably introduced by commit

ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

I am still seeing this warning.

Quoted 9 lines
Quoted 6 lines
Quoted 1 line

I am still getting this warning.

I believe this is the required fix, but I believe it's waiting for review/merging:

https://lore.kernel.org/all/010201919d8b298f-dd1585dd-7c4d-4865-9483-ff6cd7399a90-000000@eu-west-1.amazonses.com/

I am still getting this warning.

This https://lore.kernel.org/lkml/[email protected]/T/#u
seems like a more complete solution.

I am ok if it goes through TI or another tree.

#8 lore raw
Quoted 45 lines · Jassi Brar
Quoted 35 lines · Stephen Rothwell

Hi all,

Quoted 30 lines · On Fri, 06 Sep 2024 09:58:23 +0100 Martyn Welch <[email protected]>…
Quoted 27 lines · Stephen Rothwell
Quoted 16 lines · On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell <[email protected]>…
Quoted 13 lines · On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <[email protected]>…

After merging the rpmsg tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
  Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
  Selected by [m]:
  - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Quoted 6 lines
Quoted 4 lines

Probably introduced by commit

  ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

I am still seeing this warning.

I am still getting this warning.

Quoted 8 lines
Quoted 5 lines

I believe this is the required fix, but I believe it's waiting for
review/merging:

https://lore.kernel.org/all/010201919d8b298f-dd1585dd-7c4d-4865-9483-ff6cd7399a90-000000@eu-west-1.amazonses.com/

I am still getting this warning.

Quoted 7 lines

 This
https://lore.kernel.org/lkml/[email protected]/T/#u
  seems like a more complete solution.

I am ok if it goes through TI or another tree.

That solution works for me.

Martyn

#9 lore raw
In reply to Stephen Rothwell

Hi all,

Quoted 11 lines · On Wed, 28 Aug 2024 15:09:00 +1000 Stephen Rothwell <[email protected]>…
Quoted 9 lines · On Thu, 22 Aug 2024 14:26:03 +1000 Stephen Rothwell <[email protected]>…

After merging the rpmsg tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [m]:
- TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Quoted 5 lines
Quoted 3 lines

Probably introduced by commit

ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")

I am still seeing this warning.

I am still seeing this warning.

Signature · 2 lines
Cheers,
Stephen Rothwell