Skip to contentSkip to conversation

Fix for lightup issue on Lenovo 4k60 HDMI

PATCH In review Fangzhi Zuo 3 participants 5 messages Aug 22, 2024 – Aug 27, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Fix for lightup issue on Lenovo 4k60 HDMI

338567d176 ("drm/amd/display: Fix MST BW calculation Regression") has been merged with a mistake being fixed by "drm/amd/display: Fix a mistake in revert commit"

Fix dsc enablement for Synaptics Cascaded Panamera hub is included in "drm/amd/display: Fix Synaptics Cascaded DSC Determination"

Please apply the two patches on
https://gitlab.freedesktop.org/agd5f/linux/-/commits/amd-staging-drm-next,
and give a sanity test on 4k60 over Lenovo HDMI output.

Fangzhi Zuo (2):
drm/amd/display: Fix a mistake in revert commit drm/amd/display: Fix Synaptics Cascaded DSC Determination

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 drm/amd/display: Fix a mistake in revert commit

[why]
It is to fix in try_disable_dsc() due to misrevert patch of "drm/amd/display: Fix MST BW calculation Regression"

[How]
Fix restoring minimum compression bw by 'max_kbps', instead of native bw 'stream_kbps'

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +1 -1
index 958fad0d5307..5e08ca700c3f 100644
@@ -1066,7 +1066,7 @@ static int try_disable_dsc(struct drm_atomic_state *state,
 			vars[next_index].dsc_enabled = false;
 			vars[next_index].bpp_x16 = 0;
 		} else {
-			vars[next_index].pbn = kbps_to_peak_pbn(params[next_index].bw_range.stream_kbps, fec_overhead_multiplier_x1000);
+			vars[next_index].pbn = kbps_to_peak_pbn(params[next_index].bw_range.max_kbps, fec_overhead_multiplier_x1000);
 			ret = drm_dp_atomic_find_time_slots(state,
 							    params[next_index].port->mgr,
 							    params[next_index].port,
Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/2 drm/amd/display: Fix Synaptics Cascaded DSC Determination

In reply to Fangzhi Zuo

Synaptics Cascaded Panamera topology needs to unconditionally acquire root aux for dsc decoding.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +1 -1
index 5e08ca700c3f..b77ecf3fb60c 100644
@@ -252,7 +252,7 @@ static bool validate_dsc_caps_on_connector(struct amdgpu_dm_connector *aconnecto
 		aconnector->dsc_aux = &aconnector->mst_root->dm_dp_aux.aux;
 
 	/* synaptics cascaded MST hub case */
-	if (!aconnector->dsc_aux && is_synaptics_cascaded_panamera(aconnector->dc_link, port))
+	if (is_synaptics_cascaded_panamera(aconnector->dc_link, port))
 		aconnector->dsc_aux = port->mgr->aux;
 
 	if (!aconnector->dsc_aux)
Signature · 1 line
2.34.1
Tested-by on the v1 series
#3 lore raw
In reply to Fangzhi Zuo
Quoted 9 lines · Fangzhi Zuo

338567d176 ("drm/amd/display: Fix MST BW calculation Regression") has been merged with a mistake being fixed by "drm/amd/display: Fix a mistake in revert commit"

Fix dsc enablement for Synaptics Cascaded Panamera hub is included in "drm/amd/display: Fix Synaptics Cascaded DSC Determination"

Please apply the two patches on
https://gitlab.freedesktop.org/agd5f/linux/-/commits/amd-staging-drm-next,
and give a sanity test on 4k60 over Lenovo HDMI output.

For both of them:

thanks,

Signature · 2 lines
js
suse labs
Reviewed-by on the v1 series
#4 lore raw
In reply to Fangzhi Zuo
Quoted 10 lines · Fangzhi Zuo

338567d176 ("drm/amd/display: Fix MST BW calculation Regression") has been merged with a mistake being fixed by "drm/amd/display: Fix a mistake in revert commit"

Fix dsc enablement for Synaptics Cascaded Panamera hub is included in "drm/amd/display: Fix Synaptics Cascaded DSC Determination"

Please apply the two patches on
https://gitlab.freedesktop.org/agd5f/linux/-/commits/amd-staging-drm-next,
and give a sanity test on 4k60 over Lenovo HDMI output.

Quoted 7 lines

Fangzhi Zuo (2):
drm/amd/display: Fix a mistake in revert commit drm/amd/display: Fix Synaptics Cascaded DSC Determination

  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

--

Thanks & Regards,
Aurabindo Pillai