Skip to contentSkip to conversation

nvme: use better description for async reset reason

PATCH In review Keith Busch 4 participants 4 messages Aug 22, 2024 – Aug 25, 2024 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme: use better description for async reset reason

From: Keith Busch <[email protected]>

The NVMe AER notification of a persistent internal error triggers a reset. The existing warning message just says "due to AER", which can be confused with the unlreated PCIe AER condition. Just say what the event was instead of the generic overloaded acronym.

---
 drivers/nvme/host/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/nvme/host/core.c +2 -1
index 33fa01c599add..8ef64cb2c26a9 100644
@@ -4437,7 +4437,8 @@ static bool nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)
 
 static void nvme_handle_aer_persistent_error(struct nvme_ctrl *ctrl)
 {
-	dev_warn(ctrl->device, "resetting controller due to AER\n");
+	dev_warn(ctrl->device,
+		"resetting controller due to persistent internal error\n");
 	nvme_reset_ctrl(ctrl);
 }
 
Signature · 1 line
2.43.5
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Keith Busch

From: Keith Busch <[email protected]>

The NVMe AER notification of a persistent internal error triggers a reset. The existing warning message just says "due to AER", which can be confused with the unlreated PCIe AER condition. Just say what the event was instead of the generic overloaded acronym.

Looks good:

Reviewed-by on v1 1/1
#2 lore raw
In reply to Keith Busch
Quoted 8 lines · Keith Busch

From: Keith Busch<[email protected]>

The NVMe AER notification of a persistent internal error triggers a reset. The existing warning message just says "due to AER", which can be confused with the unlreated PCIe AER condition. Just say what the event was instead of the generic overloaded acronym.

Looks good.

-ck