Skip to contentSkip to conversation

staging: rtl8192e: Fix parenthesis alignment

PATCH In review Gabriel Tassinari 2 participants 2 messages Aug 24, 2024 – Aug 26, 2024 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192e: Fix parenthesis alignment

fix parenthesis alignment in _rtl92e_qos_handle_probe_response to silence checkpatch warning:

CHECK: Alignment should match open parenthesis

---
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +1 -1
index ad21263e725f..18739583f579 100644
@@ -322,7 +322,7 @@ static int _rtl92e_qos_handle_probe_response(struct r8192_priv *priv,
 
 	if (network->flags & NETWORK_HAS_QOS_MASK) {
 		if (active_network &&
-				(network->flags & NETWORK_HAS_QOS_PARAMETERS))
+		   (network->flags & NETWORK_HAS_QOS_PARAMETERS))
 			network->qos_data.active = network->qos_data.supported;
 
 		if ((network->qos_data.active == 1) && (active_network == 1) &&
Signature · 1 line
2.46.0
#1 lore raw
Quoted 15 lines · Gabriel Tassinari

fix parenthesis alignment in _rtl92e_qos_handle_probe_response to silence checkpatch warning:

CHECK: Alignment should match open parenthesis

---
  drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +0 -0
index ad21263e725f..18739583f579 100644

drivers/staging/rtl8192e/rtl8192e/rtl_core.c static int _rtl92e_qos_handle_probe_response(struct r8192_priv *priv, · line 328

Quoted 8 lines
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +1 -1
@@ -322,7 +322,7 @@ static int _rtl92e_qos_handle_probe_response(struct r8192_priv *priv,
 
  	if (network->flags & NETWORK_HAS_QOS_MASK) {
  		if (active_network &&
-				(network->flags & NETWORK_HAS_QOS_PARAMETERS))
+		   (network->flags & NETWORK_HAS_QOS_PARAMETERS))
  			network->qos_data.active = network->qos_data.supported;
 
  		if ((network->qos_data.active == 1) && (active_network == 1) &&

Hi Gabriel,

Please make your "Subject" line more unique. Consider that we may end up with having dozen of commits like yours, all of them referring to different removals and all without the necessary information to tell what they differ in (except the driver/subsystem). So it would help if you add the changed file or function to make it more unique.

If you send in a second version of this patch please use a change history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Thanks for your support.

Bye Philipp