Skip to contentSkip to conversation

toolchain:uclibc-ng:enable gnu hash for non mips platforms

PATCH In review Hans Ulli Kroll 2 participants 2 messages Aug 25, 2024 – Aug 26, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain:uclibc-ng:enable gnu hash for non mips platforms

In toolchain-wrapper.mk we use both sysv and gnu hash style for all platforms, except MIPS which uses sysv only.

However uClibc-ng has some extra knob to enable gnu hash via Kconfig, which is set by default off.

This leads to wrong symbol resolving on armv5 and output of devices, here on Pogoplug 4 detected with lcpci 3.10.

---
 package/uclibc/uclibc.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/uclibc/uclibc.mk +7 -0
index de834bac4f..f48ebe6a16 100644
@@ -205,6 +205,12 @@ define UCLIBC_X86_TYPE_CONFIG
 endef
 endif
 
+ifneq ($(UCLIBC_TARGET_ARCH),mips)
+define UCLIBC_LDSO_GNU_HASH_SUPPORT
+	$(call KCONFIG_ENABLE_OPT,LDSO_GNU_HASH_SUPPORT)
+endef
+endif
+
 #
 # Debug
 #
@@ -403,6 +409,7 @@ define UCLIBC_KCONFIG_FIXUP_CMDS
 	$(UCLIBC_SH_TYPE_CONFIG)
 	$(UCLIBC_SPARC_TYPE_CONFIG)
 	$(UCLIBC_POWERPC_TYPE_CONFIG)
+	$(UCLIBC_LDSO_GNU_HASH_SUPPORT)
 	$(UCLIBC_X86_TYPE_CONFIG)
 	$(UCLIBC_DEBUG_CONFIG)
 	$(UCLIBC_ENDIAN_CONFIG)
Signature · 6 lines
2.46.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by on v1 1/1
#1 lore raw

Hi,

the subject must be changed to "package/uclibc: enable gnu hash for non mips"

Hans Ulli Kroll wrote,

Quoted 41 lines

In toolchain-wrapper.mk we use both sysv and gnu hash style for all platforms, except MIPS which uses sysv only.

However uClibc-ng has some extra knob to enable gnu hash via Kconfig, which is set by default off.

This leads to wrong symbol resolving on armv5 and output of devices, here on Pogoplug 4 detected with lcpci 3.10.

---
 package/uclibc/uclibc.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/uclibc/uclibc.mk +7 -0
index de834bac4f..f48ebe6a16 100644
@@ -205,6 +205,12 @@ define UCLIBC_X86_TYPE_CONFIG
 endef
 endif
 
+ifneq ($(UCLIBC_TARGET_ARCH),mips)
+define UCLIBC_LDSO_GNU_HASH_SUPPORT
+	$(call KCONFIG_ENABLE_OPT,LDSO_GNU_HASH_SUPPORT)
+endef
+endif
+
 #
 # Debug
 #
@@ -403,6 +409,7 @@ define UCLIBC_KCONFIG_FIXUP_CMDS
 	$(UCLIBC_SH_TYPE_CONFIG)
 	$(UCLIBC_SPARC_TYPE_CONFIG)
 	$(UCLIBC_POWERPC_TYPE_CONFIG)
+	$(UCLIBC_LDSO_GNU_HASH_SUPPORT)
 	$(UCLIBC_X86_TYPE_CONFIG)
 	$(UCLIBC_DEBUG_CONFIG)
 	$(UCLIBC_ENDIAN_CONFIG)
Signature · 1 line
2.46.0

The rest looks good to me.

best regards
Waldemar

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot