i3c/master: cmd_v1: Fix the rule for getting i3c mode
PATCH 1/1 i3c/master: cmd_v1: Fix the rule for getting i3c mode
Based on the I3C TCRI specification, the rules for determining the I3C mode are as follows:
I3C SCL rate > 8MHz: use SDR0, with a maximum data rate of 8MHz I3C SCL rate > 6MHz: use SDR1, with a maximum data rate of 6MHz I3C SCL rate > 4MHz: use SDR2, with a maximum data rate of 4MHz I3C SCL rate > 2MHz: use SDR3, with a maximum data rate of 2MHz Otherwise, use SDR4
--- drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/i3c/master/mipi-i3c-hci/cmd_v1.c +5 -7
@@ -123,17 +123,15 @@ static enum hci_cmd_mode get_i3c_mode(struct i3c_hci *hci) {struct i3c_bus *bus =i3c_master_get_bus (&hci->master); -if (bus->scl_rate.i3c >=12500000 ) -return MODE_I3C_SDR0 ;if (bus->scl_rate.i3c >8000000 ) -return MODE_I3C_SDR1 ; +return MODE_I3C_SDR0 ;if (bus->scl_rate.i3c >6000000 ) -return MODE_I3C_SDR2 ; +return MODE_I3C_SDR1 ;if (bus->scl_rate.i3c >4000000 ) -return MODE_I3C_SDR3 ; +return MODE_I3C_SDR2 ;if (bus->scl_rate.i3c >2000000 ) -return MODE_I3C_SDR4 ; -return MODE_I3C_Fm_FmP; +return MODE_I3C_SDR3 ; +return MODE_I3C_SDR4 ; }static enum hci_cmd_mode get_i2c_mode (struct i3c_hci *hci)
Signature · 7 lines
2.25.1 -- linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c
Quoted 7 lines
Based on the I3C TCRI specification, the rules for determining the I3C mode are as follows:
I3C SCL rate > 8MHz: use SDR0, with a maximum data rate of 8MHz I3C SCL rate > 6MHz: use SDR1, with a maximum data rate of 6MHz I3C SCL rate > 4MHz: use SDR2, with a maximum data rate of 4MHz I3C SCL rate > 2MHz: use SDR3, with a maximum data rate of 2MHz Otherwise, use SDR4
Sorry, the description of the commit message is wrong.
I will change it to
I3C SCL rate > 8MHz: use SDR0, as SDR1 has a maximum data rate of 8MHz I3C SCL rate > 6MHz: use SDR1, as SDR2 has a maximum data rate of 8MHz I3C SCL rate > 4MHz: use SDR2, as SDR3 has a maximum data rate of 8MHz I3C SCL rate > 2MHz: use SDR3, as SDR4 has a maximum data rate of 8MHz I3C SCL rate <= 2MHz: use SDR4
and send the v2 patch
Hi Billy,
Quoted 8 lines · Billy Tsai
Quoted 7 lines
Based on the I3C TCRI specification, the rules for determining the I3C mode are as follows:
I3C SCL rate > 8MHz: use SDR0, with a maximum data rate of 8MHz I3C SCL rate > 6MHz: use SDR1, with a maximum data rate of 6MHz I3C SCL rate > 4MHz: use SDR2, with a maximum data rate of 4MHz I3C SCL rate > 2MHz: use SDR3, with a maximum data rate of 2MHz Otherwise, use SDR4
Quoted 8 lines
Sorry, the description of the commit message is wrong.
I will change it to
I3C SCL rate > 8MHz: use SDR0, as SDR1 has a maximum data rate of 8MHz I3C SCL rate > 6MHz: use SDR1, as SDR2 has a maximum data rate of 8MHz I3C SCL rate > 4MHz: use SDR2, as SDR3 has a maximum data rate of 8MHz I3C SCL rate > 2MHz: use SDR3, as SDR4 has a maximum data rate of 8MHz I3C SCL rate <= 2MHz: use SDR4
and send the v2 patch
Seems some typo errors, you mentioned all the modes having maximum data rate of 8MHz. "has a maximum data rate of 8MHz"
I3C TCRI Specification (in [MIPI06] Section 7.1.1.1) :
MODE Listed Speed Maximum Sustainable Data Rate0x0 I3C SDR0 12.5 MHz, Standard SDR Speed, fSCL Max0x1 I3C SDR1 8 MHz0x2 I3C SDR2 6 MHz0x3 I3C SDR3 4 MHz0x4 I3C SDR4 2 MHz
Quoted 9 lines · Billy Tsai
Based on the I3C TCRI specification, the rules for determining the I3C mode are as follows:
I3C SCL rate > 8MHz: use SDR0, with a maximum data rate of 8MHz I3C SCL rate > 6MHz: use SDR1, with a maximum data rate of 6MHz I3C SCL rate > 4MHz: use SDR2, with a maximum data rate of 4MHz I3C SCL rate > 2MHz: use SDR3, with a maximum data rate of 2MHz Otherwise, use SDR4[...]
Applied, after fixing the commit log
[1/1] i3c/master: cmd_v1: Fix the rule for getting i3c mode
https://git.kernel.org/abelloni/c/061dd21ca712
Best regards,
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com