Add luma 16-bit interlaced pixel format
Subsystems (3)
cover Add luma 16-bit interlaced pixel format
The formats added by this patch are:
V4L2_PIX_FMT_Y16I
UVC_GUID_FORMAT_Y16IInterlaced lumina format primary use in RealSense Depth cameras with stereo stream for left and right image sensors.
Dmitry Perchanov (2):
v4l: Add luma 16-bit interlaced pixel format
uvc: Add luma 16-bit interlaced pixel format
.../userspace-api/media/v4l/pixfmt-y16i.rst | 74 +++++++++++++++++++ .../userspace-api/media/v4l/yuv-formats.rst | 1 + drivers/media/common/uvc.c | 4 + drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/linux/usb/uvc.h | 3 + include/uapi/linux/videodev2.h | 1 + 6 files changed, 84 insertions(+) create mode 100644 Documentation/userspace-api/media/v4l/pixfmt-y16i.rst
Signature · 1 line
2.43.0
PATCH 1/2 v4l: Add luma 16-bit interlaced pixel format
The formats added by this patch are:
V4L2_PIX_FMT_Y16I
Interlaced lumina format primary use in RealSense Depth cameras with stereo stream for left and right image sensors.
--- .../userspace-api/media/v4l/pixfmt-y16i.rst | 74 +++++++++++++++++++ .../userspace-api/media/v4l/yuv-formats.rst | 1 + drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 4 files changed, 77 insertions(+) create mode 100644 Documentation/userspace-api/media/v4l/pixfmt-y16i.rst
Documentation/userspace-api/media/v4l/pixfmt-y16i.rst new file +74 -0
@@ -0,0 +1,74 @@ +.. SPDX-License-Identifier: GFDL-1.1-no-invariants-or-later + +.. _V4L2-PIX-FMT-Y16I: + +************************** +V4L2_PIX_FMT_Y16I ('Y16I') +************************** + +Interleaved grey-scale image, e.g. from a stereo-pair + + +Description +=========== + +This is a grey-scale image with a depth of 16 bits per pixel, but with +pixels from 2 sources interleaved and unpacked. Each pixel is stored +in a 16-bit word in the little-endian order. +The first pixel is from the left source. + +**Pixel unpacked representation.** +Left/Right pixels 16-bit unpacked - 16-bit for each interleaved pixel. + +.. flat-table:: + :header-rows: 0 + :stub-columns: 0 + + * - Y'\ :sub:`0L[7:0]` + - Y'\ :sub:`0L[15:8]` + - Y'\ :sub:`0R[7:0]` + - Y'\ :sub:`0R[15:8]` + +**Byte Order.** +Each cell is one byte. + +.. flat-table:: + :header-rows: 0 + :stub-columns: 0 + + * - start + 0: + - Y'\ :sub:`00Llow` + - Y'\ :sub:`00Lhigh` + - Y'\ :sub:`00Rlow` + - Y'\ :sub:`00Rhigh` + - Y'\ :sub:`01Llow` + - Y'\ :sub:`01Lhigh` + - Y'\ :sub:`01Rlow` + - Y'\ :sub:`01Rhigh` + * - start + 8: + - Y'\ :sub:`10Llow` + - Y'\ :sub:`10Lhigh` + - Y'\ :sub:`10Rlow` + - Y'\ :sub:`10Rhigh` + - Y'\ :sub:`11Llow` + - Y'\ :sub:`11Lhigh` + - Y'\ :sub:`11Rlow` + - Y'\ :sub:`11Rhigh` + * - start + 16: + - Y'\ :sub:`20Llow` + - Y'\ :sub:`20Lhigh` + - Y'\ :sub:`20Rlow` + - Y'\ :sub:`20Rhigh` + - Y'\ :sub:`21Llow` + - Y'\ :sub:`21Lhigh` + - Y'\ :sub:`21Rlow` + - Y'\ :sub:`21Rhigh` + * - start + 24: + - Y'\ :sub:`30Llow` + - Y'\ :sub:`30Lhigh` + - Y'\ :sub:`30Rlow` + - Y'\ :sub:`30Rhigh` + - Y'\ :sub:`31Llow` + - Y'\ :sub:`31Lhigh` + - Y'\ :sub:`31Rlow` + - Y'\ :sub:`31Rhigh`
Documentation/userspace-api/media/v4l/yuv-formats.rst +1 -0
@@ -269,5 +269,6 @@ image. pixfmt-yuv-luma pixfmt-y8i pixfmt-y12i + pixfmt-y16i pixfmt-uv8 pixfmt-m420
drivers/media/v4l2-core/v4l2-ioctl.c +1 -0
@@ -1327,6 +1327,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)case V4L2_PIX_FMT_Y14P : descr ="14-bit Greyscale (MIPI Packed)" ;break ;case V4L2_PIX_FMT_Y8I : descr ="Interleaved 8-bit Greyscale" ;break ;case V4L2_PIX_FMT_Y12I : descr ="Interleaved 12-bit Greyscale" ;break ; +case V4L2_PIX_FMT_Y16I : descr ="Interleaved 16-bit Greyscale" ;break ;case V4L2_PIX_FMT_Z16 : descr ="16-bit Depth" ;break ;case V4L2_PIX_FMT_INZI : descr ="Planar 10:16 Greyscale Depth" ;break ;case V4L2_PIX_FMT_CNF4 : descr ="4-bit Depth Confidence (Packed)" ;break ;
include/uapi/linux/videodev2.h +1 -0
@@ -797,6 +797,7 @@ struct v4l2_pix_format {#define V4L2_PIX_FMT_S5C_UYVY_JPG v4l2_fourcc('S', '5', 'C', 'I')/* S5C73M3 interleaved UYVY/JPEG */ #define V4L2_PIX_FMT_Y8I v4l2_fourcc('Y', '8', 'I', ' ')/* Greyscale 8-bit L/R interleaved */ #define V4L2_PIX_FMT_Y12I v4l2_fourcc('Y', '1', '2', 'I')/* Greyscale 12-bit L/R interleaved */ +#define V4L2_PIX_FMT_Y16I v4l2_fourcc('Y', '1', '6', 'I')/* Greyscale 16-bit L/R interleaved */ #define V4L2_PIX_FMT_Z16 v4l2_fourcc('Z', '1', '6', ' ')/* Depth data 16-bit */ #define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1')/* Mediatek compressed block mode */ #define V4L2_PIX_FMT_MM21 v4l2_fourcc('M', 'M', '2', '1')/* Mediatek 8-bit block mode, two non-contiguous planes */
Signature · 1 line
2.43.0
Re: [PATCH 1/2] v4l: Add luma 16-bit interlaced pixel format
Hi Dmitry,
Thank you for the patch.
Quoted 31 lines · Dmitry Perchanov
The formats added by this patch are:
V4L2_PIX_FMT_Y16IInterlaced lumina format primary use in RealSense Depth cameras with stereo stream for left and right image sensors.
Signed-off-by Dmitry Perchanov <[email protected]>--- .../userspace-api/media/v4l/pixfmt-y16i.rst | 74 +++++++++++++++++++ .../userspace-api/media/v4l/yuv-formats.rst | 1 + drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 4 files changed, 77 insertions(+) create mode 100644 Documentation/userspace-api/media/v4l/pixfmt-y16i.rstDocumentation/userspace-api/media/v4l/pixfmt-y16i.rst new file +8
-0@@ -0,0 +1,74 @@ +.. SPDX-License-Identifier: GFDL-1.1-no-invariants-or-later + +.. _V4L2-PIX-FMT-Y16I: + +************************** +V4L2_PIX_FMT_Y16I ('Y16I') +************************** +
Documentation/userspace-api/media/v4l/pixfmt-y16i.rst line 18
Quoted 10 lines
Documentation/userspace-api/media/v4l/pixfmt-y16i.rst new file +10
-0+Interleaved grey-scale image, e.g. from a stereo-pair + + +Description +=========== + +This is a grey-scale image with a depth of 16 bits per pixel, but with +pixels from 2 sources interleaved and unpacked. Each pixel is stored +in a 16-bit word in the little-endian order. +The first pixel is from the left source.
You can reflow this to 80 columns:
This is a grey-scale image with a depth of 16 bits per pixel, but with pixels from 2 sources interleaved and unpacked. Each pixel is stored in a 16-bit word in the little-endian order. The first pixel is from the left source.
With this,
I can make that change locally, no need to send a new version just for this.
Quoted 91 lines
Documentation/userspace-api/media/v4l/pixfmt-y16i.rst new file +56
-0+ +**Pixel unpacked representation.** +Left/Right pixels 16-bit unpacked - 16-bit for each interleaved pixel. + +.. flat-table:: + :header-rows: 0 + :stub-columns: 0 + + * - Y'\ :sub:`0L[7:0]` + - Y'\ :sub:`0L[15:8]` + - Y'\ :sub:`0R[7:0]` + - Y'\ :sub:`0R[15:8]` + +**Byte Order.** +Each cell is one byte. + +.. flat-table:: + :header-rows: 0 + :stub-columns: 0 + + * - start + 0: + - Y'\ :sub:`00Llow` + - Y'\ :sub:`00Lhigh` + - Y'\ :sub:`00Rlow` + - Y'\ :sub:`00Rhigh` + - Y'\ :sub:`01Llow` + - Y'\ :sub:`01Lhigh` + - Y'\ :sub:`01Rlow` + - Y'\ :sub:`01Rhigh` + * - start + 8: + - Y'\ :sub:`10Llow` + - Y'\ :sub:`10Lhigh` + - Y'\ :sub:`10Rlow` + - Y'\ :sub:`10Rhigh` + - Y'\ :sub:`11Llow` + - Y'\ :sub:`11Lhigh` + - Y'\ :sub:`11Rlow` + - Y'\ :sub:`11Rhigh` + * - start + 16: + - Y'\ :sub:`20Llow` + - Y'\ :sub:`20Lhigh` + - Y'\ :sub:`20Rlow` + - Y'\ :sub:`20Rhigh` + - Y'\ :sub:`21Llow` + - Y'\ :sub:`21Lhigh` + - Y'\ :sub:`21Rlow` + - Y'\ :sub:`21Rhigh` + * - start + 24: + - Y'\ :sub:`30Llow` + - Y'\ :sub:`30Lhigh` + - Y'\ :sub:`30Rlow` + - Y'\ :sub:`30Rhigh` + - Y'\ :sub:`31Llow` + - Y'\ :sub:`31Lhigh` + - Y'\ :sub:`31Rlow` + - Y'\ :sub:`31Rhigh`Documentation/userspace-api/media/v4l/yuv-formats.rst +1
-0@@ -269,5 +269,6 @@ image. pixfmt-yuv-luma pixfmt-y8i pixfmt-y12i + pixfmt-y16i pixfmt-uv8 pixfmt-m420drivers/media/v4l2-core/v4l2-ioctl.c +1
-0@@ -1327,6 +1327,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)case V4L2_PIX_FMT_Y14P : descr ="14-bit Greyscale (MIPI Packed)" ;break ;case V4L2_PIX_FMT_Y8I : descr ="Interleaved 8-bit Greyscale" ;break ;case V4L2_PIX_FMT_Y12I : descr ="Interleaved 12-bit Greyscale" ;break ; +case V4L2_PIX_FMT_Y16I : descr ="Interleaved 16-bit Greyscale" ;break ;case V4L2_PIX_FMT_Z16 : descr ="16-bit Depth" ;break ;case V4L2_PIX_FMT_INZI : descr ="Planar 10:16 Greyscale Depth" ;break ;case V4L2_PIX_FMT_CNF4 : descr ="4-bit Depth Confidence (Packed)" ;break ;include/uapi/linux/videodev2.h +1
-0@@ -797,6 +797,7 @@ struct v4l2_pix_format {#define V4L2_PIX_FMT_S5C_UYVY_JPG v4l2_fourcc('S', '5', 'C', 'I')/* S5C73M3 interleaved UYVY/JPEG */ #define V4L2_PIX_FMT_Y8I v4l2_fourcc('Y', '8', 'I', ' ')/* Greyscale 8-bit L/R interleaved */ #define V4L2_PIX_FMT_Y12I v4l2_fourcc('Y', '1', '2', 'I')/* Greyscale 12-bit L/R interleaved */ +#define V4L2_PIX_FMT_Y16I v4l2_fourcc('Y', '1', '6', 'I')/* Greyscale 16-bit L/R interleaved */ #define V4L2_PIX_FMT_Z16 v4l2_fourcc('Z', '1', '6', ' ')/* Depth data 16-bit */ #define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1')/* Mediatek compressed block mode */ #define V4L2_PIX_FMT_MM21 v4l2_fourcc('M', 'M', '2', '1')/* Mediatek 8-bit block mode, two non-contiguous planes */
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH 1/2] v4l: Add luma 16-bit interlaced pixel format
In reply to Dmitry PerchanovHi,
just cosmetic comment.
Le lundi 26 août 2024 à 16:04 +0300, Dmitry Perchanov a écrit :
Quoted 5 lines
The formats added by this patch are:
V4L2_PIX_FMT_Y16IInterlaced lumina format primary use in RealSense
Here we specify the format as interlaced ...
Quoted 24 lines
Depth cameras with stereo stream for left and right image sensors.
Signed-off-by Dmitry Perchanov <[email protected]>--- .../userspace-api/media/v4l/pixfmt-y16i.rst | 74 +++++++++++++++++++ .../userspace-api/media/v4l/yuv-formats.rst | 1 + drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 4 files changed, 77 insertions(+) create mode 100644 Documentation/userspace-api/media/v4l/pixfmt-y16i.rstDocumentation/userspace-api/media/v4l/pixfmt-y16i.rst new file +6
-0@@ -0,0 +1,74 @@ +.. SPDX-License-Identifier: GFDL-1.1-no-invariants-or-later + +.. _V4L2-PIX-FMT-Y16I: + +************************** +V4L2_PIX_FMT_Y16I ('Y16I')
Documentation/userspace-api/media/v4l/pixfmt-y16i.rst line 16
Quoted 10 lines
Documentation/userspace-api/media/v4l/pixfmt-y16i.rst new file +10
-0+************************** + +Interleaved grey-scale image, e.g. from a stereo-pair + + +Description +=========== + +This is a grey-scale image with a depth of 16 bits per pixel, but with +pixels from 2 sources interleaved and unpacked. Each pixel is stored
... But document it as interleaved. Id unify the wording as interleaved everywhere if you don't mind. My weak argument is that interlaced is largely used in the media subsystem to refer to the technique of passing half the image data, alternating between top and bottom field. In that context, we then use interleave to describe on method of line/field storage (we also have sequential and alternate method supported).
Nicolas
Quoted 93 lines
Documentation/userspace-api/media/v4l/pixfmt-y16i.rst new file +58
-0+in a 16-bit word in the little-endian order. +The first pixel is from the left source. + +**Pixel unpacked representation.** +Left/Right pixels 16-bit unpacked - 16-bit for each interleaved pixel. + +.. flat-table:: + :header-rows: 0 + :stub-columns: 0 + + * - Y'\ :sub:`0L[7:0]` + - Y'\ :sub:`0L[15:8]` + - Y'\ :sub:`0R[7:0]` + - Y'\ :sub:`0R[15:8]` + +**Byte Order.** +Each cell is one byte. + +.. flat-table:: + :header-rows: 0 + :stub-columns: 0 + + * - start + 0: + - Y'\ :sub:`00Llow` + - Y'\ :sub:`00Lhigh` + - Y'\ :sub:`00Rlow` + - Y'\ :sub:`00Rhigh` + - Y'\ :sub:`01Llow` + - Y'\ :sub:`01Lhigh` + - Y'\ :sub:`01Rlow` + - Y'\ :sub:`01Rhigh` + * - start + 8: + - Y'\ :sub:`10Llow` + - Y'\ :sub:`10Lhigh` + - Y'\ :sub:`10Rlow` + - Y'\ :sub:`10Rhigh` + - Y'\ :sub:`11Llow` + - Y'\ :sub:`11Lhigh` + - Y'\ :sub:`11Rlow` + - Y'\ :sub:`11Rhigh` + * - start + 16: + - Y'\ :sub:`20Llow` + - Y'\ :sub:`20Lhigh` + - Y'\ :sub:`20Rlow` + - Y'\ :sub:`20Rhigh` + - Y'\ :sub:`21Llow` + - Y'\ :sub:`21Lhigh` + - Y'\ :sub:`21Rlow` + - Y'\ :sub:`21Rhigh` + * - start + 24: + - Y'\ :sub:`30Llow` + - Y'\ :sub:`30Lhigh` + - Y'\ :sub:`30Rlow` + - Y'\ :sub:`30Rhigh` + - Y'\ :sub:`31Llow` + - Y'\ :sub:`31Lhigh` + - Y'\ :sub:`31Rlow` + - Y'\ :sub:`31Rhigh`Documentation/userspace-api/media/v4l/yuv-formats.rst +1
-0@@ -269,5 +269,6 @@ image. pixfmt-yuv-luma pixfmt-y8i pixfmt-y12i + pixfmt-y16i pixfmt-uv8 pixfmt-m420drivers/media/v4l2-core/v4l2-ioctl.c +1
-0@@ -1327,6 +1327,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)case V4L2_PIX_FMT_Y14P : descr ="14-bit Greyscale (MIPI Packed)" ;break ;case V4L2_PIX_FMT_Y8I : descr ="Interleaved 8-bit Greyscale" ;break ;case V4L2_PIX_FMT_Y12I : descr ="Interleaved 12-bit Greyscale" ;break ; +case V4L2_PIX_FMT_Y16I : descr ="Interleaved 16-bit Greyscale" ;break ;case V4L2_PIX_FMT_Z16 : descr ="16-bit Depth" ;break ;case V4L2_PIX_FMT_INZI : descr ="Planar 10:16 Greyscale Depth" ;break ;case V4L2_PIX_FMT_CNF4 : descr ="4-bit Depth Confidence (Packed)" ;break ;include/uapi/linux/videodev2.h +1
-0@@ -797,6 +797,7 @@ struct v4l2_pix_format {#define V4L2_PIX_FMT_S5C_UYVY_JPG v4l2_fourcc('S', '5', 'C', 'I')/* S5C73M3 interleaved UYVY/JPEG */ #define V4L2_PIX_FMT_Y8I v4l2_fourcc('Y', '8', 'I', ' ')/* Greyscale 8-bit L/R interleaved */ #define V4L2_PIX_FMT_Y12I v4l2_fourcc('Y', '1', '2', 'I')/* Greyscale 12-bit L/R interleaved */ +#define V4L2_PIX_FMT_Y16I v4l2_fourcc('Y', '1', '6', 'I')/* Greyscale 16-bit L/R interleaved */ #define V4L2_PIX_FMT_Z16 v4l2_fourcc('Z', '1', '6', ' ')/* Depth data 16-bit */ #define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1')/* Mediatek compressed block mode */ #define V4L2_PIX_FMT_MM21 v4l2_fourcc('M', 'M', '2', '1')/* Mediatek 8-bit block mode, two non-contiguous planes */
PATCH 2/2 uvc: Add luma 16-bit interlaced pixel format
In reply to Dmitry PerchanovThe formats added by this patch are:
UVC_GUID_FORMAT_Y16I
Interlaced lumina format primary use in RealSense Depth cameras with stereo stream for left and right image sensors.
--- drivers/media/common/uvc.c | 4 ++++ include/linux/usb/uvc.h | 3 +++ 2 files changed, 7 insertions(+)
drivers/media/common/uvc.c +4 -0
@@ -120,6 +120,10 @@ static const struct uvc_format_desc uvc_fmts[] = { .guid = UVC_GUID_FORMAT_Y12I, .fcc = V4L2_PIX_FMT_Y12I, }, + { + .guid = UVC_GUID_FORMAT_Y16I, + .fcc = V4L2_PIX_FMT_Y16I, + }, { .guid = UVC_GUID_FORMAT_Z16, .fcc = V4L2_PIX_FMT_Z16,
include/linux/usb/uvc.h +3 -0
@@ -118,6 +118,9 @@#define UVC_GUID_FORMAT_Y12I \ { 'Y', '1', '2', 'I', 0x00, 0x00, 0x10, 0x00, \ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} +#define UVC_GUID_FORMAT_Y16I \ + { 'Y', '1', '6', 'I', 0x00, 0x00, 0x10, 0x00, \ + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}#define UVC_GUID_FORMAT_Z16 \ { 'Z', '1', '6', ' ', 0x00, 0x00, 0x10, 0x00, \ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
Signature · 1 line
2.43.0
Re: [PATCH 2/2] uvc: Add luma 16-bit interlaced pixel format
Hi Dmitry,
Thank you for the patch.
The subject should start with "media: uvcvideo:". I'll update this locally.
Quoted 9 lines · Dmitry Perchanov
The formats added by this patch are:
UVC_GUID_FORMAT_Y16IInterlaced lumina format primary use in RealSense Depth cameras with stereo stream for left and right image sensors.
Signed-off-by Dmitry Perchanov <[email protected]>
Quoted 34 lines
--- drivers/media/common/uvc.c | 4 ++++ include/linux/usb/uvc.h | 3 +++ 2 files changed, 7 insertions(+)drivers/media/common/uvc.c +4
-0@@ -120,6 +120,10 @@ static const struct uvc_format_desc uvc_fmts[] = { .guid = UVC_GUID_FORMAT_Y12I, .fcc = V4L2_PIX_FMT_Y12I, }, + { + .guid = UVC_GUID_FORMAT_Y16I, + .fcc = V4L2_PIX_FMT_Y16I, + }, { .guid = UVC_GUID_FORMAT_Z16, .fcc = V4L2_PIX_FMT_Z16,include/linux/usb/uvc.h +3
-0@@ -118,6 +118,9 @@#define UVC_GUID_FORMAT_Y12I \ { 'Y', '1', '2', 'I', 0x00, 0x00, 0x10, 0x00, \ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} +#define UVC_GUID_FORMAT_Y16I \ + { 'Y', '1', '6', 'I', 0x00, 0x00, 0x10, 0x00, \ + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}#define UVC_GUID_FORMAT_Z16 \ { 'Z', '1', '6', ' ', 0x00, 0x00, 0x10, 0x00, \ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
Signature · 3 lines
Regards, Laurent Pinchart