Skip to contentSkip to conversation

staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529

PATCH Superseded Alien Wesley 2 participants 2 messages Aug 26, 2024 Staging

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Alien Wesley

author
#0 lore raw

PATCH v3 1/1 staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529

Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.

CHECK: multiple assignments should be avoided.

Signed-off-by Alien Wesley <[email protected]>

---
v3: Fix typo in commit message.
v2: Removed two spaces in front of "=".

---
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +1 -1
index 47f1adf30ab4..67c4793e0fc1 100644
@@ -526,7 +526,7 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
 	mutex_unlock(&priv->wx_mutex);
 
 	if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
-		ieee->pairwise_key_type  = KEY_TYPE_NA;
+		ieee->pairwise_key_type = KEY_TYPE_NA;
 		ieee->group_key_type = KEY_TYPE_NA;
 		rtl92e_cam_reset(dev);
 		memset(priv->rtllib->swcamtable, 0,
Signature · 1 line
2.34.1
#1 lore raw
Quoted 18 lines · Alien Wesley

Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.

CHECK: multiple assignments should be avoided.

Signed-off-by Alien Wesley <[email protected]>

---
v3: Fix typo in commit message.
v2: Removed two spaces in front of "=".

---
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +0 -0
index 47f1adf30ab4..67c4793e0fc1 100644

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c static int _rtl92e_wx_set_enc(struct net_device *dev, · line 529

Quoted 5 lines
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +1 -1
@@ -526,7 +526,7 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
 	mutex_unlock(&priv->wx_mutex);
 
 	if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
-		ieee->pairwise_key_type  = KEY_TYPE_NA;
+		ieee->pairwise_key_type = KEY_TYPE_NA;

I was completely confused, because the desscription says "Fix multiple assignments", yet I only see a whitespace fix.

So I looked at v1, and it makes sense, you are sending this as a follow-up fix for a double-space issue that you added in v1.

Instead of doing this, please just squash your v1 and v3 patches together and send it as v4. This v3 patch doesn't make sense on its own.

Best regards,
Nam