Skip to contentSkip to conversation

mfd: tc3589x: Drop vendorless compatible string from match table

PATCH Applied Rob Herring (Arm) 2 participants 2 messages Aug 26, 2024 – Aug 30, 2024 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: tc3589x: Drop vendorless compatible string from match table

There's no need to list "tc3589x" in the DT match table. The I2C core will strip any vendor prefix and match against the i2c_device_id table which has an "tc3589x" entry.

Probably "tc3589x" and TC3589X_UNKNOWN could be removed altogether. Use of that compatible was only on some STE platforms and was dropped in 2013. There were ABI breaks in 2014 claiming no DTs in the wild. See commit 1637d480f873 ("pinctrl: nomadik: force-convert to generic config bindings").

---
 drivers/mfd/tc3589x.c | 2 --
 1 file changed, 2 deletions(-)
drivers/mfd/tc3589x.c +0 -2
index db28eb0c8995..ef953ee73145 100644
@@ -312,8 +312,6 @@ static int tc3589x_device_init(struct tc3589x *tc3589x)
 }
 
 static const struct of_device_id tc3589x_match[] = {
-	/* Legacy compatible string */
-	{ .compatible = "tc3589x", .data = (void *) TC3589X_UNKNOWN },
 	{ .compatible = "toshiba,tc35890", .data = (void *) TC3589X_TC35890 },
 	{ .compatible = "toshiba,tc35892", .data = (void *) TC3589X_TC35892 },
 	{ .compatible = "toshiba,tc35893", .data = (void *) TC3589X_TC35893 },
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw

Re: (subset) [PATCH] mfd: tc3589x: Drop vendorless compatible string from match table

Quoted 11 lines · Rob Herring (Arm)

There's no need to list "tc3589x" in the DT match table. The I2C core will strip any vendor prefix and match against the i2c_device_id table which has an "tc3589x" entry.

Probably "tc3589x" and TC3589X_UNKNOWN could be removed altogether. Use of that compatible was only on some STE platforms and was dropped in 2013. There were ABI breaks in 2014 claiming no DTs in the wild. See commit 1637d480f873 ("pinctrl: nomadik: force-convert to generic config bindings").

[...]

Applied, thanks!

[1/1] mfd: tc3589x: Drop vendorless compatible string from match table

      commit: 6fa9be093a2c1238531a9127db765555a49796e5

--
Lee Jones [李琼斯]