Skip to contentSkip to conversation

rtc: s35390a: Drop vendorless compatible string from match table

PATCH Applied Rob Herring (Arm) 2 participants 2 messages Aug 26, 2024 – Sep 11, 2024 Real time clock (RTC)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtc: s35390a: Drop vendorless compatible string from match table

There's no need to list "s35390a" in the DT match table. The I2C core will strip any vendor prefix and match against the i2c_device_id table which has an "s35390a" entry.

---
 drivers/rtc/rtc-s35390a.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-s35390a.c +0 -1
index 2d6b655a4b25..e3dc18882f41 100644
@@ -56,7 +56,6 @@ static const struct i2c_device_id s35390a_id[] = {
 MODULE_DEVICE_TABLE(i2c, s35390a_id);
 
 static const __maybe_unused struct of_device_id s35390a_of_match[] = {
-	{ .compatible = "s35390a" },
 	{ .compatible = "sii,s35390a" },
 	{ }
 };
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 5 lines · Rob Herring (Arm)

There's no need to list "s35390a" in the DT match table. The I2C core will strip any vendor prefix and match against the i2c_device_id table which has an "s35390a" entry.

Applied, thanks!

[1/1] rtc: s35390a: Drop vendorless compatible string from match table

      https://git.kernel.org/abelloni/c/da1531ecf186

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com