acpi/_DSM: Add rev/func to warning message when acpi_evaluate_dsm failed.
PATCH 1/1 acpi/_DSM: Add rev/func to warning message when acpi_evaluate_dsm failed.
When acpi_evaluate_dsm failed, the warning message lacks the rev
and func information which is available and helpful.
For example, iwlwifi would make _DSM queries for lari config,
and when it failed, all warning messages are all the same:
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
With this patch, the warnings would be more informative:
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:1 (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:6 (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:7 (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:8 (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:3 (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:9 (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:10 (0x1001)
ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:12 (0x1001)
--- drivers/acpi/utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/acpi/utils.c +2 -1
@@ -801,7 +801,8 @@ acpi_evaluate_dsm(acpi_handle handle, const guid_t *guid, u64 rev, u64 func,if (ret !=AE_NOT_FOUND )acpi_handle_warn (handle, -"failed to evaluate _DSM %pUb (0x%x)\n" , guid, ret); +"failed to evaluate _DSM %pUb rev:%lld func:%lld (0x%x)\n" , + guid, rev, func, ret);return NULL ; }
Signature · 1 line
2.39.2
Quoted 33 lines · David Wang
When
acpi_evaluate_dsmfailed, the warning message lacks the rev
and func information which is available and helpful.
For example, iwlwifi would make_DSMqueries for lari config,
and when it failed, all warning messages are all the same:
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
With this patch, the warnings would be more informative:
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:1 (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:6 (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:7 (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:8 (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:3 (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:9 (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:10 (0x1001)
ACPI: \: failed to evaluate_DSMbf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:12 (0x1001)Signed-off-by David Wang <[email protected]>--- drivers/acpi/utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/acpi/utils.c +0
-0
drivers/acpi/utils.c acpi_evaluate_dsm(acpi_handle handle, const guid_t *guid, u64 rev, u64 func,
Quoted 10 lines
drivers/acpi/utils.c +2
-2@@ -801,7 +801,8 @@ acpi_evaluate_dsm(acpi_handle handle, const guid_t *guid, u64 rev, u64 func,if (ret !=AE_NOT_FOUND )acpi_handle_warn (handle, -"failed to evaluate _DSM %pUb (0x%x)\n" , guid, ret); +"failed to evaluate _DSM %pUb rev:%lld func:%lld (0x%x)\n" , + guid, rev, func, ret);return NULL ; } --
Applied as 6.12 material with some edits in the subject and changelog, thanks!