staging: rtl87212: Match parenthesis alignment
PATCH 1/1 staging: rtl87212: Match parenthesis alignment
Fix the parenthesis alignment in r8712_read_port() function to match the opening parenthesis
--- drivers/staging/rtl8712/usb_ops_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/usb_ops_linux.c +1 -1
@@ -221,7 +221,7 @@ static void r8712_usb_read_port_complete(struct urb *purb) fallthrough;case -EPROTO :r8712_read_port (padapter, precvpriv->ff_hwaddr,0 , - (unsigned char *)precvbuf); + (unsigned char *)precvbuf);break ;case -EINPROGRESS :netdev_err (padapter->pnetdev,"ERROR: URB IS IN PROGRESS!\n" );
--
2.25.1
Quoted 22 lines · Dorine Tipo
Fix the parenthesis alignment in
r8712_read_port()function to match the opening parenthesisSigned-off-by Dorine Tipo <[email protected]>--- drivers/staging/rtl8712/usb_ops_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8712/usb_ops_linux.c +1
-2@@ -221,7 +221,7 @@ static void r8712_usb_read_port_complete(struct urb *purb) fallthrough;case -EPROTO :r8712_read_port (padapter, precvpriv->ff_hwaddr,0 , - (unsigned char *)precvbuf); + (unsigned char *)precvbuf);break ;case -EINPROGRESS :netdev_err (padapter->pnetdev,"ERROR: URB IS IN PROGRESS!\n" ); --
Quoted 3 lines
2.25.1
Hi Dorine,
please correct the typo in the subject. ("rtl8712")
Please make your "Subject" line more unique. Consider that we may end up with having dozen of commits like yours, all of them referring to different removals and all without the necessary information to tell what they differ in (except the driver/subsystem). So it would help if you add the changed file or function to make it more unique.
Please use a dot to end the sentences in the description.
You described a why but may be you can improve the description with the why for the reader. For example by adding ... to improve readability.
If you send in a second version of this patch please use a change history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Thanks for your support.
Bye Philipp