ALSA: timer: Relax start tick time check for slave timer elements
Subsystems (2)
PATCH 1/1 ALSA: timer: Relax start tick time check for slave timer elements
commit ccbfcac05866ebe6eb3bc6d07b51d4ed4fcde436 upstream.
The recent addition of a sanity check for a too low start tick time seems breaking some applications that uses aloop with a certain slave timer setup. They may have the initial resolution 0, hence it's treated as if it were a too low value.
Relax and skip the check for the slave timer instance for addressing the regression.
---
Greg, this is a backport for 6.6.y and older stable kernels that failed to cherry-pick the original one.
sound/core/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/timer.c +1 -1
@@ -556,7 +556,7 @@ static int snd_timer_start1(struct snd_timer_instance *timeri,/* check the actual time for the start tick; * bail out as error if it's way too low (< 100us) */ -if (start) { +if (start && !(timer->hw.flags &SNDRV_TIMER_HW_SLAVE )) {if ((u64 )snd_timer_hw_resolution (timer) * ticks <100000 ) { result = -EINVAL ; goto unlock;
Signature · 1 line
2.43.0
Greg KH
maintainerQuoted 15 lines · Takashi Iwai
commit
ccbfcac05866ebe6eb3bc6d07b51d4ed4fcde436upstream.The recent addition of a sanity check for a too low start tick time seems breaking some applications that uses aloop with a certain slave timer setup. They may have the initial resolution 0, hence it's treated as if it were a too low value.
Relax and skip the check for the slave timer instance for addressing the regression.
Fixes 4a63bd179fa8 ("ALSA: timer: Set lower bound of start tick time")Cc <[email protected]>Signed-off-by Takashi Iwai <[email protected]>
Quoted 5 lines
---
Greg, this is a backport for 6.6.y and older stable kernels that failed to cherry-pick the original one.
Now queued up, thanks.
greg k-h