Skip to contentSkip to conversation

staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided

PATCH In review Riyan Dhiman 2 participants 2 messages Aug 27, 2024 – Aug 29, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided

Abstract out x86-specific code in ddk750_init_hw() to improve portability and adhere to kernel coding standards. Replaces architecture-specific defines with CONFIG_X86 checks.

Fixes checkpatch warning:
- CHECK: architecture specific defines should be avoided.

Changes made:
- Create a new function sm750le_set_graphic_mode to encapsulate architecture specifc behaviour.
- Using CONFIG_X86 instead of i386 and x86.
- Added placeholder for non-x86 architectures in sm750le_set_graphic_mode function.

---
 drivers/staging/sm750fb/ddk750_chip.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +12 -5
index 02860d3ec365..23196070bceb 100644
@@ -210,6 +210,17 @@ unsigned int ddk750_get_vm_size(void)
 	return data;
 }
 
+static void sm750le_set_graphic_mode(void)
+{
+#ifdef CONFIG_X86
+	outb_p(0x88, 0x3d4);
+	outb_p(0x06, 0x3d5);
+#else
+	/* Implement an alternative method for non-x86 architectures */
+	/* This might involve memory-mapped I/O or other chip-specific methods */
+#endif
+}
+
 int ddk750_init_hw(struct initchip_param *p_init_param)
 {
 	unsigned int reg;
@@ -229,11 +240,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
 		reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
 		poke32(VGA_CONFIGURATION, reg);
 	} else {
-#if defined(__i386__) || defined(__x86_64__)
-		/* set graphic mode via IO method */
-		outb_p(0x88, 0x3d4);
-		outb_p(0x06, 0x3d5);
-#endif
+		sm750le_set_graphic_mode();
 	}
 
 	/* Set the Main Chip Clock */
Signature · 1 line
2.46.0
maintainer
#1 lore raw
Quoted 42 lines · Riyan Dhiman

Abstract out x86-specific code in ddk750_init_hw() to improve portability and adhere to kernel coding standards. Replaces architecture-specific defines with CONFIG_X86 checks.

Fixes checkpatch warning:
- CHECK: architecture specific defines should be avoided.

Changes made:
- Create a new function sm750le_set_graphic_mode to encapsulate architecture specifc behaviour.
- Using CONFIG_X86 instead of i386 and x86.
- Added placeholder for non-x86 architectures in sm750le_set_graphic_mode function.

---
 drivers/staging/sm750fb/ddk750_chip.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +11 -0
index 02860d3ec365..23196070bceb 100644
@@ -210,6 +210,17 @@ unsigned int ddk750_get_vm_size(void)
 	return data;
 }
 
+static void sm750le_set_graphic_mode(void)
+{
+#ifdef CONFIG_X86
+	outb_p(0x88, 0x3d4);
+	outb_p(0x06, 0x3d5);
+#else
+	/* Implement an alternative method for non-x86 architectures */
+	/* This might involve memory-mapped I/O or other chip-specific methods */
+#endif
+}
+
 int ddk750_init_hw(struct initchip_param *p_init_param)
 {
 	unsigned int reg;

drivers/staging/sm750fb/ddk750_chip.c int ddk750_init_hw(struct initchip_param *p_init_param) · line 243

Quoted 9 lines
drivers/staging/sm750fb/ddk750_chip.c +1 -5
@@ -229,11 +240,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
 		reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
 		poke32(VGA_CONFIGURATION, reg);
 	} else {
-#if defined(__i386__) || defined(__x86_64__)
-		/* set graphic mode via IO method */
-		outb_p(0x88, 0x3d4);
-		outb_p(0x06, 0x3d5);
-#endif
+		sm750le_set_graphic_mode();

This really doesn't change much, right? I think the existing code is fine, it's ok to ignore checkpatch here.

thanks,

greg k-h