staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325

PATCH Superseded Nilo Alexandre 2 participants 2 messages Aug 27, 2024 Staging

lore

Share & tools

lore

Nilo Alexandre

author

2024-08-27 19:56 UTC #0 lore raw

PATCH v3 1/1 staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325

Align parenthesis to improve readability.

CHECK: Alignment should match open parenthesis

Signed-off-by Nilo Alexandre <[email protected]>

---
v3: Fix typo in commit message.
v2: Using tabs instead of spaces.

---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +1 -1

index b767dc00100aa..2d17d8e8898e7 100644
@@ -322,7 +322,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
 		if (priv->epromtype == EEPROM_93C46) {
 			if (!priv->autoload_fail_flag) {
 				usValue = rtl92e_eeprom_read(dev,
-					                     EEPROM_TxPwDiff_CrystalCap >> 1);
+								EEPROM_TxPwDiff_CrystalCap >> 1);
 				priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
 				priv->eeprom_crystal_cap = (usValue & 0xf000)
 							 >> 12;

Signature · 1 line

2.46.0

Nam Cao

2024-08-27 20:29 UTC #1 lore raw

Quoted 17 lines · Nilo Alexandre

Align parenthesis to improve readability.
CHECK: Alignment should match open parenthesis
Signed-off-by Nilo Alexandre <[email protected]>
---
v3: Fix typo in commit message.
v2: Using tabs instead of spaces.
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +0 -0
index b767dc00100aa..2d17d8e8898e7 100644

drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c static void _rtl92e_read_eeprom_info(struct net_device *dev) · line 325

Quoted 5 lines

drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +1 -1

@@ -322,7 +322,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
 		if (priv->epromtype == EEPROM_93C46) {
 			if (!priv->autoload_fail_flag) {
 				usValue = rtl92e_eeprom_read(dev,
-					                     EEPROM_TxPwDiff_CrystalCap >> 1);
+								EEPROM_TxPwDiff_CrystalCap >> 1);

But it was aligned, your patch makes it misaligned, right?

Also, I couldn't apply this patch. Are you sure this patch was made on top of Greg's staging tree?

I suspect that there is a linebreak here because of Linux's historical 80 columns limit. Now that the limit is raised to 100, perhaps it's better to just remove the linebreak:

drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +1 -2

index b25e83743956..a80efe6c7c20 100644
@@ -321,8 +321,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
 
 		if (priv->epromtype == EEPROM_93C46) {
 			if (!priv->autoload_fail_flag) {
-				usValue = rtl92e_eeprom_read(dev,
-					  EEPROM_TxPwDiff_CrystalCap >> 1);
+				usValue = rtl92e_eeprom_read(dev, EEPROM_TxPwDiff_CrystalCap >> 1);
 				priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
 				priv->eeprom_crystal_cap = (usValue & 0xf000)
 							 >> 12;