drm/amdgpu: Move the dumping log out of for loop
Subsystems (2)
PATCH 1/1 drm/amdgpu: Move the dumping log out of for loop
log message "Dumping IP State Completed" needs to be logged only once when state dumping is complete.
Hence moving it out of the for loop.
Signed-off-by Sunil Khatri <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c +2 -3
@@ -39,12 +39,11 @@ static void amdgpu_job_do_core_dump(struct amdgpu_device *adev,int i;dev_info (adev->dev,"Dumping IP State\n" ); -for (i =0 ; i < adev->num_ip_blocks; i++) { +for (i =0 ; i < adev->num_ip_blocks; i++)if (adev->ip_blocks[i].version->funcs->dump_ip_state) adev->ip_blocks[i].version->funcs ->dump_ip_state ((void *)adev); -dev_info (adev->dev,"Dumping IP State Completed\n" ); - } +dev_info (adev->dev,"Dumping IP State Completed\n" );amdgpu_coredump (adev, true, false, job); }
Signature · 1 line
2.34.1
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by Trigger Huang <[email protected]>
Quoted 40 lines
-----Original Message-----
From: Sunil Khatri <[email protected]>
Sent: Wednesday, August 28, 2024 4:09 PM
To: Deucher, Alexander <[email protected]>; Huang, Trigger <[email protected]>
Cc: [email protected]; Khatri, Sunil <[email protected]>
Subject: [PATCH] drm/amdgpu: Move the dumping log out of for looplog message "Dumping IP State Completed" needs to be logged only once when state dumping is complete.
Hence moving it out of the for loop.
Signed-off-by Sunil Khatri <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_job.c +2
-4@@ -39,12 +39,11 @@ static void amdgpu_job_do_core_dump(structamdgpu_device *adev, int i;dev_info (adev->dev,"Dumping IP State\n" ); -for (i =0 ; i < adev->num_ip_blocks; i++) { +for (i =0 ; i < adev->num_ip_blocks; i++)if (adev->ip_blocks[i].version->funcs->dump_ip_state) adev->ip_blocks[i].version->funcs ->dump_ip_state ((void *)adev); -dev_info (adev->dev,"Dumping IP State Completed\n" ); - } +dev_info (adev->dev,"Dumping IP State Completed\n" );amdgpu_coredump (adev, true, false, job); } --2.34.1