misc: lis3lv02d: Fix incorrect of_get_property() usage
Subsystems (2)
PATCH 1/1 misc: lis3lv02d: Fix incorrect of_get_property() usage
The usage of of_get_property() is wrong. What's returned in "val" is the property's length, not the value. Fix this by using the preferred typed of_property_read_u32() function instead.
Signed-off-by Rob Herring (Arm) <[email protected]>
--- drivers/misc/lis3lv02d/lis3lv02d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/lis3lv02d/lis3lv02d.c +2 -2
@@ -1038,7 +1038,7 @@ int lis3lv02d_init_dt(struct lis3lv02d *lis3) pdata->wakeup_flags |=LIS3_WAKEUP_Z_LO ;if (of_property_read_bool (np,"st,wakeup-z-hi" )) pdata->wakeup_flags |=LIS3_WAKEUP_Z_HI ; -if (of_get_property (np,"st,wakeup-threshold" , &val)) +if (!of_property_read_u32 (np,"st,wakeup-threshold" , &val)) pdata->wakeup_thresh = val;if (of_property_read_bool (np,"st,wakeup2-x-lo" ))
@@ -1053,7 +1053,7 @@ int lis3lv02d_init_dt(struct lis3lv02d *lis3) pdata->wakeup_flags2 |=LIS3_WAKEUP_Z_LO ;if (of_property_read_bool (np,"st,wakeup2-z-hi" )) pdata->wakeup_flags2 |=LIS3_WAKEUP_Z_HI ; -if (of_get_property (np,"st,wakeup2-threshold" , &val)) +if (!of_property_read_u32 (np,"st,wakeup2-threshold" , &val)) pdata->wakeup_thresh2 = val;if (!of_property_read_u32 (np,"st,highpass-cutoff-hz" , &val)) {
Signature · 1 line
2.45.2