dt-bindings: trivial-devices: Document elgin,jg10309-01
Subsystems (3)
PATCH RESEND v2 1/3 dt-bindings: trivial-devices: Document elgin,jg10309-01
The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. The marking on the LCD is JG10309-01.
Add an entry for the "elgin,jg10309-01" compatible string.
---
Changes since v1:
- Use a more specific compatible string. (Conor)
Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
@@ -110,6 +110,8 @@ properties: - domintech,dmard09 # DMARD10: 3-axis Accelerometer - domintech,dmard10 + # Elgin SPI-controlled LCD + - elgin,jg10309-01 # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor - fsl,mma7660 # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
Signature · 1 line
2.34.1
PATCH RESEND v3 2/3 spi: spidev: Add an entry for elgin,jg10309-01
The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. The marking on the LCD is JG10309-01.
Add the "elgin,jg10309-01" compatible string.
---
Changes since v1:
- Use a more specific compatible string. (Conor)
drivers/spi/spidev.c | 1 + 1 file changed, 1 insertion(+)
drivers/spi/spidev.c +1 -0
@@ -730,6 +730,7 @@ static int spidev_of_check(struct device *dev)static const struct of_device_id spidev_dt_ids[] = { { .compatible ="cisco,spi-petra" , .data = &spidev_of_check }, { .compatible ="dh,dhcom-board" , .data = &spidev_of_check }, + { .compatible ="elgin,jg10309-01" , .data = &spidev_of_check }, { .compatible ="lineartechnology,ltc2488" , .data = &spidev_of_check }, { .compatible ="lwn,bk4" , .data = &spidev_of_check }, { .compatible ="menlo,m53cpld" , .data = &spidev_of_check },
Signature · 1 line
2.34.1
Mark Brown
maintainerRe: (subset) [PATCH RESEND v3 2/3] spi: spidev: Add an entry for elgin,jg10309-01
Quoted 6 lines · Fabio Estevam
The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. The marking on the LCD is JG10309-01.
Add the "elgin,jg10309-01" compatible string.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[2/3] spi: spidev: Add an entry for elgin,jg10309-01
commit: 5f3eee1eef5d0edd23d8ac0974f56283649a1512
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
PATCH RESEND v3 3/3 ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device
In reply to Fabio EstevamThere is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
There is a JG10309-01 LCD controlled via SPI though.
Properly describe it by adding the "elgin,jg10309-01" compatible string.
---
Changes since v1:
- Use a more specific compatible string. (Conor)
arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts +2 -2
@@ -168,8 +168,8 @@ &spi { pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>; status = "okay"; - dh2228fv: dac@0 { - compatible = "rohm,dh2228fv"; + display: display@0 { + compatible = "elgin,jg10309-01"; reg = <0>; spi-max-frequency = <24000000>; spi-cpha;
Signature · 1 line
2.34.1
Mark Brown
maintainerQuoted 2 lines · Fabio Estevam
The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. The marking on the LCD is JG10309-01.
Is there some reason why this is v2 and not v3? b4 gets terribly confused about what version of the series I might want.
Hi Mark,
Quoted 7 lines · Mark Brown
Quoted 2 lines · Fabio Estevam
The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. The marking on the LCD is JG10309-01.
Is there some reason why this is v2 and not v3? b4 gets terribly confused about what version of the series I might want.
That was my mistake, sorry.
I can resend the series as v4 to avoid confusion if needed.
Mark Brown
maintainerQuoted 8 lines · Fabio Estevam
Quoted 2 lines · Mark Brown
Is there some reason why this is v2 and not v3? b4 gets terribly confused about what version of the series I might want.
That was my mistake, sorry.
I can resend the series as v4 to avoid confusion if needed.
Please.