wifi: iwlwifi: Fix eMLSR band comparison.
PATCH 1/2 wifi: iwlwifi: Fix eMLSR band comparison.
From: Ben Greear <[email protected]>
Do not make assumptions about what band 'a' or 'b' are on. And add new reason code for when eMLSR is disabled due to band.
--- drivers/net/wireless/intel/iwlwifi/mvm/link.c | 13 ++++++++++--- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 ++ 2 files changed, 12 insertions(+), 3 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/link.c +10 -3
@@ -16,6 +16,7 @@ HOW(EXIT_LOW_RSSI) \ HOW(EXIT_COEX) \ HOW(EXIT_BANDWIDTH) \ + HOW(EXIT_BAND) \ HOW(EXIT_CSA) \ HOW(EXIT_LINK_USAGE)
@@ -750,11 +751,17 @@ bool iwl_mvm_mld_valid_link_pair(struct ieee80211_vif *vif, iwl_mvm_esr_disallowed_with_link(mvm, vif, b, false))return false; -if (a->chandef->width != b->chandef->width || - !(a->chandef->chan->band ==NL80211_BAND_6GHZ && - b->chandef->chan->band ==NL80211_BAND_5GHZ )) +if (a->chandef->width != b->chandef->width) ret |=IWL_MVM_ESR_EXIT_BANDWIDTH ; +/* Only supports 5g and 6g bands at the moment */ +if (((a->chandef->chan->band !=NL80211_BAND_6GHZ ) && + (a->chandef->chan->band !=NL80211_BAND_5GHZ )) || + ((b->chandef->chan->band !=NL80211_BAND_6GHZ ) && + (b->chandef->chan->band !=NL80211_BAND_5GHZ )) || + (a->chandef->chan->band == b->chandef->chan->band)) + ret |=IWL_MVM_ESR_EXIT_BAND ; +if (ret) { IWL_DEBUG_INFO(mvm, "Links %d and %d are not a valid pair for EMLSR, a->chwidth: %d b: %d band-a: %d band-b: %d\n",
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +2 -0
@@ -368,6 +368,7 @@ struct iwl_mvm_vif_link_info {* preventing the enablement of EMLSR * @IWL_MVM_ESR_EXIT_CSA: CSA happened, so exit EMLSR * @IWL_MVM_ESR_EXIT_LINK_USAGE: Exit EMLSR due to low tpt on secondary link +* @IWL_MVM_ESR_EXIT_BAND: Exit EMLSR due to incompatible Bands */ enum iwl_mvm_esr_state {IWL_MVM_ESR_BLOCKED_PREVENTION =0x1 ,
@@ -382,6 +383,7 @@ enum iwl_mvm_esr_state {IWL_MVM_ESR_EXIT_BANDWIDTH =0x80000 ,IWL_MVM_ESR_EXIT_CSA =0x100000 ,IWL_MVM_ESR_EXIT_LINK_USAGE =0x200000 , + IWL_MVM_ESR_EXIT_BAND = 0x400000, };#define IWL_MVM_BLOCK_ESR_REASONS 0xffff
Signature · 1 line
2.42.0
PATCH 2/2 wifi: iwlwifi: Fix emlsr exit due to tput sampling too fast.
From: Ben Greear <[email protected]>
I noticed that the tput check was running very often (and often right after we entered emlsr mode), putting the radio in and out of emlsr mode often. That caused link instability as well as poor performance. Add timer so that we only
check stats after at least 5 seconds.
--- drivers/net/wireless/intel/iwlwifi/mvm/link.c | 5 +++++ drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 1 + drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 12 ++++++++++-- 3 files changed, 16 insertions(+), 2 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/link.c +5 -0
@@ -1112,6 +1112,11 @@ static void iwl_mvm_esr_unblocked(struct iwl_mvm *mvm,IWL_DEBUG_INFO (mvm,"EMLSR is unblocked\n" ); +/* Don't block based on tput until at least our sample period, +* by faking that we sampled just now. +*/ + mvm->esr_tpt_ts = jiffies; +/* If we exited due to an EXIT reason, and the exit was in less than * 30 seconds, then a MLO scan was scheduled already. */
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +1 -0
@@ -1101,6 +1101,7 @@ struct iwl_mvm {unsigned long init_status;unsigned long status; +unsigned long esr_tpt_ts;/* last time we compared tput for ESR */ u32 queue_sync_cookie;unsigned long queue_sync_state;
drivers/net/wireless/intel/iwlwifi/mvm/rx.c +10 -2
@@ -1035,6 +1035,8 @@ iwl_mvm_stat_iterator_all_links(struct iwl_mvm *mvm,#define SEC_LINK_MIN_PERC 10#define SEC_LINK_MIN_TX 3000#define SEC_LINK_MIN_RX 400 +/* Compare tput over this interval to determine in/out of ESR mode */ +#define MVM_ESR_TPT_INTERVAL (5 * HZ)static void iwl_mvm_update_esr_mode_tpt (struct iwl_mvm *mvm) {
@@ -1061,6 +1063,10 @@ static void iwl_mvm_update_esr_mode_tpt(struct iwl_mvm *mvm)if (!mvmsta->mpdu_counters)return ; +if (!time_after (jiffies, mvm->esr_tpt_ts +MVM_ESR_TPT_INTERVAL )) +return ;/* check back later */ + mvm->esr_tpt_ts = jiffies; +/* Get the FW ID of the secondary link */ sec_link =iwl_mvm_get_other_link (bss_vif,iwl_mvm_get_primary_link (bss_vif));
@@ -1084,6 +1090,8 @@ static void iwl_mvm_update_esr_mode_tpt(struct iwl_mvm *mvm)/* * In EMLSR we have statistics every 5 seconds, so we can reset * the counters upon every statistics notification. +* NOTE: This is not actually correct, I see this method called +* often. Thus the back-off timer 'esr_tpt_ts' above. --Ben */ memset (mvmsta->mpdu_counters[q].per_link,0 ,sizeof (mvmsta->mpdu_counters[q].per_link));
@@ -1091,8 +1099,8 @@ static void iwl_mvm_update_esr_mode_tpt(struct iwl_mvm *mvm)spin_unlock_bh (&mvmsta->mpdu_counters[q].lock); } -IWL_DEBUG_STATS (mvm,"total Tx MPDUs: %ld. total Rx MPDUs: %ld\n" , - total_tx, total_rx); +IWL_DEBUG_INFO (mvm,"EMLSR: total Tx MPDUs: %ld. Rx: %ld sec-link tx: %ld rx: %ld mvm-tput-thresh: %d\n" , + total_tx, total_rx, sec_link_tx, sec_link_rx,IWL_MVM_ENTER_ESR_TPT_THRESH );/* If we don't have enough MPDUs - exit EMLSR */ if (total_tx < IWL_MVM_ENTER_ESR_TPT_THRESH &&
Signature · 1 line
2.42.0
Quoted 79 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, 28 August 2024 23:26
To: [email protected]
Cc: Ben Greear <[email protected]>
Subject: [PATCH 1/2] wifi: iwlwifi: Fix eMLSR band comparison.From: Ben Greear <[email protected]>
Do not make assumptions about what band 'a' or 'b' are on. And add new reason code for when eMLSR is disabled due to band.
Signed-off-by Ben Greear <[email protected]>--- drivers/net/wireless/intel/iwlwifi/mvm/link.c | 13 ++++++++++--- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 ++ 2 files changed, 12 insertions(+), 3 deletions(-)drivers/net/wireless/intel/iwlwifi/mvm/link.c +10
-3@@ -16,6 +16,7 @@ HOW(EXIT_LOW_RSSI) \ HOW(EXIT_COEX) \ HOW(EXIT_BANDWIDTH) \ + HOW(EXIT_BAND) \ HOW(EXIT_CSA) \ HOW(EXIT_LINK_USAGE)@@ -750,11 +751,17 @@ bool iwl_mvm_mld_valid_link_pair(structieee80211_vif *vif, iwl_mvm_esr_disallowed_with_link(mvm, vif, b, false)) return false; -if (a->chandef->width != b->chandef->width || - !(a->chandef->chan->band ==NL80211_BAND_6GHZ && - b->chandef->chan->band ==NL80211_BAND_5GHZ )) +if (a->chandef->width != b->chandef->width) ret |=IWL_MVM_ESR_EXIT_BANDWIDTH ; +/* Only supports 5g and 6g bands at the moment */ +if (((a->chandef->chan->band !=NL80211_BAND_6GHZ ) && + (a->chandef->chan->band !=NL80211_BAND_5GHZ )) || + ((b->chandef->chan->band !=NL80211_BAND_6GHZ ) && + (b->chandef->chan->band !=NL80211_BAND_5GHZ )) || + (a->chandef->chan->band == b->chandef->chan->band)) + ret |=IWL_MVM_ESR_EXIT_BAND ; +if (ret) { IWL_DEBUG_INFO(mvm,"Links %d and %d are not a valid pair for EMLSR, a-
Quoted 1 line
chwidth: %d b: %d band-a: %d band-b: %d\n", diff --git
a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.hb/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
indexac4e135ed91b..22bec9ca46bb100644drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +0
-0@@ -368,6 +368,7 @@ struct iwl_mvm_vif_link_info {* preventing the enablement of EMLSR * @IWL_MVM_ESR_EXIT_CSA: CSA happened, so exit EMLSR * @IWL_MVM_ESR_EXIT_LINK_USAGE: Exit EMLSR due to low tpt on secondary link
+ * @IWL_MVM_ESR_EXIT_BAND: Exit EMLSR due to incompatible Bands */
enumiwl_mvm_esr_state{drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +1
-1IWL_MVM_ESR_BLOCKED_PREVENTION = 0x1,@@ -382,6 +383,7 @@ enum iwl_mvm_esr_state {IWL_MVM_ESR_EXIT_BANDWIDTH =0x80000 ,IWL_MVM_ESR_EXIT_CSA =0x100000 ,IWL_MVM_ESR_EXIT_LINK_USAGE =0x200000 , + IWL_MVM_ESR_EXIT_BAND = 0x400000, };#define IWL_MVM_BLOCK_ESR_REASONS 0xffff --
Quoted 2 lines
2.42.0
Hi Ben.
It is actually required that a (the better link) will be on 6 GHz and b on 5 GHz
Regarding the new exit reason, it is not really needed as we can easily differentiate between the cases (from other logs)
NACK.
Thanks,
Miri
Quoted 77 lines · Miriam Rachel
Quoted 77 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, 28 August 2024 23:26
To: [email protected]
Cc: Ben Greear <[email protected]>
Subject: [PATCH 1/2] wifi: iwlwifi: Fix eMLSR band comparison.From: Ben Greear <[email protected]>
Do not make assumptions about what band 'a' or 'b' are on. And add new reason code for when eMLSR is disabled due to band.
Signed-off-by Ben Greear <[email protected]>--- drivers/net/wireless/intel/iwlwifi/mvm/link.c | 13 ++++++++++--- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 ++ 2 files changed, 12 insertions(+), 3 deletions(-)drivers/net/wireless/intel/iwlwifi/mvm/link.c +10
-3@@ -16,6 +16,7 @@ HOW(EXIT_LOW_RSSI) \ HOW(EXIT_COEX) \ HOW(EXIT_BANDWIDTH) \ + HOW(EXIT_BAND) \ HOW(EXIT_CSA) \ HOW(EXIT_LINK_USAGE)@@ -750,11 +751,17 @@ bool iwl_mvm_mld_valid_link_pair(structieee80211_vif *vif, iwl_mvm_esr_disallowed_with_link(mvm, vif, b, false)) return false; -if (a->chandef->width != b->chandef->width || - !(a->chandef->chan->band ==NL80211_BAND_6GHZ && - b->chandef->chan->band ==NL80211_BAND_5GHZ )) +if (a->chandef->width != b->chandef->width) ret |=IWL_MVM_ESR_EXIT_BANDWIDTH ; +/* Only supports 5g and 6g bands at the moment */ +if (((a->chandef->chan->band !=NL80211_BAND_6GHZ ) && + (a->chandef->chan->band !=NL80211_BAND_5GHZ )) || + ((b->chandef->chan->band !=NL80211_BAND_6GHZ ) && + (b->chandef->chan->band !=NL80211_BAND_5GHZ )) || + (a->chandef->chan->band == b->chandef->chan->band)) + ret |=IWL_MVM_ESR_EXIT_BAND ; +if (ret) { IWL_DEBUG_INFO(mvm,"Links %d and %d are not a valid pair for EMLSR, a-
Quoted 1 line
chwidth: %d b: %d band-a: %d band-b: %d\n", diff --git
a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.hb/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
indexac4e135ed91b..22bec9ca46bb100644drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +0
-0@@ -368,6 +368,7 @@ struct iwl_mvm_vif_link_info {* preventing the enablement of EMLSR * @IWL_MVM_ESR_EXIT_CSA: CSA happened, so exit EMLSR * @IWL_MVM_ESR_EXIT_LINK_USAGE: Exit EMLSR due to low tpt on secondary link
+ * @IWL_MVM_ESR_EXIT_BAND: Exit EMLSR due to incompatible Bands */
enumiwl_mvm_esr_state{
IWL_MVM_ESR_BLOCKED_PREVENTION=0x1,drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +1
-0@@ -382,6 +383,7 @@ enum iwl_mvm_esr_state {IWL_MVM_ESR_EXIT_BANDWIDTH =0x80000 ,IWL_MVM_ESR_EXIT_CSA =0x100000 ,IWL_MVM_ESR_EXIT_LINK_USAGE =0x200000 , + IWL_MVM_ESR_EXIT_BAND = 0x400000, };
Quoted 8 lines
Quoted 4 lines
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +0
-1#define IWL_MVM_BLOCK_ESR_REASONS 0xffff --2.42.0
Hi Ben.
It is actually required that a (the better link) will be on 6 GHz and b on 5 GHz
Regarding the new exit reason, it is not really needed as we can easily differentiate between the cases (from other logs)
Hello Miri,
I tested this patch, and it fixed problems for me when I ran a test that created interfering traffic on 5ghz and then later on 6Ghz. I expected eMLSR mode to stay active no matter where the interfering traffic existed. With this patch, and a few others I posted, the be200 then works fairly well.
6Ghz is not always better, for instance in case where it is congested with external traffic.
Can you please let me know *why* you think the better link must always be 6ghz in this case?
Thanks,
Ben
Quoted 5 lines
NACK.
Thanks,
Miri
Signature · 2 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com
Quoted 94 lines · Ben Greear
Quoted 77 lines · Miriam Rachel
Quoted 77 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, 28 August 2024 23:26
To: [email protected]
Cc: Ben Greear <[email protected]>
Subject: [PATCH 1/2] wifi: iwlwifi: Fix eMLSR band comparison.From: Ben Greear <[email protected]>
Do not make assumptions about what band 'a' or 'b' are on. And add new reason code for when eMLSR is disabled due to band.
Signed-off-by Ben Greear <[email protected]>---
drivers/net/wireless/intel/iwlwifi/mvm/link.c| 13 ++++++++++--- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 ++2 files changed, 12 insertions(+), 3 deletions(-)drivers/net/wireless/intel/iwlwifi/mvm/link.c +10
-3@@ -16,6 +16,7 @@ HOW(EXIT_LOW_RSSI) \ HOW(EXIT_COEX) \ HOW(EXIT_BANDWIDTH) \ + HOW(EXIT_BAND) \ HOW(EXIT_CSA) \ HOW(EXIT_LINK_USAGE)@@ -750,11 +751,17 @@ bool iwl_mvm_mld_valid_link_pair(structieee80211_vif *vif, iwl_mvm_esr_disallowed_with_link(mvm, vif, b, false)) return false; - if (a->chandef->width != b->chandef->width || - !(a->chandef->chan->band == NL80211_BAND_6GHZ && - b->chandef->chan->band == NL80211_BAND_5GHZ)) + if (a->chandef->width != b->chandef->width) ret |= IWL_MVM_ESR_EXIT_BANDWIDTH; + /* Only supports 5g and 6g bands at the moment */ + if (((a->chandef->chan->band != NL80211_BAND_6GHZ) && + (a->chandef->chan->band != NL80211_BAND_5GHZ)) || + ((b->chandef->chan->band != NL80211_BAND_6GHZ) && + (b->chandef->chan->band != NL80211_BAND_5GHZ)) || + (a->chandef->chan->band == b->chandef->chan->band)) + ret |= IWL_MVM_ESR_EXIT_BAND; + if (ret) { IWL_DEBUG_INFO(mvm,"Links %d and %d are not a valid pair for EMLSR, a-
Quoted 1 line
chwidth: %d b: %d band-a: %d band-b: %d\n", diff --git
a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.hb/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
indexac4e135ed91b..22bec9ca46bb100644drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +0
-0@@ -368,6 +368,7 @@ struct iwl_mvm_vif_link_info { * preventing the enablement of EMLSR * @IWL_MVM_ESR_EXIT_CSA: CSA happened, so exit EMLSR * @IWL_MVM_ESR_EXIT_LINK_USAGE: Exit EMLSR due to low tpt on secondarylink
+ * @IWL_MVM_ESR_EXIT_BAND: Exit EMLSR due to incompatible Bands */
enumiwl_mvm_esr_state{ IWL_MVM_ESR_BLOCKED_PREVENTION =0x1,drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +1
-0@@ -382,6 +383,7 @@ enum iwl_mvm_esr_state { IWL_MVM_ESR_EXIT_BANDWIDTH = 0x80000, IWL_MVM_ESR_EXIT_CSA = 0x100000, IWL_MVM_ESR_EXIT_LINK_USAGE = 0x200000, + IWL_MVM_ESR_EXIT_BAND = 0x400000, };Quoted 8 lines
Quoted 4 lines
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +0
-0#define IWL_MVM_BLOCK_ESR_REASONS 0xffffSignature · 1 line
2.42.0Hi Ben.
It is actually required that a (the better link) will be on 6 GHz and b on 5 GHz
Regarding the new exit reason, it is not really needed as we can easily differentiate between the cases (from other logs)Hello Miri,
I tested this patch, and it fixed problems for me when I ran a test that created interfering traffic on 5ghz and then later on 6Ghz. I expected eMLSR mode to stay active no matter where the interfering traffic existed. With this patch, and a few others I posted, the be200 then works fairly well.
Quoted 4 lines
6Ghz is not always better, for instance in case where it is congested with external traffic.
Can you please let me know *why* you think the better link must always be 6ghz in this case?
Hello Miriam,
I wanted to check to see if you still consider this patch invalid? If so, I'll adjust it to work better as out-of-tree patch and add it to my pile.
If you think core logic is fine but the patch needs some tweaks, please let me know your suggestions.
Thanks,
Ben
Korenblit, Miriam Rachel
maintainerQuoted 114 lines
-----Original Message-----
From: Ben Greear <[email protected]>
Sent: Tuesday, 10 December 2024 21:55
To: Korenblit, Miriam Rachel <[email protected]>; linux- [email protected]
Subject: Re: [PATCH 1/2] wifi: iwlwifi: Fix eMLSR band comparison.Quoted 58 lines · Ben Greear
Quoted 57 lines · Miriam Rachel
Quoted 57 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, 28 August 2024 23:26
To: [email protected]
Cc: Ben Greear <[email protected]>
Subject: [PATCH 1/2] wifi: iwlwifi: Fix eMLSR band comparison.From: Ben Greear <[email protected]>
Do not make assumptions about what band 'a' or 'b' are on. And add new reason code for when eMLSR is disabled due to band.
Signed-off-by Ben Greear <[email protected]>---
drivers/net/wireless/intel/iwlwifi/mvm/link.c| 13 ++++++++++--- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 ++2 files changed, 12 insertions(+), 3 deletions(-)drivers/net/wireless/intel/iwlwifi/mvm/link.c +10
-3@@ -16,6 +16,7 @@ HOW(EXIT_LOW_RSSI) \ HOW(EXIT_COEX) \ HOW(EXIT_BANDWIDTH) \ + HOW(EXIT_BAND) \ HOW(EXIT_CSA) \ HOW(EXIT_LINK_USAGE)@@ -750,11 +751,17 @@ bool iwl_mvm_mld_valid_link_pair(structieee80211_vif *vif, iwl_mvm_esr_disallowed_with_link(mvm, vif, b, false)) return false; - if (a->chandef->width != b->chandef->width || - !(a->chandef->chan->band == NL80211_BAND_6GHZ && - b->chandef->chan->band == NL80211_BAND_5GHZ)) + if (a->chandef->width != b->chandef->width) ret |= IWL_MVM_ESR_EXIT_BANDWIDTH; + /* Only supports 5g and 6g bands at the moment */ + if (((a->chandef->chan->band != NL80211_BAND_6GHZ) && + (a->chandef->chan->band != NL80211_BAND_5GHZ)) || + ((b->chandef->chan->band != NL80211_BAND_6GHZ) && + (b->chandef->chan->band != NL80211_BAND_5GHZ)) || + (a->chandef->chan->band == b->chandef->chan->band)) + ret |= IWL_MVM_ESR_EXIT_BAND; + if (ret) { IWL_DEBUG_INFO(mvm,"Links %d and %d are not a valid pair for EMLSR, a-
Quoted 1 line
chwidth: %d b: %d band-a: %d band-b: %d\n", diff --git
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.hb/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
indexac4e135ed91b..22bec9ca46bb100644drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +0
-0@@ -368,6 +368,7 @@ struct iwl_mvm_vif_link_info {Quoted 8 lines
Quoted 8 lines
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +0
-0* preventing the enablement of EMLSR * @IWL_MVM_ESR_EXIT_CSA: CSA happened, so exit EMLSR * @IWL_MVM_ESR_EXIT_LINK_USAGE: Exit EMLSR due to low tpt onsecondary link
+ * @IWL_MVM_ESR_EXIT_BAND: Exit EMLSR due to incompatible Bands */
enumiwl_mvm_esr_state{ IWL_MVM_ESR_BLOCKED_PREVENTION =0x1, @@ -382,6 +383,7@@
Quoted 17 lines
Quoted 11 lines
Quoted 11 lines
enum
iwl_mvm_esr_state{
IWL_MVM_ESR_EXIT_BANDWIDTH =0x80000,
IWL_MVM_ESR_EXIT_CSA =0x100000,
IWL_MVM_ESR_EXIT_LINK_USAGE =0x200000,
+ IWL_MVM_ESR_EXIT_BAND =0x400000,
};#define
IWL_MVM_BLOCK_ESR_REASONS0xffff
--
2.42.0Quoted 5 lines
Hi Ben.
It is actually required that a (the better link) will be on 6 GHz and b on 5 GHz Regarding the new exit reason, it is not really needed as we can easily differentiate between the cases (from other logs)
Quoted 6 lines
Hello Miri,
I tested this patch, and it fixed problems for me when I ran a test that created interfering traffic on 5ghz and then later on 6Ghz. I expected eMLSR mode to stay active no matter where the interfering traffic existed. With this patch, and a few others I posted, the be200 then
works fairly well.
Quoted 5 lines
6Ghz is not always better, for instance in case where it is congested with external traffic.
Can you please let me know *why* you think the better link must always be
6ghz in this case?
Quoted 7 lines
Hello Miriam,
I wanted to check to see if you still consider this patch invalid? If so, I'll adjust it to work better as out-of-tree patch and add it to my pile.
If you think core logic is fine but the patch needs some tweaks, please let me know your suggestions.
We are just changing this logic internally
(and allow also 2.4 GHz)
So I am not going to take it.
Quoted 4 lines
Thanks,
Ben