crypto: ccp: do not request interrupt on cmd completion when irqs disabled
Subsystems (3)
PATCH 1/1 crypto: ccp: do not request interrupt on cmd completion when irqs disabled
From: Amit Shah <[email protected]>
While sending a command to the PSP, we always requested an interrupt from the PSP after command completion. This worked for most cases. For the special case of irqs being disabled -- e.g. when running within crashdump or kexec contexts, we should not set the SEV_CMDRESP_IOC flag, so the PSP knows to not attempt interrupt delivery.
--- drivers/crypto/ccp/sev-dev.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/crypto/ccp/sev-dev.c +12 -1
@@ -910,7 +910,18 @@ static int __sev_do_cmd_locked(int cmd, void *data, int *psp_ret) sev->int_rcvd =0 ; - reg =FIELD_PREP (SEV_CMDRESP_CMD , cmd) |SEV_CMDRESP_IOC ; + reg =FIELD_PREP (SEV_CMDRESP_CMD , cmd); + +/* +* If invoked during panic handling, local interrupts are disabled so +* the PSP command completion interrupt can't be used. +* sev_wait_cmd_ioc() already checks for interrupts disabled and +* polls for PSP command completion. Ensure we do not request an +* interrupt from the PSP if irqs disabled. +*/ +if (!irqs_disabled ()) + reg |=SEV_CMDRESP_IOC ; +iowrite32 (reg, sev->io_regs + sev->vdata->cmdresp_reg);/* wait for command completion */
Signature · 1 line
2.46.0
Herbert Xu
maintainerQuoted 8 lines · Amit Shah
From: Amit Shah <[email protected]>
While sending a command to the PSP, we always requested an interrupt from the PSP after command completion. This worked for most cases. For the special case of irqs being disabled -- e.g. when running within crashdump or kexec contexts, we should not set the
SEV_CMDRESP_IOCflag, so the PSP knows to not attempt interrupt delivery.
Quoted 7 lines
Fixes 8ef979584ea8 ("crypto: ccp: Add panic notifier for SEV/SNP firmware shutdown on kdump")Based-on-patch-by Tom Lendacky <[email protected]>Signed-off-by Amit Shah <[email protected]>--- drivers/crypto/ccp/sev-dev.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt