net: ag71xx: update FIFO bits and descriptions
Subsystems (3)
PATCH v2 1/1 net: ag71xx: update FIFO bits and descriptions
Taken from QCA SDK. No functional difference as same bits get applied.
---
v2: forgot to send to netdev
drivers/net/ethernet/atheros/ag71xx.c | 48 +++++++++++++-------------- 1 file changed, 24 insertions(+), 24 deletions(-)
drivers/net/ethernet/atheros/ag71xx.c +24 -24
@@ -149,11 +149,11 @@#define FIFO_CFG4_MC BIT(8)/* Multicast Packet */ #define FIFO_CFG4_BC BIT(9)/* Broadcast Packet */ #define FIFO_CFG4_DR BIT(10)/* Dribble */ -#define FIFO_CFG4_LE BIT(11)/* Long Event */ -#define FIFO_CFG4_CF BIT(12)/* Control Frame */ -#define FIFO_CFG4_PF BIT(13)/* Pause Frame */ -#define FIFO_CFG4_UO BIT(14)/* Unsupported Opcode */ -#define FIFO_CFG4_VT BIT(15)/* VLAN tag detected */ +#define FIFO_CFG4_CF BIT(11)/* Control Frame */ +#define FIFO_CFG4_PF BIT(12)/* Pause Frame */ +#define FIFO_CFG4_UO BIT(13)/* Unsupported Opcode */ +#define FIFO_CFG4_VT BIT(14)/* VLAN tag detected */ +#define FIFO_CFG4_LE BIT(15)/* Long Event */ #define FIFO_CFG4_FT BIT(16)/* Frame Truncated */ #define FIFO_CFG4_UC BIT(17)/* Unicast Packet */ #define FIFO_CFG4_INIT (FIFO_CFG4_DE | FIFO_CFG4_DV | FIFO_CFG4_FC | \
@@ -168,28 +168,28 @@#define FIFO_CFG5_DV BIT(1)/* RX_DV Event */ #define FIFO_CFG5_FC BIT(2)/* False Carrier */ #define FIFO_CFG5_CE BIT(3)/* Code Error */ -#define FIFO_CFG5_LM BIT(4)/* Length Mismatch */ -#define FIFO_CFG5_LO BIT(5)/* Length Out of Range */ -#define FIFO_CFG5_OK BIT(6)/* Packet is OK */ -#define FIFO_CFG5_MC BIT(7)/* Multicast Packet */ -#define FIFO_CFG5_BC BIT(8)/* Broadcast Packet */ -#define FIFO_CFG5_DR BIT(9)/* Dribble */ -#define FIFO_CFG5_CF BIT(10)/* Control Frame */ -#define FIFO_CFG5_PF BIT(11)/* Pause Frame */ -#define FIFO_CFG5_UO BIT(12)/* Unsupported Opcode */ -#define FIFO_CFG5_VT BIT(13)/* VLAN tag detected */ -#define FIFO_CFG5_LE BIT(14)/* Long Event */ -#define FIFO_CFG5_FT BIT(15)/* Frame Truncated */ -#define FIFO_CFG5_16 BIT(16)/* unknown */ -#define FIFO_CFG5_17 BIT(17)/* unknown */ +#define FIFO_CFG5_CR BIT(4)/* CRC error */ +#define FIFO_CFG5_LM BIT(5)/* Length Mismatch */ +#define FIFO_CFG5_LO BIT(6)/* Length Out of Range */ +#define FIFO_CFG5_OK BIT(7)/* Packet is OK */ +#define FIFO_CFG5_MC BIT(8)/* Multicast Packet */ +#define FIFO_CFG5_BC BIT(9)/* Broadcast Packet */ +#define FIFO_CFG5_DR BIT(10)/* Dribble */ +#define FIFO_CFG5_CF BIT(11)/* Control Frame */ +#define FIFO_CFG5_PF BIT(12)/* Pause Frame */ +#define FIFO_CFG5_UO BIT(13)/* Unsupported Opcode */ +#define FIFO_CFG5_VT BIT(14)/* VLAN tag detected */ +#define FIFO_CFG5_LE BIT(15)/* Long Event */ +#define FIFO_CFG5_FT BIT(16)/* Frame Truncated */ +#define FIFO_CFG5_UC BIT(17)/* Unicast Packet */ #define FIFO_CFG5_SF BIT(18)/* Short Frame */ #define FIFO_CFG5_BM BIT(19)/* Byte Mode */ #define FIFO_CFG5_INIT (FIFO_CFG5_DE | FIFO_CFG5_DV | FIFO_CFG5_FC | \ - FIFO_CFG5_CE | FIFO_CFG5_LO | FIFO_CFG5_OK | \ - FIFO_CFG5_MC | FIFO_CFG5_BC | FIFO_CFG5_DR | \ - FIFO_CFG5_CF | FIFO_CFG5_PF | FIFO_CFG5_VT | \ - FIFO_CFG5_LE | FIFO_CFG5_FT | FIFO_CFG5_16 | \ - FIFO_CFG5_17 | FIFO_CFG5_SF) + FIFO_CFG5_CE | FIFO_CFG5_LM | FIFO_CFG5_L0 | \ + FIFO_CFG5_OK | FIFO_CFG5_MC | FIFO_CFG5_BC | \ + FIFO_CFG5_DR | FIFO_CFG5_CF | FIFO_CFG5_UO | \ + FIFO_CFG5_VT | FIFO_CFG5_LE | FIFO_CFG5_FT | \ + FIFO_CFG5_UC | FIFO_CFG5_SF)#define AG71XX_REG_TX_CTRL 0x0180#define TX_CTRL_TXE BIT(0)/* Tx Enable */
Signature · 1 line
2.46.0
Simon Horman
reviewerQuoted 60 lines · Rosen Penev
Taken from QCA SDK. No functional difference as same bits get applied.
Signed-off-by Rosen Penev <[email protected]>---
v2: forgot to send to netdevdrivers/net/ethernet/atheros/ag71xx.c | 48 +++++++++++++-------------- 1 file changed, 24 insertions(+), 24 deletions(-)drivers/net/ethernet/atheros/ag71xx.c +18
-19@@ -149,11 +149,11 @@#define FIFO_CFG4_MC BIT(8)/* Multicast Packet */ #define FIFO_CFG4_BC BIT(9)/* Broadcast Packet */ #define FIFO_CFG4_DR BIT(10)/* Dribble */ -#define FIFO_CFG4_LE BIT(11)/* Long Event */ -#define FIFO_CFG4_CF BIT(12)/* Control Frame */ -#define FIFO_CFG4_PF BIT(13)/* Pause Frame */ -#define FIFO_CFG4_UO BIT(14)/* Unsupported Opcode */ -#define FIFO_CFG4_VT BIT(15)/* VLAN tag detected */ +#define FIFO_CFG4_CF BIT(11)/* Control Frame */ +#define FIFO_CFG4_PF BIT(12)/* Pause Frame */ +#define FIFO_CFG4_UO BIT(13)/* Unsupported Opcode */ +#define FIFO_CFG4_VT BIT(14)/* VLAN tag detected */ +#define FIFO_CFG4_LE BIT(15)/* Long Event */ #define FIFO_CFG4_FT BIT(16)/* Frame Truncated */ #define FIFO_CFG4_UC BIT(17)/* Unicast Packet */ #define FIFO_CFG4_INIT (FIFO_CFG4_DE | FIFO_CFG4_DV | FIFO_CFG4_FC | \@@ -168,28 +168,28 @@#define FIFO_CFG5_DV BIT(1)/* RX_DV Event */ #define FIFO_CFG5_FC BIT(2)/* False Carrier */ #define FIFO_CFG5_CE BIT(3)/* Code Error */ -#define FIFO_CFG5_LM BIT(4)/* Length Mismatch */ -#define FIFO_CFG5_LO BIT(5)/* Length Out of Range */ -#define FIFO_CFG5_OK BIT(6)/* Packet is OK */ -#define FIFO_CFG5_MC BIT(7)/* Multicast Packet */ -#define FIFO_CFG5_BC BIT(8)/* Broadcast Packet */ -#define FIFO_CFG5_DR BIT(9)/* Dribble */ -#define FIFO_CFG5_CF BIT(10)/* Control Frame */ -#define FIFO_CFG5_PF BIT(11)/* Pause Frame */ -#define FIFO_CFG5_UO BIT(12)/* Unsupported Opcode */ -#define FIFO_CFG5_VT BIT(13)/* VLAN tag detected */ -#define FIFO_CFG5_LE BIT(14)/* Long Event */ -#define FIFO_CFG5_FT BIT(15)/* Frame Truncated */ -#define FIFO_CFG5_16 BIT(16)/* unknown */ -#define FIFO_CFG5_17 BIT(17)/* unknown */ +#define FIFO_CFG5_CR BIT(4)/* CRC error */ +#define FIFO_CFG5_LM BIT(5)/* Length Mismatch */ +#define FIFO_CFG5_LO BIT(6)/* Length Out of Range */ +#define FIFO_CFG5_OK BIT(7)/* Packet is OK */ +#define FIFO_CFG5_MC BIT(8)/* Multicast Packet */ +#define FIFO_CFG5_BC BIT(9)/* Broadcast Packet */ +#define FIFO_CFG5_DR BIT(10)/* Dribble */ +#define FIFO_CFG5_CF BIT(11)/* Control Frame */ +#define FIFO_CFG5_PF BIT(12)/* Pause Frame */ +#define FIFO_CFG5_UO BIT(13)/* Unsupported Opcode */ +#define FIFO_CFG5_VT BIT(14)/* VLAN tag detected */ +#define FIFO_CFG5_LE BIT(15)/* Long Event */ +#define FIFO_CFG5_FT BIT(16)/* Frame Truncated */
drivers/net/ethernet/atheros/ag71xx.c line 188
Quoted 10 lines
drivers/net/ethernet/atheros/ag71xx.c +2
-5+#define FIFO_CFG5_UC BIT(17)/* Unicast Packet */ #define FIFO_CFG5_SF BIT(18)/* Short Frame */ #define FIFO_CFG5_BM BIT(19)/* Byte Mode */ #define FIFO_CFG5_INIT (FIFO_CFG5_DE | FIFO_CFG5_DV | FIFO_CFG5_FC | \ - FIFO_CFG5_CE | FIFO_CFG5_LO | FIFO_CFG5_OK | \ - FIFO_CFG5_MC | FIFO_CFG5_BC | FIFO_CFG5_DR | \ - FIFO_CFG5_CF | FIFO_CFG5_PF | FIFO_CFG5_VT | \ - FIFO_CFG5_LE | FIFO_CFG5_FT | FIFO_CFG5_16 | \ - FIFO_CFG5_17 | FIFO_CFG5_SF) + FIFO_CFG5_CE | FIFO_CFG5_LM | FIFO_CFG5_L0 | \
FIFO_CFG5_LO
drivers/net/ethernet/atheros/ag71xx.c line 195
Quoted 7 lines
drivers/net/ethernet/atheros/ag71xx.c +4
-0+ FIFO_CFG5_OK | FIFO_CFG5_MC | FIFO_CFG5_BC | \ + FIFO_CFG5_DR | FIFO_CFG5_CF | FIFO_CFG5_UO | \ + FIFO_CFG5_VT | FIFO_CFG5_LE | FIFO_CFG5_FT | \ + FIFO_CFG5_UC | FIFO_CFG5_SF)#define AG71XX_REG_TX_CTRL 0x0180#define TX_CTRL_TXE BIT(0)/* Tx Enable */
Please consider a patch to allow compilation of this driver with COMPILE_TEST in order to increase build coverage.
Signature · 1 line
pw-bot: cr
Quoted 80 lines · Simon Horman
Quoted 60 lines · Rosen Penev
Taken from QCA SDK. No functional difference as same bits get applied.
Signed-off-by Rosen Penev <[email protected]>---
v2: forgot to send to netdevdrivers/net/ethernet/atheros/ag71xx.c | 48 +++++++++++++-------------- 1 file changed, 24 insertions(+), 24 deletions(-)drivers/net/ethernet/atheros/ag71xx.c +18
-19@@ -149,11 +149,11 @@#define FIFO_CFG4_MC BIT(8)/* Multicast Packet */ #define FIFO_CFG4_BC BIT(9)/* Broadcast Packet */ #define FIFO_CFG4_DR BIT(10)/* Dribble */ -#define FIFO_CFG4_LE BIT(11)/* Long Event */ -#define FIFO_CFG4_CF BIT(12)/* Control Frame */ -#define FIFO_CFG4_PF BIT(13)/* Pause Frame */ -#define FIFO_CFG4_UO BIT(14)/* Unsupported Opcode */ -#define FIFO_CFG4_VT BIT(15)/* VLAN tag detected */ +#define FIFO_CFG4_CF BIT(11)/* Control Frame */ +#define FIFO_CFG4_PF BIT(12)/* Pause Frame */ +#define FIFO_CFG4_UO BIT(13)/* Unsupported Opcode */ +#define FIFO_CFG4_VT BIT(14)/* VLAN tag detected */ +#define FIFO_CFG4_LE BIT(15)/* Long Event */ #define FIFO_CFG4_FT BIT(16)/* Frame Truncated */ #define FIFO_CFG4_UC BIT(17)/* Unicast Packet */ #define FIFO_CFG4_INIT (FIFO_CFG4_DE | FIFO_CFG4_DV | FIFO_CFG4_FC | \@@ -168,28 +168,28 @@#define FIFO_CFG5_DV BIT(1)/* RX_DV Event */ #define FIFO_CFG5_FC BIT(2)/* False Carrier */ #define FIFO_CFG5_CE BIT(3)/* Code Error */ -#define FIFO_CFG5_LM BIT(4)/* Length Mismatch */ -#define FIFO_CFG5_LO BIT(5)/* Length Out of Range */ -#define FIFO_CFG5_OK BIT(6)/* Packet is OK */ -#define FIFO_CFG5_MC BIT(7)/* Multicast Packet */ -#define FIFO_CFG5_BC BIT(8)/* Broadcast Packet */ -#define FIFO_CFG5_DR BIT(9)/* Dribble */ -#define FIFO_CFG5_CF BIT(10)/* Control Frame */ -#define FIFO_CFG5_PF BIT(11)/* Pause Frame */ -#define FIFO_CFG5_UO BIT(12)/* Unsupported Opcode */ -#define FIFO_CFG5_VT BIT(13)/* VLAN tag detected */ -#define FIFO_CFG5_LE BIT(14)/* Long Event */ -#define FIFO_CFG5_FT BIT(15)/* Frame Truncated */ -#define FIFO_CFG5_16 BIT(16)/* unknown */ -#define FIFO_CFG5_17 BIT(17)/* unknown */ +#define FIFO_CFG5_CR BIT(4)/* CRC error */ +#define FIFO_CFG5_LM BIT(5)/* Length Mismatch */ +#define FIFO_CFG5_LO BIT(6)/* Length Out of Range */ +#define FIFO_CFG5_OK BIT(7)/* Packet is OK */ +#define FIFO_CFG5_MC BIT(8)/* Multicast Packet */ +#define FIFO_CFG5_BC BIT(9)/* Broadcast Packet */ +#define FIFO_CFG5_DR BIT(10)/* Dribble */ +#define FIFO_CFG5_CF BIT(11)/* Control Frame */ +#define FIFO_CFG5_PF BIT(12)/* Pause Frame */ +#define FIFO_CFG5_UO BIT(13)/* Unsupported Opcode */ +#define FIFO_CFG5_VT BIT(14)/* VLAN tag detected */ +#define FIFO_CFG5_LE BIT(15)/* Long Event */ +#define FIFO_CFG5_FT BIT(16)/* Frame Truncated */ drivers/net/ethernet/atheros/ag71xx.c line 188
Quoted 10 lines
drivers/net/ethernet/atheros/ag71xx.c +2
-5+#define FIFO_CFG5_UC BIT(17)/* Unicast Packet */ #define FIFO_CFG5_SF BIT(18)/* Short Frame */ #define FIFO_CFG5_BM BIT(19)/* Byte Mode */ #define FIFO_CFG5_INIT (FIFO_CFG5_DE | FIFO_CFG5_DV | FIFO_CFG5_FC | \ - FIFO_CFG5_CE | FIFO_CFG5_LO | FIFO_CFG5_OK | \ - FIFO_CFG5_MC | FIFO_CFG5_BC | FIFO_CFG5_DR | \ - FIFO_CFG5_CF | FIFO_CFG5_PF | FIFO_CFG5_VT | \ - FIFO_CFG5_LE | FIFO_CFG5_FT | FIFO_CFG5_16 | \ - FIFO_CFG5_17 | FIFO_CFG5_SF) + FIFO_CFG5_CE | FIFO_CFG5_LM | FIFO_CFG5_L0 | \
FIFO_CFG5_LOQuoted 5 lines
drivers/net/ethernet/atheros/ag71xx.c +4
-0+FIFO_CFG5_OK |FIFO_CFG5_MC |FIFO_CFG5_BC | \ +FIFO_CFG5_DR |FIFO_CFG5_CF |FIFO_CFG5_UO | \ +FIFO_CFG5_VT |FIFO_CFG5_LE |FIFO_CFG5_FT | \ + FIFO_CFG5_UC | FIFO_CFG5_SF)
Quoted 5 lines
drivers/net/ethernet/atheros/ag71xx.c line 195
Quoted 2 lines
drivers/net/ethernet/atheros/ag71xx.c +0
-0#define AG71XX_REG_TX_CTRL 0x0180#define TX_CTRL_TXE BIT(0)/* Tx Enable */ Please consider a patch to allow compilation of this driver with
COMPILE_TESTin order to increase build coverage.
Is that just
drivers/net/ethernet/atheros/Kconfig +2 -2
@@ -6,7 +6,7 @@ config NET_VENDOR_ATHEROS bool "Atheros devices" default y - depends on (PCI || ATH79) + depends on (PCI || ATH79 || COMPILE_TEST) help If you have a network (Ethernet) card belonging to this class, say Y.
@@ -19,7 +19,7 @@ if NET_VENDOR_ATHEROS config AG71XX tristate "Atheros AR7XXX/AR9XXX built-in ethernet mac support" - depends on ATH79 + depends on ATH79 || COMPILE_TEST select PHYLINK imply NET_SELFTESTS help
Quoted 3 lines
--
pw-bot: cr
Jakub Kicinski
maintainerQuoted 3 lines · On Thu, 29 Aug 2024 10:47:01 -0700 Rosen Penev wrote:
Quoted 2 lines
Please consider a patch to allow compilation of this driver with
COMPILE_TESTin order to increase build coverage.Is that just
Aha, do that and run an allmodconfig build on x86 to make sure nothing breaks. If it's all fine please submit
Quoted 8 lines · Jakub Kicinski
Quoted 3 lines · On Thu, 29 Aug 2024 10:47:01 -0700 Rosen Penev wrote:
Quoted 2 lines
Please consider a patch to allow compilation of this driver with
COMPILE_TESTin order to increase build coverage.Is that just
Aha, do that and run an allmodconfig build on x86 to make sure nothing breaks. If it's all fine please submit
Funny enough it did break due to a mistake (L0 vs LO). I guess I'll send a series just to keep these patches together.
Simon Horman
reviewerQuoted 10 lines · Rosen Penev
Quoted 8 lines · Jakub Kicinski
Quoted 3 lines · On Thu, 29 Aug 2024 10:47:01 -0700 Rosen Penev wrote:
Quoted 2 lines
Please consider a patch to allow compilation of this driver with
COMPILE_TESTin order to increase build coverage.Is that just
Aha, do that and run an allmodconfig build on x86 to make sure nothing breaks. If it's all fine please submit
Funny enough it did break due to a mistake (L0 vs LO).
Then I'd say this exercise is a success :)
Quoted 2 lines
I guess I'll
send a series just to keep these patches together.
In general, if you have multiple patches for the same driver, for a single tree (net or net-next) I would either:
1) Send them as a series
2) Wait for one to be accepted before sending the next one
Option 1 seems appropriate here.
Simon Horman
reviewerQuoted 6 lines · Rosen Penev
Quoted 5 lines · Simon Horman
Quoted 3 lines · Rosen Penev
Taken from QCA SDK. No functional difference as same bits get applied.
Signed-off-by Rosen Penev <[email protected]>
...
Quoted 3 lines
Quoted 2 lines
Please consider a patch to allow compilation of this driver with
COMPILE_TESTin order to increase build coverage.Is that just
Of course we should test that it works, but yes, I think so.
drivers/net/ethernet/atheros/Kconfig line 9
Quoted 9 lines
drivers/net/ethernet/atheros/Kconfig +1
-1@@ -6,7 +6,7 @@ config NET_VENDOR_ATHEROS bool "Atheros devices" default y - depends on (PCI || ATH79) + depends on (PCI || ATH79 || COMPILE_TEST)
FWIIW, I would drop the () while we are here.
Quoted 17 lines
drivers/net/ethernet/atheros/Kconfig +1
-1help If you have a network (Ethernet) card belonging to this class, say Y.@@ -19,7 +19,7 @@ if NET_VENDOR_ATHEROS config AG71XX tristate "Atheros AR7XXX/AR9XXX built-in ethernet mac support" - depends on ATH79 + depends on ATH79 || COMPILE_TEST select PHYLINK imply NET_SELFTESTS helpQuoted 4 lines
--
pw-bot: cr