Skip to contentSkip to conversation

docs/manual: fix description of how to reply to <message-id>

PATCH In review Roy Kollen Svendsen 3 participants 3 messages Aug 30, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs/manual: fix description of how to reply to <message-id>

Patch v1 not set to 'superseded' when replying to <message-id> with v2.

I'm using git version 2.46.0. The manual says the following is the correct way to use the '--in-reply-to' option:

git send-email --in-reply-to=<message-id>

---
 docs/manual/contribute.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/manual/contribute.adoc +1 -1
index fe3ae963a5..ffaff6f857 100644
@@ -517,7 +517,7 @@ address you register in
 https://patchwork.ozlabs.org/project/buildroot/list/[patchwork] should
 match the one you use for sending patches to the mailing list.
 
-You can also add the +--in-reply-to <message-id>+ option when
+You can also add the +--in-reply-to=<message-id>+ option when
 submitting a patch to the mailing list. The id of the mail to reply to
 can be found under the "Message Id" tag on
 https://patchwork.ozlabs.org/project/buildroot/list/[patchwork]. The
Signature · 6 lines
2.46.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello,

+BR maintainers in Cc.

Quoted 11 lines · On Fri, 30 Aug 2024 15:55:45 +0200 Roy Kollen Svendsen…

Patch v1 not set to 'superseded' when replying to <message-id> with v2.

I'm using git version 2.46.0. The manual says the following is the correct way to use the '--in-reply-to' option:

git send-email --in-reply-to=<message-id>

---
 docs/manual/contribute.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I have applied to master, because it fixes a bug in the doc. But on my side, I am not a big fan of subsequent iterations being sent as a reply to the previous iteration. I know it has the advantage that patchwork marks the previous iteration as Superseded, but I find it a bit annoying on the mailing list.

What do other BR maintainers think?

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Thomas, All,

On 2024-08-30 19:00 +0200, Thomas Petazzoni spake thusly:

Quoted 3 lines
Quoted 1 line · On Fri, 30 Aug 2024 15:55:45 +0200 Roy Kollen Svendsen…

Patch v1 not set to 'superseded' when replying to <message-id> with v2.

[--SNIP--]

Quoted 7 lines

I have applied to master, because it fixes a bug in the doc. But on my side, I am not a big fan of subsequent iterations being sent as a reply to the previous iteration. I know it has the advantage that patchwork marks the previous iteration as Superseded, but I find it a bit annoying on the mailing list.

What do other BR maintainers think?

I too am not fond of threaded iterations, and I prefer a new thread be opened for each iteration.

If submitters are going as far as to use --in-reply-to, then can as well reference the original thread in the post-commit changelog, or in a cover-letter.

I also like to have such a reference, as I can go and skim over the previous reviews to assess the changes. So, an automatically-superseded patch(set) in patchwork is rather detrimental to my workflow, in fact.

Regards,
Yann E. MORIN.

Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot