configs: riscv: qemu: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION
PATCH v2 1/1 configs: riscv: qemu: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION
From: Bin Meng <[email protected]>
Update qemu_riscv32_virt_defconfig and qemu_riscv64_virt_defconfig to use the latest OpenSBI due to the reason that:
1. they are the main platforms to develop and test OpenSBI
2. latest OpenSBI binaries are always integrated into QEMU as the default bios
---
See v1 @ https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
Changes in v2:
- Only update QEMU defconfig files
configs/qemu_riscv32_virt_defconfig | 2 -- configs/qemu_riscv64_virt_defconfig | 2 -- 2 files changed, 4 deletions(-)
configs/qemu_riscv32_virt_defconfig +0 -2
@@ -29,8 +29,6 @@ BR2_LINUX_KERNEL_IMAGE=y # Bootloader BR2_TARGET_OPENSBI=y -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2" BR2_TARGET_OPENSBI_PLAT="generic" # host-qemu for gitlab testing
configs/qemu_riscv64_virt_defconfig +0 -2
@@ -29,8 +29,6 @@ BR2_LINUX_KERNEL_IMAGE=y # Bootloader BR2_TARGET_OPENSBI=y -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2" BR2_TARGET_OPENSBI_PLAT="generic" # host-qemu for gitlab testing
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 11 lines · Bin Meng
From: Bin Meng <[email protected]>
Update
qemu_riscv32_virt_defconfigandqemu_riscv64_virt_defconfigto use the latest OpenSBI due to the reason that:1. they are the main platforms to develop and test OpenSBI
2. latest OpenSBI binaries are always integrated into QEMU as the default biosSigned-off-by Bin Meng <[email protected]>
Alistair
Quoted 39 lines
---
See v1 @ https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/Changes in v2:
- Only update QEMU defconfig filesconfigs/qemu_riscv32_virt_defconfig | 2 -- configs/qemu_riscv64_virt_defconfig | 2 -- 2 files changed, 4 deletions(-)configs/qemu_riscv32_virt_defconfig +0
-2@@ -29,8 +29,6 @@ BR2_LINUX_KERNEL_IMAGE=y # Bootloader BR2_TARGET_OPENSBI=y -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2" BR2_TARGET_OPENSBI_PLAT="generic" # host-qemu for gitlab testingconfigs/qemu_riscv64_virt_defconfig +0
-3@@ -29,8 +29,6 @@ BR2_LINUX_KERNEL_IMAGE=y # Bootloader BR2_TARGET_OPENSBI=y -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2" BR2_TARGET_OPENSBI_PLAT="generic" # host-qemu for gitlab testing --2.34.1
Quoted 4 lines
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Bin,
Quoted 5 lines · On Thu, 29 Aug 2024 23:41:50 +0800 Bin Meng <[email protected]> wrote:
From: Bin Meng <[email protected]>
Update
qemu_riscv32_virt_defconfigandqemu_riscv64_virt_defconfigto use the latest OpenSBI due to the reason that:
Quoted 7 lines
1. they are the main platforms to develop and test OpenSBI
2. latest OpenSBI binaries are always integrated into QEMU as the default biosSigned-off-by Bin Meng <[email protected]>---
See v1 @ https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
Sorry but no. We _do_ want our defconfigs to specify a custom and fixed version of Linux, U-Boot, OpenSBI, TF-A, etc.
See https://buildroot.org/downloads/manual/manual.html#adding-board-support:
"""
Always use fixed versions or commit hashes for the different components, not the "latest" version. For example, set BR2_LINUX_KERNEL_CUSTOM_VERSION=y and BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE to the kernel version you tested with.
"""
Do not hesitate to send patches to update the OpenSBI version used in those defconfigs, after testing that this update works fine for those particular platforms.
Thanks!
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Thomas,
Quoted 23 lines · Thomas Petazzoni
Hello Bin,
Quoted 5 lines · On Thu, 29 Aug 2024 23:41:50 +0800 Bin Meng <[email protected]> wrote:
From: Bin Meng <[email protected]>
Update
qemu_riscv32_virt_defconfigandqemu_riscv64_virt_defconfigto use the latest OpenSBI due to the reason that:Quoted 7 lines
1. they are the main platforms to develop and test OpenSBI
2. latest OpenSBI binaries are always integrated into QEMU as the default biosSigned-off-by Bin Meng <[email protected]>---
See v1 @ https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/Sorry but no. We _do_ want our defconfigs to specify a custom and fixed version of Linux, U-Boot, OpenSBI, TF-A, etc.
See https://buildroot.org/downloads/manual/manual.html#adding-board-support:
Quoted 7 lines
"""
Always use fixed versions or commit hashes for the different components, not the "latest" version. For example, set BR2_LINUX_KERNEL_CUSTOM_VERSION=y andBR2_LINUX_KERNEL_CUSTOM_VERSION_VALUEto the kernel version you tested with.
"""
QEMU is the special case as I wrote in the commit message, that:
1. they are the main platforms to develop and test OpenSBI
2. latest OpenSBI binaries are always integrated into QEMU as the default bios
So OpenSBI latest version is always tested by the OpenSBI and QEMU community. IMO keeping updating the defconfig for these 2 boards does not make a lot of sense.
Quoted 4 lines
Do not hesitate to send patches to update the OpenSBI version used in those defconfigs, after testing that this update works fine for those particular platforms.
If you still think we should do this, I would argue we completely drop the BR2_TARGET_OPENSBI_LATEST_VERSION config option so that all boards shall explicitely specify the OpenSBI version in their defconfig files.
Regards,
Bin
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot