Skip to contentSkip to conversation

iio: adc: mcp320x: Drop vendorless compatible strings

PATCH Applied Rob Herring (Arm) 2 participants 2 messages Aug 26, 2024 – Aug 31, 2024 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: mcp320x: Drop vendorless compatible strings

The vendorless compatible strings are deprecated and weren't retained when the binding was converted to schema. As a result, they are listed as undocumented when running "make dt_compatible_check". Rather than add them back to the schema, let's just drop them as they are unnecessary. Furthermore, they are unnecessary as the SPI matching will strip the vendor prefix on compatible string and match that against the spi_device_id table.

---
 drivers/iio/adc/mcp320x.c | 10 ----------
 1 file changed, 10 deletions(-)
drivers/iio/adc/mcp320x.c +0 -10
index da1421bd7b62..57cff3772ebe 100644
@@ -459,16 +459,6 @@ static int mcp320x_probe(struct spi_device *spi)
 }
 
 static const struct of_device_id mcp320x_dt_ids[] = {
-	/* NOTE: The use of compatibles with no vendor prefix is deprecated. */
-	{ .compatible = "mcp3001" },
-	{ .compatible = "mcp3002" },
-	{ .compatible = "mcp3004" },
-	{ .compatible = "mcp3008" },
-	{ .compatible = "mcp3201" },
-	{ .compatible = "mcp3202" },
-	{ .compatible = "mcp3204" },
-	{ .compatible = "mcp3208" },
-	{ .compatible = "mcp3301" },
 	{ .compatible = "microchip,mcp3001" },
 	{ .compatible = "microchip,mcp3002" },
 	{ .compatible = "microchip,mcp3004" },
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 9 lines · On Mon, 26 Aug 2024 14:17:28 -0500 "Rob Herring (Arm)" <[email protected]> wrote:

The vendorless compatible strings are deprecated and weren't retained when the binding was converted to schema. As a result, they are listed as undocumented when running "make dt_compatible_check". Rather than add them back to the schema, let's just drop them as they are unnecessary. Furthermore, they are unnecessary as the SPI matching will strip the vendor prefix on compatible string and match that against the spi_device_id table.

Applied.

Thanks,

Quoted 25 lines
---
 drivers/iio/adc/mcp320x.c | 10 ----------
 1 file changed, 10 deletions(-)
drivers/iio/adc/mcp320x.c +0 -10
index da1421bd7b62..57cff3772ebe 100644
@@ -459,16 +459,6 @@ static int mcp320x_probe(struct spi_device *spi)
 }
 
 static const struct of_device_id mcp320x_dt_ids[] = {
-	/* NOTE: The use of compatibles with no vendor prefix is deprecated. */
-	{ .compatible = "mcp3001" },
-	{ .compatible = "mcp3002" },
-	{ .compatible = "mcp3004" },
-	{ .compatible = "mcp3008" },
-	{ .compatible = "mcp3201" },
-	{ .compatible = "mcp3202" },
-	{ .compatible = "mcp3204" },
-	{ .compatible = "mcp3208" },
-	{ .compatible = "mcp3301" },
 	{ .compatible = "microchip,mcp3001" },
 	{ .compatible = "microchip,mcp3002" },
 	{ .compatible = "microchip,mcp3004" },