Skip to contentSkip to conversation

mm-added-node_reclaim-successes-to-vm-event-counters.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Sep 2, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm: add node_reclaim successes to VM event counters
has been removed from the -mm tree. Its filename was
mm-added-node_reclaim-successes-to-vm-event-counters.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Matthew Cassell <[email protected]>
Subject: mm: add node_reclaim successes to VM event counters
Date: Mon, 22 Jul 2024 17:13:16 +0000

/proc/vmstat currently shows the number of node_reclaim() failures when vm.zone_reclaim_mode is set appropriately. It would be convenient to have the number of successes right next to zone_reclaim_failed (similar to compaction and migration).

While just a trivially addition to the vmstat file. It was helpful during benchmarking to not have to probe node_reclaim() to observe the success/failure ratio.

---

 include/linux/vm_event_item.h |    1 +
 mm/vmscan.c                   |    4 +++-
 mm/vmstat.c                   |    1 +
 3 files changed, 5 insertions(+), 1 deletion(-)
include/linux/vm_event_item.h renamed from include/linux/vm_event_item.h~mm-added-node_reclaim-successes-to-vm-event-counters +1 -0
@@ -50,6 +50,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PS
 		PGSTEAL_ANON,
 		PGSTEAL_FILE,
 #ifdef CONFIG_NUMA
+		PGSCAN_ZONE_RECLAIM_SUCCESS,
 		PGSCAN_ZONE_RECLAIM_FAILED,
 #endif
 		PGINODESTEAL, SLABS_SCANNED, KSWAPD_INODESTEAL,
mm/vmscan.c renamed from mm/vmscan.c~mm-added-node_reclaim-successes-to-vm-event-counters +3 -1
@@ -7539,7 +7539,9 @@ int node_reclaim(struct pglist_data *pgd
 	ret = __node_reclaim(pgdat, gfp_mask, order);
 	clear_bit(PGDAT_RECLAIM_LOCKED, &pgdat->flags);
 
-	if (!ret)
+	if (ret)
+		count_vm_event(PGSCAN_ZONE_RECLAIM_SUCCESS);
+	else
 		count_vm_event(PGSCAN_ZONE_RECLAIM_FAILED);
 
 	return ret;
mm/vmstat.c renamed from mm/vmstat.c~mm-added-node_reclaim-successes-to-vm-event-counters +1 -0
@@ -1314,6 +1314,7 @@ const char * const vmstat_text[] = {
 	"pgsteal_file",
 
 #ifdef CONFIG_NUMA
+	"zone_reclaim_success",
 	"zone_reclaim_failed",
 #endif
 	"pginodesteal",

_

Patches currently in -mm which might be from [email protected] are