kfence-introduce-burst-mode.patch removed from -mm tree
The quilt patch titled
Subject: kfence: introduce burst mode
has been removed from the -mm tree. Its filename was
kfence-introduce-burst-mode.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Marco Elver <[email protected]>
Subject: kfence: introduce burst mode
Date: Mon, 5 Aug 2024 14:39:39 +0200
Introduce burst mode, which can be configured with kfence.burst=$count, where the burst count denotes the additional successive slab allocations to be allocated through KFENCE for each sample interval.
The idea is that this can give developers an additional knob to make KFENCE more aggressive when debugging specific issues of systems where either rebooting or recompiling the kernel with KASAN is not possible.
Experiment: To assess the effectiveness of the new option, we randomly picked a recent out-of-bounds [1] and use-after-free bug [2], each with a reproducer provided by syzbot, that initially detected these bugs with KASAN. We then tried to reproduce the bugs with KFENCE below.
[1] Fixed by: 7c55b78818cf ("jfs: xattr: fix buffer overflow for invalid xattr")
https://syzkaller.appspot.com/bug?id=9d1b59d4718239da6f6069d3891863c25f9f24a2 [2] Fixed by: f8ad00f3fb2a ("l2tp: fix possible UAF when cleaning up tunnels") https://syzkaller.appspot.com/bug?id=4f34adc84f4a3b080187c390eeef60611fd450e1
The following KFENCE configs were compared. A pool size of 1023 objects was used for all configurations.
Baseline kfence.sample_interval=100 kfence.skip_covered_thresh=75 kfence.burst=0 Aggressive kfence.sample_interval=1 kfence.skip_covered_thresh=10 kfence.burst=0 AggressiveBurst kfence.sample_interval=1 kfence.skip_covered_thresh=10 kfence.burst=1000
Each reproducer was run 10 times (after a fresh reboot), with the following detection counts for each KFENCE config:
| Detection Count out of 10 |
| OOB [1] | UAF [2] |
------------------+-------------+-------------+
Default | 0/10 | 0/10 |
Aggressive | 0/10 | 0/10 |
AggressiveBurst | 8/10 | 8/10 |With the Default and even the Aggressive configs the results are unsurprising, given KFENCE has not been designed for deterministic bug detection of small test cases.
However, when enabling burst mode with relatively large burst count, KFENCE can start to detect heap memory-safety bugs even in simpler test cases with high probability (in the above cases with ~80% probability).
---
Documentation/dev-tools/kfence.rst | 7 +++++++ include/linux/kfence.h | 2 +- mm/kfence/core.c | 14 ++++++++++---- 3 files changed, 18 insertions(+), 5 deletions(-)
Documentation/dev-tools/kfence.rst renamed from Documentation/dev-tools/kfence.rst~kfence-introduce-burst-mode +7 -0
@@ -53,6 +53,13 @@ configurable via the Kconfig option ``CO The KUnit test suite is very likely to fail when using a deferrable timer since it currently causes very unpredictable sample intervals. +By default KFENCE will only sample 1 heap allocation within each sample +interval. *Burst mode* allows to sample successive heap allocations, where the +kernel boot parameter ``kfence.burst`` can be set to a non-zero value which +denotes the *additional* successive allocations within a sample interval; +setting ``kfence.burst=N`` means that ``1 + N`` successive allocations are +attempted through KFENCE for each sample interval. + The KFENCE memory pool is of fixed size, and if the pool is exhausted, no further KFENCE allocations occur. With ``CONFIG_KFENCE_NUM_OBJECTS`` (default 255), the number of available guarded objects can be controlled. Each object
include/linux/kfence.h renamed from include/linux/kfence.h~kfence-introduce-burst-mode +1 -1
@@ -124,7 +124,7 @@ static __always_inline void *kfence_alloif (!static_branch_likely (&kfence_allocation_key))return NULL ;#endif -if (likely (atomic_read (&kfence_allocation_gate))) +if (likely (atomic_read (&kfence_allocation_gate) >0 ))return NULL ;return __kfence_alloc (s, size, flags); }
mm/kfence/core.c renamed from mm/kfence/core.c~kfence-introduce-burst-mode +10 -4
@@ -99,6 +99,10 @@ module_param_cb(sample_interval, &samplestatic unsigned long kfence_skip_covered_thresh__read_mostly =75 ;module_param_named (skip_covered_thresh, kfence_skip_covered_thresh, ulong,0644 ); +/* Allocation burst count: number of excess KFENCE allocations per sample. */ +static unsigned int kfence_burst__read_mostly ; +module_param_named (burst, kfence_burst, uint,0644 ); +/* If true, use a deferrable timer. */ static bool kfence_deferrable__read_mostly =IS_ENABLED (CONFIG_KFENCE_DEFERRABLE );module_param_named (deferrable, kfence_deferrable, bool,0444 );
@@ -827,12 +831,12 @@ static void toggle_allocation_gate(strucif (!READ_ONCE (kfence_enabled))return ; -atomic_set (&kfence_allocation_gate,0 ); +atomic_set (&kfence_allocation_gate, -kfence_burst);#ifdef CONFIG_KFENCE_STATIC_KEYS /* Enable static key, and await allocation to happen. */ static_branch_enable (&kfence_allocation_key); -wait_event_idle (allocation_wait,atomic_read (&kfence_allocation_gate)); +wait_event_idle (allocation_wait,atomic_read (&kfence_allocation_gate) >0 );/* Disable static key and reset timer. */ static_branch_disable (&kfence_allocation_key);
@@ -1052,6 +1056,7 @@ void *__kfence_alloc(struct kmem_cache *unsigned long stack_entries[KFENCE_STACK_DEPTH ];size_t num_stack_entries;u32 alloc_stack_hash; +int allocation_gate;/* * Perform size check before switching kfence_allocation_gate, so that
@@ -1080,14 +1085,15 @@ void *__kfence_alloc(struct kmem_cache *if (s->flags &SLAB_SKIP_KFENCE )return NULL ; -if (atomic_inc_return (&kfence_allocation_gate) >1 ) + allocation_gate =atomic_inc_return (&kfence_allocation_gate); +if (allocation_gate >1 )return NULL ;#ifdef CONFIG_KFENCE_STATIC_KEYS /* * waitqueue_active() is fully ordered after the update of * kfence_allocation_gate per atomic_inc_return(). */ -if (waitqueue_active (&allocation_wait)) { +if (allocation_gate ==1 &&waitqueue_active (&allocation_wait)) {/* * Calling wake_up() here may deadlock when allocations happen * from within timer code. Use an irq_work to defer it.
_
Patches currently in -mm which might be from [email protected] are