kvm/i386: declare kvm_filter_msr() static
PATCH 1/1 kvm/i386: declare kvm_filter_msr() static
kvm_filer_msr() is only used from i386 kvm module. Make it static so that its easy for developers to understand that its not used anywhere else.
Signed-off-by Ani Sinha <[email protected]>
--- target/i386/kvm/kvm.c | 4 +++- target/i386/kvm/kvm_i386.h | 3 --- 2 files changed, 3 insertions(+), 4 deletions(-)
target/i386/kvm/kvm.c +3 -1
@@ -93,6 +93,8 @@#define MSR_BUF_SIZE 4096static void kvm_init_msrs (X86CPU *cpu); +static bool kvm_filter_msr (KVMState *s,uint32_t msr,QEMURDMSRHandler *rdmsr, +QEMUWRMSRHandler *wrmsr);const KVMCapabilityInfo kvm_arch_required_capabilities[] = {KVM_CAP_INFO (SET_TSS_ADDR ),
@@ -5728,7 +5730,7 @@ static bool kvm_install_msr_filters(KVMState *s)return true; } -bool kvm_filter_msr (KVMState *s,uint32_t msr,QEMURDMSRHandler *rdmsr, +static bool kvm_filter_msr (KVMState *s,uint32_t msr,QEMURDMSRHandler *rdmsr,QEMUWRMSRHandler *wrmsr) {int i;
target/i386/kvm/kvm_i386.h +0 -3
@@ -74,9 +74,6 @@ typedef struct kvm_msr_handlers { QEMUWRMSRHandler *wrmsr; } KVMMSRHandlers; -bool kvm_filter_msr (KVMState *s,uint32_t msr,QEMURDMSRHandler *rdmsr, -QEMUWRMSRHandler *wrmsr); -#endif /* CONFIG_KVM */ void kvm_pc_setup_irq_routing (bool pci_enabled);
Signature · 1 line
2.42.0
Quoted 14 lines · Ani Sinha
kvm_filer_msr()is only used from i386 kvm module. Make it static so that its easy for developers to understand that its not used anywhere else.Signed-off-by Ani Sinha <[email protected]>--- target/i386/kvm/kvm.c | 4 +++- target/i386/kvm/kvm_i386.h | 3 --- 2 files changed, 3 insertions(+), 4 deletions(-)target/i386/kvm/kvm_i386.h +0
-0
target/i386/kvm/kvm_i386.h typedef struct kvm_msr_handlers { · line 75
Quoted 2 lines
target/i386/kvm/kvm_i386.h +0
-0@@ -74,9 +74,6 @@ typedef struct kvm_msr_handlers {QEMUWRMSRHandler *wrmsr; } KVMMSRHandlers;
Isn't it also valid for QEMURDMSRHandler, QEMUWRMSRHandler and KVMMSRHandlers definitions?
Quoted 5 lines
target/i386/kvm/kvm_i386.h +0
-3-bool kvm_filter_msr (KVMState *s,uint32_t msr,QEMURDMSRHandler *rdmsr, -QEMUWRMSRHandler *wrmsr); -#endif /* CONFIG_KVM */